From 86b3993ceec0c64f4aed02a498fc747ce91eb682 Mon Sep 17 00:00:00 2001 From: Takashi NATSUME Date: Thu, 14 Mar 2019 09:05:21 +0900 Subject: [PATCH] Fix misuse of assertTrue/assertFalse Change-Id: I247705feeb71e20ad5260b0ca1da08de7290ba6e Closes-Bug: #1819982 --- neutron/tests/unit/notifiers/test_nova.py | 4 ++-- neutron/tests/unit/services/placement_report/test_plugin.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/neutron/tests/unit/notifiers/test_nova.py b/neutron/tests/unit/notifiers/test_nova.py index 80d2aec6cad..96d7bbaafbb 100644 --- a/neutron/tests/unit/notifiers/test_nova.py +++ b/neutron/tests/unit/notifiers/test_nova.py @@ -167,7 +167,7 @@ class TestNovaNotify(base.BaseTestCase): event = self.nova_notifier.create_port_changed_event( 'create_floatingip', {}, returned_obj) - self.assertFalse(event, None) + self.assertIsNone(event) def test_delete_floatingip_notify(self): device_id = '32102d7b-1cf4-404d-b50a-97aae1f55f87' @@ -233,7 +233,7 @@ class TestNovaNotify(base.BaseTestCase): 'send_events') as send_events: self.nova_notifier.send_network_change('update_floatingip', {}, {}) - self.assertFalse(send_events.called, False) + self.assertFalse(send_events.called) @mock.patch('novaclient.client.Client') def test_nova_send_events_returns_bad_list(self, mock_client): diff --git a/neutron/tests/unit/services/placement_report/test_plugin.py b/neutron/tests/unit/services/placement_report/test_plugin.py index 2eae9445d8a..76dc9913f51 100644 --- a/neutron/tests/unit/services/placement_report/test_plugin.py +++ b/neutron/tests/unit/services/placement_report/test_plugin.py @@ -188,7 +188,7 @@ class PlacementReporterAgentsTestCases(test_plugin.Ml2PluginV2TestCase): self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin) mech_driver = self.agents.mechanism_driver_by_agent_type( 'test_mechanism_driver_agent') - self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver) + self.assertIsInstance(mech_driver, mechanism_test.TestMechanismDriver) def test_mechanism_driver_by_agent_type_not_found(self): self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)