openstack
/
neutron
Code Issues Proposed changes

Mocking ryu plugin notifier in ryu plugin test 

Previously RPC notifier is not mocked in ryu plugin test and the
plugin tries to send RPC notifications. It may interact with
impl_fake RPC set up in previous tests by other plugin
and sometimes leads to unexpected ovs-vsctl invoking.

Change-Id: I11714a160faa4d3ded7f312c39afba0b426ccd8a
Closes-Bug: #1255421
(cherry picked from commit dc2f567df3)
This commit is contained in:
Akihiro Motoki 2013-11-27 19:09:01 +09:00
parent c93d69944a
commit b52de8a3a9
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
neutron/tests/unit/ryu/test_ryu_plugin.py
View File

@ -13,6 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import mock
from neutron import manager
from neutron.plugins.ryu.db import models_v2 as ryu_models_v2 # noqa
from neutron.tests.unit.ryu import fake_ryu
from neutron.tests.unit import test_db_plugin as test_plugin
@ -27,6 +30,8 @@ class RyuPluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):
self.ryu_patcher.start()
super(RyuPluginV2TestCase, self).setUp(self._plugin_name)
self.addCleanup(self.ryu_patcher.stop)
plugin = manager.NeutronManager.get_plugin()
plugin.notifier = mock.Mock()
class TestRyuBasicGet(test_plugin.TestBasicGet, RyuPluginV2TestCase):