openstack
/
neutron
Code Issues Proposed changes

Create temp file in setUp() to avoid warning 

The tempfile in test_unwatch_log() generates a warning
in the 'cover' tests:

sys:1: ResourceWarning: unclosed file
<_io.TextIOWrapper name='/var/tmp/tmpz1l83cix/tmpjz5uavc7/
 watch_log_temp_file_name' mode='a' encoding='UTF-8'>

Create it in setUp() which will trigger an automatic
cleanup on test completion.

Trivialfix

Change-Id: I816ac65a935250f8606dba75d7080eb9c384fceb
This commit is contained in:
Brian Haley 2018-09-28 15:57:51 -04:00 committed by Slawek Kaplonski
parent 00de8f9a9e
commit bb7b5a1e81
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron/tests/unit/agent/linux/test_daemon.py
View File

@ -35,13 +35,15 @@ class FakeEntry(object):
class TestUnwatchLog(base.BaseTestCase):
def setUp(self):
super(TestUnwatchLog, self).setUp()
self.temp_file = self.get_temp_file_path('unwatch_log_temp_file')
def test_unwatch_log(self):
temp_file_name = self.get_temp_file_path('unwatch_log_temp_file_name')
stream_handler = logging.StreamHandler()
logger = logging.Logger('fake')
logger.addHandler(stream_handler)
logger.addHandler(handlers.WatchedFileHandler(temp_file_name))
logger.addHandler(handlers.WatchedFileHandler(self.temp_file))
with mock.patch('logging.getLogger', return_value=logger):
daemon.unwatch_log()
@ -49,7 +51,7 @@ class TestUnwatchLog(base.BaseTestCase):
logger.handlers.remove(stream_handler)
observed = logger.handlers[0]
self.assertEqual(logging.FileHandler, type(observed))
self.assertEqual(temp_file_name, observed.baseFilename)
self.assertEqual(self.temp_file, observed.baseFilename)
class TestPrivileges(base.BaseTestCase):