459 lines
20 KiB
Python
459 lines
20 KiB
Python
# Copyright 2014 Mellanox Technologies, Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
|
|
import mock
|
|
from oslo_config import cfg
|
|
from oslo_utils import uuidutils
|
|
|
|
from neutron.agent.l2.extensions import manager as l2_ext_manager
|
|
from neutron.agent import rpc as agent_rpc
|
|
from neutron.extensions import portbindings
|
|
from neutron.plugins.ml2.drivers.mech_sriov.agent.common import config # noqa
|
|
from neutron.plugins.ml2.drivers.mech_sriov.agent.common import exceptions
|
|
from neutron.plugins.ml2.drivers.mech_sriov.agent import sriov_nic_agent
|
|
from neutron.tests import base
|
|
|
|
DEVICE_MAC = '11:22:33:44:55:66'
|
|
PCI_SLOT = "0000:06:00.1"
|
|
|
|
|
|
class TestSriovAgent(base.BaseTestCase):
|
|
def setUp(self):
|
|
super(TestSriovAgent, self).setUp()
|
|
# disable setting up periodic state reporting
|
|
cfg.CONF.set_override('report_interval', 0, 'AGENT')
|
|
cfg.CONF.set_default('firewall_driver',
|
|
'neutron.agent.firewall.NoopFirewallDriver',
|
|
group='SECURITYGROUP')
|
|
cfg.CONF.set_default('enable_security_group',
|
|
False,
|
|
group='SECURITYGROUP')
|
|
|
|
class MockFixedIntervalLoopingCall(object):
|
|
def __init__(self, f):
|
|
self.f = f
|
|
|
|
def start(self, interval=0):
|
|
self.f()
|
|
|
|
mock.patch('oslo_service.loopingcall.'
|
|
'FixedIntervalLoopingCall',
|
|
new=MockFixedIntervalLoopingCall)
|
|
|
|
self.agent = sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)
|
|
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent.eswitch_manager"
|
|
".ESwitchManager.get_assigned_devices_info", return_value=set())
|
|
@mock.patch.object(agent_rpc.PluginReportStateAPI, 'report_state')
|
|
def test_cached_device_count_report_state(self, report_state, get_dev):
|
|
self.agent._report_state()
|
|
agent_conf = self.agent.agent_state['configurations']
|
|
# ensure devices aren't calculated until first scan_devices call
|
|
self.assertNotIn('devices', agent_conf)
|
|
self.agent.scan_devices(set(), set())
|
|
self.assertEqual(0, agent_conf['devices'])
|
|
# ensure report_state doesn't call get_dev
|
|
get_dev.reset_mock()
|
|
get_dev.return_value = set(['dev1', 'dev2'])
|
|
self.agent._report_state()
|
|
self.assertEqual(0, agent_conf['devices'])
|
|
# after a device scan, conf should bump to 2
|
|
self.agent.scan_devices(set(), set())
|
|
self.assertEqual(2, agent_conf['devices'])
|
|
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent.pci_lib."
|
|
"PciDeviceIPWrapper.get_assigned_macs",
|
|
return_value=[(DEVICE_MAC, PCI_SLOT)])
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent."
|
|
"eswitch_manager.PciOsWrapper.is_assigned_vf",
|
|
return_value=True)
|
|
def test_treat_devices_removed_with_existed_device(self, *args):
|
|
agent = sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)
|
|
devices = [(DEVICE_MAC, PCI_SLOT)]
|
|
with mock.patch.object(agent.plugin_rpc,
|
|
"update_device_down") as fn_udd:
|
|
fn_udd.return_value = {'device': DEVICE_MAC,
|
|
'exists': True}
|
|
resync = agent.treat_devices_removed(devices)
|
|
self.assertFalse(resync)
|
|
self.assertTrue(fn_udd.called)
|
|
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent.pci_lib."
|
|
"PciDeviceIPWrapper.get_assigned_macs",
|
|
return_value=[(DEVICE_MAC, PCI_SLOT)])
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent."
|
|
"eswitch_manager.PciOsWrapper.is_assigned_vf",
|
|
return_value=True)
|
|
def test_treat_devices_removed_with_not_existed_device(self, *args):
|
|
agent = sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)
|
|
devices = [(DEVICE_MAC, PCI_SLOT)]
|
|
with mock.patch.object(agent.plugin_rpc,
|
|
"update_device_down") as fn_udd:
|
|
fn_udd.return_value = {'device': DEVICE_MAC,
|
|
'exists': False}
|
|
with mock.patch.object(sriov_nic_agent.LOG,
|
|
'debug') as log:
|
|
resync = agent.treat_devices_removed(devices)
|
|
self.assertEqual(1, log.call_count)
|
|
self.assertFalse(resync)
|
|
self.assertTrue(fn_udd.called)
|
|
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent.pci_lib."
|
|
"PciDeviceIPWrapper.get_assigned_macs",
|
|
return_value=[(DEVICE_MAC, PCI_SLOT)])
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent."
|
|
"eswitch_manager.PciOsWrapper.is_assigned_vf",
|
|
return_value=True)
|
|
def test_treat_devices_removed_failed(self, *args):
|
|
agent = sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)
|
|
devices = [(DEVICE_MAC, PCI_SLOT)]
|
|
with mock.patch.object(agent.plugin_rpc,
|
|
"update_device_down") as fn_udd:
|
|
fn_udd.side_effect = Exception()
|
|
with mock.patch.object(sriov_nic_agent.LOG,
|
|
'debug') as log:
|
|
resync = agent.treat_devices_removed(devices)
|
|
self.assertEqual(1, log.call_count)
|
|
self.assertTrue(resync)
|
|
self.assertTrue(fn_udd.called)
|
|
|
|
def mock_scan_devices(self, expected, mock_current,
|
|
registered_devices, updated_devices):
|
|
self.agent.eswitch_mgr = mock.Mock()
|
|
self.agent.eswitch_mgr.get_assigned_devices_info.return_value = (
|
|
mock_current)
|
|
|
|
results = self.agent.scan_devices(registered_devices, updated_devices)
|
|
self.assertEqual(expected, results)
|
|
|
|
def test_scan_devices_returns_empty_sets(self):
|
|
registered = set()
|
|
updated = set()
|
|
mock_current = set()
|
|
expected = {'current': set(),
|
|
'updated': set(),
|
|
'added': set(),
|
|
'removed': set()}
|
|
self.mock_scan_devices(expected, mock_current, registered, updated)
|
|
|
|
def test_scan_devices_no_changes(self):
|
|
registered = set(['1', '2'])
|
|
updated = set()
|
|
mock_current = set(['1', '2'])
|
|
expected = {'current': set(['1', '2']),
|
|
'updated': set(),
|
|
'added': set(),
|
|
'removed': set()}
|
|
self.mock_scan_devices(expected, mock_current, registered, updated)
|
|
|
|
def test_scan_devices_new_and_removed(self):
|
|
registered = set(['1', '2'])
|
|
updated = set()
|
|
mock_current = set(['2', '3'])
|
|
expected = {'current': set(['2', '3']),
|
|
'updated': set(),
|
|
'added': set(['3']),
|
|
'removed': set(['1'])}
|
|
self.mock_scan_devices(expected, mock_current, registered, updated)
|
|
|
|
def test_scan_devices_updated_and_removed(self):
|
|
registered = set(['1', '2'])
|
|
# '1' is in removed and updated tuple
|
|
updated = set(['1'])
|
|
mock_current = set(['2', '3'])
|
|
expected = {'current': set(['2', '3']),
|
|
'updated': set(),
|
|
'added': set(['3']),
|
|
'removed': set(['1'])}
|
|
self.mock_scan_devices(expected, mock_current, registered, updated)
|
|
|
|
def test_scan_devices_new_updates(self):
|
|
registered = set(['1'])
|
|
updated = set(['2'])
|
|
mock_current = set(['1', '2'])
|
|
expected = {'current': set(['1', '2']),
|
|
'updated': set(['2']),
|
|
'added': set(['2']),
|
|
'removed': set()}
|
|
self.mock_scan_devices(expected, mock_current, registered, updated)
|
|
|
|
def test_scan_devices_updated_missing(self):
|
|
registered = set(['1'])
|
|
updated = set(['2'])
|
|
mock_current = set(['1'])
|
|
expected = {'current': set(['1']),
|
|
'updated': set(),
|
|
'added': set(),
|
|
'removed': set()}
|
|
self.mock_scan_devices(expected, mock_current, registered, updated)
|
|
|
|
def test_process_network_devices(self):
|
|
agent = self.agent
|
|
device_info = {'current': set(),
|
|
'added': set(['mac3', 'mac4']),
|
|
'updated': set(['mac2', 'mac3']),
|
|
'removed': set(['mac1'])}
|
|
agent.sg_agent.prepare_devices_filter = mock.Mock()
|
|
agent.sg_agent.refresh_firewall = mock.Mock()
|
|
agent.treat_devices_added_updated = mock.Mock(return_value=False)
|
|
agent.treat_devices_removed = mock.Mock(return_value=False)
|
|
|
|
agent.process_network_devices(device_info)
|
|
|
|
agent.sg_agent.prepare_devices_filter.assert_called_with(
|
|
set(['mac3', 'mac4']))
|
|
self.assertTrue(agent.sg_agent.refresh_firewall.called)
|
|
agent.treat_devices_added_updated.assert_called_with(set(['mac2',
|
|
'mac3',
|
|
'mac4']))
|
|
agent.treat_devices_removed.assert_called_with(set(['mac1']))
|
|
|
|
def test_treat_devices_added_updated_and_removed(self):
|
|
agent = self.agent
|
|
MAC1 = 'aa:bb:cc:dd:ee:ff'
|
|
SLOT1 = '1:2:3.0'
|
|
MAC2 = 'aa:bb:cc:dd:ee:fe'
|
|
SLOT2 = '1:3:3.0'
|
|
mac_pci_slot_device1 = (MAC1, SLOT1)
|
|
mac_pci_slot_device2 = (MAC2, SLOT2)
|
|
mock_device1_details = {'device': MAC1,
|
|
'port_id': 'port123',
|
|
'network_id': 'net123',
|
|
'admin_state_up': True,
|
|
'network_type': 'vlan',
|
|
'segmentation_id': 100,
|
|
'profile': {'pci_slot': SLOT1},
|
|
'physical_network': 'physnet1',
|
|
'port_security_enabled': False}
|
|
mock_device2_details = {'device': MAC2,
|
|
'port_id': 'port124',
|
|
'network_id': 'net123',
|
|
'admin_state_up': True,
|
|
'network_type': 'vlan',
|
|
'segmentation_id': 100,
|
|
'profile': {'pci_slot': SLOT2},
|
|
'physical_network': 'physnet1',
|
|
'port_security_enabled': False}
|
|
agent.plugin_rpc = mock.Mock()
|
|
agent.plugin_rpc.get_devices_details_list.return_value = (
|
|
[mock_device1_details])
|
|
agent.treat_devices_added_updated(set([MAC1]))
|
|
self.assertEqual({'net123': [{'port_id': 'port123',
|
|
'device': mac_pci_slot_device1}]},
|
|
agent.network_ports)
|
|
agent.plugin_rpc.get_devices_details_list.return_value = (
|
|
[mock_device2_details])
|
|
# add the second device and check the network_ports dict
|
|
agent.treat_devices_added_updated(set([MAC2]))
|
|
self.assertEqual(
|
|
{'net123': [{'port_id': 'port123',
|
|
'device': mac_pci_slot_device1}, {'port_id': 'port124',
|
|
'device': mac_pci_slot_device2}]},
|
|
agent.network_ports)
|
|
with mock.patch.object(agent.plugin_rpc,
|
|
"update_device_down"):
|
|
agent.treat_devices_removed([mac_pci_slot_device2])
|
|
# remove the second device and check the network_ports dict
|
|
self.assertEqual({'net123': [{'port_id': 'port123',
|
|
'device': mac_pci_slot_device1}]},
|
|
agent.network_ports)
|
|
|
|
def test_treat_devices_added_updated_admin_state_up_true(self):
|
|
agent = self.agent
|
|
mock_details = {'device': 'aa:bb:cc:dd:ee:ff',
|
|
'port_id': 'port123',
|
|
'network_id': 'net123',
|
|
'admin_state_up': True,
|
|
'network_type': 'vlan',
|
|
'segmentation_id': 100,
|
|
'profile': {'pci_slot': '1:2:3.0'},
|
|
'physical_network': 'physnet1',
|
|
'port_security_enabled': False}
|
|
agent.plugin_rpc = mock.Mock()
|
|
agent.plugin_rpc.get_devices_details_list.return_value = [mock_details]
|
|
agent.eswitch_mgr = mock.Mock()
|
|
agent.eswitch_mgr.device_exists.return_value = True
|
|
agent.set_device_state = mock.Mock()
|
|
agent.set_device_spoofcheck = mock.Mock()
|
|
resync_needed = agent.treat_devices_added_updated(
|
|
set(['aa:bb:cc:dd:ee:ff']))
|
|
|
|
self.assertFalse(resync_needed)
|
|
agent.eswitch_mgr.device_exists.assert_called_with('aa:bb:cc:dd:ee:ff',
|
|
'1:2:3.0')
|
|
agent.eswitch_mgr.set_device_state.assert_called_with(
|
|
'aa:bb:cc:dd:ee:ff',
|
|
'1:2:3.0',
|
|
True)
|
|
agent.eswitch_mgr.set_device_spoofcheck.assert_called_with(
|
|
'aa:bb:cc:dd:ee:ff',
|
|
'1:2:3.0',
|
|
False)
|
|
self.assertTrue(agent.plugin_rpc.update_device_up.called)
|
|
|
|
def test_treat_device_ip_link_state_not_supported(self):
|
|
agent = self.agent
|
|
agent.plugin_rpc = mock.Mock()
|
|
agent.eswitch_mgr = mock.Mock()
|
|
agent.eswitch_mgr.device_exists.return_value = True
|
|
agent.eswitch_mgr.set_device_state.side_effect = (
|
|
exceptions.IpCommandOperationNotSupportedError(
|
|
dev_name='aa:bb:cc:dd:ee:ff'))
|
|
|
|
agent.treat_device('aa:bb:cc:dd:ee:ff', '1:2:3:0',
|
|
admin_state_up=True)
|
|
self.assertTrue(agent.plugin_rpc.update_device_up.called)
|
|
|
|
def test_treat_device_set_device_state_exception(self):
|
|
agent = self.agent
|
|
agent.plugin_rpc = mock.Mock()
|
|
agent.eswitch_mgr = mock.Mock()
|
|
agent.eswitch_mgr.device_exists.return_value = True
|
|
agent.eswitch_mgr.set_device_state.side_effect = (
|
|
exceptions.SriovNicError())
|
|
|
|
agent.treat_device('aa:bb:cc:dd:ee:ff', '1:2:3:0',
|
|
admin_state_up=True)
|
|
self.assertFalse(agent.plugin_rpc.update_device_up.called)
|
|
|
|
def test_treat_devices_added_updated_admin_state_up_false(self):
|
|
agent = self.agent
|
|
mock_details = {'device': 'aa:bb:cc:dd:ee:ff',
|
|
'port_id': 'port123',
|
|
'network_id': 'net123',
|
|
'admin_state_up': False,
|
|
'network_type': 'vlan',
|
|
'segmentation_id': 100,
|
|
'profile': {'pci_slot': '1:2:3.0'},
|
|
'physical_network': 'physnet1'}
|
|
agent.plugin_rpc = mock.Mock()
|
|
agent.plugin_rpc.get_devices_details_list.return_value = [mock_details]
|
|
agent.remove_port_binding = mock.Mock()
|
|
resync_needed = agent.treat_devices_added_updated(
|
|
set(['aa:bb:cc:dd:ee:ff']))
|
|
|
|
self.assertFalse(resync_needed)
|
|
self.assertFalse(agent.plugin_rpc.update_device_up.called)
|
|
|
|
def test_update_and_clean_network_ports(self):
|
|
network_id1 = 'network_id1'
|
|
network_id2 = 'network_id2'
|
|
|
|
port_id1 = 'port_id1'
|
|
port_id2 = 'port_id2'
|
|
mac_slot_1 = ('mac1', 'slot1')
|
|
mac_slot_2 = ('mac2', 'slot2')
|
|
|
|
self.agent.network_ports[network_id1] = [{'port_id': port_id1,
|
|
'device': mac_slot_1}, {'port_id': port_id2, 'device': mac_slot_2}]
|
|
|
|
self.agent._update_network_ports(network_id2, port_id1, mac_slot_1)
|
|
|
|
self.assertEqual({network_id1: [{'port_id': port_id2,
|
|
'device': mac_slot_2}], network_id2: [
|
|
{'port_id': port_id1, 'device': mac_slot_1}]},
|
|
self.agent.network_ports)
|
|
|
|
cleaned_port_id = self.agent._clean_network_ports(mac_slot_1)
|
|
self.assertEqual(cleaned_port_id, port_id1)
|
|
|
|
self.assertEqual({network_id1: [{'port_id': port_id2,
|
|
'device': mac_slot_2}]},
|
|
self.agent.network_ports)
|
|
|
|
cleaned_port_id = self.agent._clean_network_ports(mac_slot_2)
|
|
self.assertEqual({}, self.agent.network_ports)
|
|
|
|
|
|
class FakeAgent(object):
|
|
def __init__(self):
|
|
self.updated_devices = set()
|
|
|
|
|
|
class TestSriovNicSwitchRpcCallbacks(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestSriovNicSwitchRpcCallbacks, self).setUp()
|
|
self.context = object()
|
|
self.agent = FakeAgent()
|
|
sg_agent = object()
|
|
self.sriov_rpc_callback = sriov_nic_agent.SriovNicSwitchRpcCallbacks(
|
|
self.context, self.agent, sg_agent)
|
|
|
|
def _create_fake_port(self):
|
|
return {'id': uuidutils.generate_uuid(),
|
|
portbindings.PROFILE: {'pci_slot': PCI_SLOT},
|
|
'mac_address': DEVICE_MAC}
|
|
|
|
def test_port_update_with_pci_slot(self):
|
|
port = self._create_fake_port()
|
|
kwargs = {'context': self.context, 'port': port}
|
|
self.sriov_rpc_callback.port_update(**kwargs)
|
|
self.assertEqual(set([(DEVICE_MAC, PCI_SLOT)]),
|
|
self.agent.updated_devices)
|
|
|
|
def test_port_update_with_vnic_physical_direct(self):
|
|
port = self._create_fake_port()
|
|
port[portbindings.VNIC_TYPE] = portbindings.VNIC_DIRECT_PHYSICAL
|
|
kwargs = {'context': self.context, 'port': port}
|
|
self.sriov_rpc_callback.port_update(**kwargs)
|
|
self.assertEqual(set(), self.agent.updated_devices)
|
|
|
|
def test_port_update_without_pci_slot(self):
|
|
port = self._create_fake_port()
|
|
port[portbindings.PROFILE] = None
|
|
kwargs = {'context': self.context, 'port': port}
|
|
self.sriov_rpc_callback.port_update(**kwargs)
|
|
self.assertEqual(set(), self.agent.updated_devices)
|
|
|
|
def test_network_update(self):
|
|
TEST_NETWORK_ID1 = "n1"
|
|
TEST_NETWORK_ID2 = "n2"
|
|
TEST_PORT_ID1 = 'p1'
|
|
TEST_PORT_ID2 = 'p2'
|
|
network1 = {'id': TEST_NETWORK_ID1}
|
|
port1 = {'id': TEST_PORT_ID1, 'network_id': TEST_NETWORK_ID1}
|
|
port2 = {'id': TEST_PORT_ID2, 'network_id': TEST_NETWORK_ID2}
|
|
self.agent.network_ports = {
|
|
TEST_NETWORK_ID1: [{'port_id': port1['id'],
|
|
'device': ('mac1', 'slot1')}],
|
|
TEST_NETWORK_ID2: [{'port_id': port2['id'],
|
|
'device': ('mac2', 'slot2')}]}
|
|
kwargs = {'context': self.context, 'network': network1}
|
|
self.sriov_rpc_callback.network_update(**kwargs)
|
|
self.assertEqual(set([('mac1', 'slot1')]), self.agent.updated_devices)
|
|
|
|
|
|
class TestSRIOVAgentExtensionConfig(base.BaseTestCase):
|
|
def setUp(self):
|
|
super(TestSRIOVAgentExtensionConfig, self).setUp()
|
|
l2_ext_manager.register_opts(cfg.CONF)
|
|
# disable setting up periodic state reporting
|
|
cfg.CONF.set_override('report_interval', 0, group='AGENT')
|
|
cfg.CONF.set_override('extensions', ['qos'], group='agent')
|
|
|
|
@mock.patch("neutron.plugins.ml2.drivers.mech_sriov.agent.eswitch_manager"
|
|
".ESwitchManager.get_assigned_devices_info", return_value=[])
|
|
def test_report_loaded_extension(self, *args):
|
|
with mock.patch.object(agent_rpc.PluginReportStateAPI,
|
|
'report_state') as mock_report_state:
|
|
agent = sriov_nic_agent.SriovNicSwitchAgent({}, {}, 0)
|
|
agent._report_state()
|
|
mock_report_state.assert_called_with(
|
|
agent.context, agent.agent_state)
|
|
self.assertEqual(
|
|
['qos'], agent.agent_state['configurations']['extensions'])
|