openstack
/
nova
Code Issues Proposed changes

Fix nova-manage image_property show unexpected keyword 

Reproduction steps:
1. Execute: nova-manage image_property show <vm_uuid> \
                            hw_vif_multiqueue_enabled
2. Observe:
  An error has occurred:
  Traceback (most recent call last):
    File "/var/lib/kolla/venv/lib/python3.9/
          site-packages/nova/cmd/manage.py", line 3394, in main
      ret = fn(*fn_args, **fn_kwargs)
  TypeError: show() got an unexpected keyword argument 'property'

Change-Id: I1349b880934ad9f44a943cf7de324d7338619d2e
Closes-Bug: #2016346
This commit is contained in:
Robert Breker 2023-04-14 23:24:02 +01:00 committed by Pavlo Shchelokovskyy
parent a5245da25c
commit 1c02c0da17
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nova/cmd/manage.py
View File

@ -3195,7 +3195,7 @@ class ImagePropertyCommands:
'instance_uuid', metavar='<instance_uuid>',
help='UUID of the instance')
@args(
'property', metavar='<image_property>',
'image_property', metavar='<image_property>',
help='Image property to show')
def show(self, instance_uuid=None, image_property=None):
"""Show value of a given instance image property.
@ -3213,10 +3213,10 @@ class ImagePropertyCommands:
with context.target_cell(ctxt, im.cell_mapping) as cctxt:
instance = objects.Instance.get_by_uuid(
cctxt, instance_uuid, expected_attrs=['system_metadata'])
image_property = instance.system_metadata.get(
property_value = instance.system_metadata.get(
f'image_{image_property}')
if image_property:
print(image_property)
if property_value:
print(property_value)
return 0
else:
print(f'Image property {image_property} not found '