From 7604179d1d00c3d4c7d08273fea78ac0d4ae25c9 Mon Sep 17 00:00:00 2001 From: Sean Dague Date: Fri, 16 Jan 2015 14:24:29 -0500 Subject: [PATCH] work around for until-failure testr run --until-failure --subunit does not actually fail when a test fails, upstream bug filed at https://bugs.launchpad.net/testrepository/+bug/1411804 Work around this by reverting to old style version when running in --until-failure mode. Change-Id: Ic2b26c423e4e6c729bb1357bc901fdf1afdb083f --- tools/pretty_tox.sh | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/pretty_tox.sh b/tools/pretty_tox.sh index ac7604586aeb..799ac1848755 100755 --- a/tools/pretty_tox.sh +++ b/tools/pretty_tox.sh @@ -3,4 +3,14 @@ set -o pipefail TESTRARGS=$1 -python setup.py testr --slowest --testr-args="--subunit $TESTRARGS" | subunit-trace -f + +# --until-failure is not compatible with --subunit see: +# +# https://bugs.launchpad.net/testrepository/+bug/1411804 +# +# this work around exists until that is addressed +if [[ "$TESTARGS" =~ "until-failure" ]]; then + python setup.py testr --slowest --testr-args="$TESTRARGS" +else + python setup.py testr --slowest --testr-args="--subunit $TESTRARGS" | subunit-trace -f +fi