openstack
/
nova
Code Issues Proposed changes

TrivialFix: removed unnecessary cycle in servicegroup/test_api.py 

This test has unnecessary cycle and two unused variables.
Test was refactored.

Change-Id: I2b51ccbc2bb84a918e6adb7b294f73ae89d2297e
This commit is contained in:
Sergey Nikitin 2016-03-29 15:10:43 +03:00 committed by Daniel Berrange
parent d57a4e8be9
commit fb22f71c41
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nova/tests/unit/servicegroup/test_api.py
View File

@ -55,7 +55,8 @@ class ServiceGroupApiTestCase(test.NoDBTestCase):
driver.is_up.assert_called_with(member)
member["forced_down"] = True
for retval in (True, False):
driver = self.servicegroup_api._driver
result = self.servicegroup_api.service_is_up(member)
self.assertIs(result, False)
driver = self.servicegroup_api._driver
driver.is_up = mock.MagicMock()
result = self.servicegroup_api.service_is_up(member)
self.assertIs(result, False)
driver.is_up.assert_not_called()