openstack
/
nova
Code Issues Proposed changes
nova/nova/tests/unit/virt
History
Matthew Booth c9c0b1b4b5 Fix backing file detection in libvirt live snapshot 
When doing a live snapshot, the libvirt driver creates an intermediate
qcow2 file with the same backing file as the original disk. However,
it calls qemu-img info without specifying the input format explicitly.
An authenticated user can write data to a raw disk which will cause
this code to misinterpret the disk as a qcow2 file with a
user-specified backing file on the host, and return an arbitrary host
file as the backing file.

This bug does not appear to result in a data leak in this case, but
this is hard to verify. It certainly results in corrupt output.

Closes-Bug: #1524274

(cherry picked from commit 915fdbbfb8)

Conflicts:
    nova/virt/images.py

Liberty does not catch processutils.ProcessExecutionError in
qemu_img_info.

Change-Id: I11485f077d28f4e97529a691e55e3e3c0bea8872
 		2016-01-14 11:57:31 +00:00
..
disk nova.utils._get_root_helper() should be public 2015-08-19 04:00:50 +00:00
hyperv Merge "Hyper-V: Implements attach_interface and detach_interface method" 2015-09-22 02:22:14 +00:00
image virt: introduce model for describing local image metadata 2015-06-04 13:46:59 +01:00
ironic Ironic: Fix bad capacity reporting if instance_info is unset 2015-10-05 20:55:50 +00:00
libvirt Fix backing file detection in libvirt live snapshot 2016-01-14 11:57:31 +00:00
vmwareapi VMware: fix bug for config drive when inventory folder is used 2015-12-19 09:55:41 +00:00
xenapi xen: mask passwords in volume connection_data dict 2015-11-19 22:51:38 +00:00
__init__.py
…
test_block_device.py Merge "Detach and terminate conn if Cinder attach fails" 2015-09-18 17:15:24 +00:00
test_configdrive.py objects: convert config drive to use ImageMeta object 2015-09-07 17:11:02 +01:00
test_diagnostics.py
…
test_driver.py
…
test_events.py
…
test_fake.py fake: fix public API signatures to match virt driver 2015-02-19 11:44:00 +00:00
test_hardware.py Merge "Prevent (un)pinning unknown CPUs" 2015-08-11 15:17:19 +00:00
test_imagecache.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_images.py Enable W292 2015-01-10 21:45:08 +00:00
test_virt.py virt: convert disk mount API to use nova.virt.image.model 2015-06-04 13:47:40 +01:00
test_virt_drivers.py libvirt: enhance libvirt to set admin password 2015-08-04 08:37:46 -04:00
test_volumeutils.py Switch to using os-brick 2015-07-27 10:47:22 -07:00