nova/nova/tests/unit
Dan Smith 4cbfcc590c Refined fix for validating image on rebuild
This aims to fix the issue described in bug 1664931 where a rebuild
fails to validate the existing host with the scheduler when a new
image is provided. The previous attempt to do this could cause rebuilds
to fail unnecessarily because we ran _all_ of the filters during a
rebuild, which could cause usage/resource filters to prevent an otherwise
valid rebuild from succeeding.

This aims to classify filters as useful for rebuild or not, and only apply
the former during a rebuild scheduler check. We do this by using an internal
scheduler hint, indicating our intent. This should (a) filter out
all hosts other than the one we're running on and (b) be detectable by
the filtering infrastructure as an internally-generated scheduling request
in order to trigger the correct filtering behavior.

Conflicts:
      nova/scheduler/utils.py
      nova/tests/unit/compute/test_compute_api.py

NOTE(mriedem): The conflicts are due to not having
7d0381c91a or
4a7502a5c9 in Newton.

Closes-Bug: #1664931
Change-Id: I1a46ef1503be2febcd20f4594f44344d05525446
(cherry picked from commit f7c688b8ef)
(cherry picked from commit b29a461a8b)
(cherry picked from commit bbfc4230ef)
2017-11-28 09:58:20 -05:00
..
api Catch InstanceNotFound exception 2017-10-17 14:35:35 -04:00
api_samples_test_base Fix invalid import order 2016-07-04 16:03:42 +05:30
cells Remove straggling use of main db flavors in cellsv1 code 2017-02-14 15:44:14 -05:00
cert
cmd Merge "Adds nova-policy-check cmd" 2016-09-01 17:56:56 +00:00
compute Refined fix for validating image on rebuild 2017-11-28 09:58:20 -05:00
conductor Validate new image via scheduler during rebuild 2017-11-16 14:00:46 +11:00
console Merge "Remove invalid test methods for config option port_range" 2016-07-09 03:58:23 +00:00
consoleauth Avoid unconditional warnings in nova-consoleauth 2016-04-26 23:52:49 +02:00
db Exclude deleted service records when calling hypervisor statistics 2017-06-08 12:12:28 +00:00
fake_loadables
image Determine disk_format for volume-backed snapshot from schema 2016-09-26 14:07:20 -04:00
keymgr Fix spelling mistake 2016-05-13 08:23:18 -07:00
monkey_patch_example
network neutron: handle binding:profile=None during migration 2017-09-21 13:48:39 -04:00
notifications Removed enum duplication from nova.compute 2016-09-02 07:30:44 +00:00
objects Pass requested_destination in filter_properties 2017-11-16 14:00:41 +11:00
pci Fix crashing during guest config with pci_devices=None 2016-12-12 15:07:18 +00:00
scheduler Merge "Fresh resource provider in RT must have generation 0" into stable/newton 2017-03-07 12:44:33 +00:00
servicegroup Remove deprecated "memcached_server" in Default section 2016-05-13 00:58:10 +00:00
ssl_cert
virt libvirt: Don't disregard cache mode for instance boot disks 2017-10-26 22:47:20 +00:00
volume encryptors: Workaround mangled passphrases 2016-11-10 15:31:07 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Fix unit test after the replace of key manager 2016-05-25 14:57:43 +01:00
fake_block_device.py
fake_build_request.py Create Instance from BuildRequest if not in a cell 2016-08-22 16:52:53 -04:00
fake_console_auth_token.py Add console auth tokens db api methods 2016-06-23 11:24:38 +01:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py objects: Add devices_metadata to instance object 2016-06-24 04:30:51 -04:00
fake_ldap.py
fake_network.py Remove DictCompat from instance_info_cache 2016-06-13 18:31:45 +00:00
fake_network_cache_model.py
fake_notifier.py Stop using mox stubs in tests/unit/fake_notifier 2016-06-10 11:27:09 +02:00
fake_pci_device_pools.py
fake_policy.py policy: clean-up 2016-06-30 19:56:14 +00:00
fake_processutils.py Trivial-Fix: Fix typos 2016-06-13 06:41:08 +00:00
fake_request_spec.py Add requested_destination field to RequestSpec 2016-05-27 10:14:51 +02:00
fake_server_actions.py Stop using mox from unit/fake_server_actions.py 2016-06-21 09:09:59 +07:00
fake_utils.py
fake_volume.py
image_fixtures.py
matchers.py tests: make XMLMatches work with Python3 2016-06-07 15:23:53 +01:00
policy_fixture.py policy: Add defaults in code (part 1) 2016-06-23 19:53:29 +03:00
test_api_validation.py Fix api_validation for Python 3 2016-07-01 11:04:15 +02:00
test_availability_zones.py
test_baserpc.py Move config options from nova/compute/rpcapi.py file 2016-04-21 22:26:13 +00:00
test_block_device.py Merge "Fixes py3 unit tests for nova.tests.unit.test_block_device.*" 2016-06-10 15:04:39 +00:00
test_cache.py Remove deprecated "memcached_server" in Default section 2016-05-13 00:58:10 +00:00
test_cinder.py
test_conf.py Add the ability to configure glanceclient debug logging 2016-08-04 00:32:37 +00:00
test_configdrive2.py
test_context.py Cache database and message queue connection objects 2017-05-19 22:24:21 +00:00
test_crypto.py Drop paramiko < 2 compat code 2016-05-10 12:01:22 -05:00
test_exception.py do not include context to exception notification 2017-03-17 13:06:25 -04:00
test_fixtures.py Use StableObjectJsonFixture from o.vo 2016-08-29 11:52:10 -04:00
test_flavors.py Return 400 HTTP error for invalid flavor attributes 2016-05-26 09:49:39 +05:30
test_hacking.py Remove hacking check [N347] for config options. 2016-08-11 14:23:21 +02:00
test_hash_ring.py Ironic: allow multiple compute services 2016-08-04 23:51:13 +00:00
test_hooks.py Stop using mox stubs in nova/tests/unit 2016-06-10 06:55:57 +09:00
test_instance_types_extra_specs.py
test_iptables_network.py Merge "Remove mox from nova/tests/unit/test_iptables_network.py" 2016-06-09 10:23:05 +00:00
test_ipv6.py Fix test_ipv6 and simplify to_global() 2016-06-28 20:42:32 +02:00
test_loadables.py
test_matchers.py Fix invalid import order 2016-07-04 16:14:20 +05:30
test_metadata.py Merge "Add more vd2 unit tests" 2016-08-30 21:14:30 +00:00
test_notifications.py Make notifications module use flavor capacity attributes 2016-07-12 11:52:07 -07:00
test_notifier.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_nova_manage.py Fix cell0 naming when QS params on the connection 2017-06-07 16:27:19 +02:00
test_pipelib.py conf: Move cloudpipe options to a group 2016-08-22 09:31:03 +01:00
test_policy.py Emit warning when use 'user_id' in policy rule 2016-08-29 11:46:15 +00:00
test_quota.py Quota changes for the nova-manage quota_usage_refresh command 2016-07-06 22:21:39 +00:00
test_rpc.py Move cell message queue switching and add caching 2016-08-31 22:33:17 +00:00
test_safeutils.py
test_service.py Fix use of invalid assert calls 2016-05-19 13:12:15 +01:00
test_signature_utils.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_test.py Remove mox from unit/compute/test_compute.py (8) 2016-06-28 02:49:25 +00:00
test_test_utils.py
test_utils.py Merge "Properly quote IPv6 address in RsyncDriver" 2016-08-18 13:17:19 +00:00
test_uuid_sentinels.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_versions.py
test_weights.py
test_wsgi.py
utils.py Add a test utility for checking mock calls with objects 2016-06-29 07:22:22 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎