nova/nova/tests/unit
Lee Yarwood 53c3cfa7a0 Use migration_status during volume migrating and retyping
When swapping volumes Nova has to identify if the swap itself is related
to an underlying migration or retype of the volume by Cinder.  Nova
would previously use the status of the volume to determine if the volume
was retyping or migrating.

However in the migration case where a volume is moved directly between
hosts the volume is never given a status  of migrating by Cinder leading
to Nova never calling the os-migrate_volume_completion cinder API to
complete the migration.

This change switches Nova to use the migration_status of the volume to
ensure that this API is called for both retypes and migrations.

Depends-On: https://review.openstack.org/#/c/639331/
Change-Id: I1bdf3431bda2da98380e0dcaa9f952e6768ca3af
Closes-bug: #1803961
2019-04-09 14:21:17 +01:00
..
api Merge "Remove flavor id and name validation code" 2019-04-03 06:39:46 +00:00
cells Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
cmd Remove "API Service Version" upgrade check 2018-12-19 20:41:04 -05:00
compute Use migration_status during volume migrating and retyping 2019-04-09 14:21:17 +01:00
conductor Do not persist RequestSpec.ignore_hosts 2019-04-01 15:01:29 +00:00
conf Assorted cleanups from numa-aware-vswitches series 2018-07-27 09:49:12 -07:00
console Move create of ComputeAPI object in websocketproxy 2019-03-27 21:45:52 +00:00
consoleauth Fix stacktraces with redis caching backend 2018-09-27 13:15:11 -04:00
db Add placeholder migrations for Stein backports 2019-04-08 18:08:40 +01:00
fake_loadables
image Share snapshot image membership with instance owner 2019-02-08 18:06:27 -05:00
keymgr
network Merge "Remove mox in unit/network/test_neutronv2.py (7)" 2019-04-09 03:22:08 +00:00
notifications Remove CellMappingPayload database_connection and transport_url fields 2019-04-04 09:59:12 -04:00
objects Do not persist RequestSpec.ignore_hosts 2019-04-01 15:01:29 +00:00
pci Add get_instance_pci_request_from_vif 2019-03-07 11:37:53 +02:00
privsep Improve test coverage of nova.privsep.fs, continued. 2019-04-04 20:42:43 +00:00
scheduler Merge "Fix bug preventing forbidden traits from working" 2019-04-03 00:16:50 +00:00
servicegroup Fix deprecation warning for threadgroup.add_timer 2019-02-07 09:37:00 -05:00
ssl_cert
virt Merge "trivial: Remove unused constants, functions" 2019-04-08 18:13:37 +00:00
volume Add compute API validation for when a volume_type is requested 2018-10-11 16:04:53 -04:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py libvirt: Start populating NUMACell.network_metadata field 2018-07-24 15:33:49 +01:00
fake_block_device.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_build_request.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_console_auth_token.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add trusted_certs object 2018-03-29 23:00:48 -04:00
fake_ldap.py
fake_network.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_network_cache_model.py
fake_notifier.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
fake_pci_device_pools.py
fake_policy.py Remove deprecated 'os-server-groups' policy 2019-02-22 00:31:02 +00:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-02-26 09:26:52 +09:00
fake_requests.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_xvp_console_proxy.py
image_fixtures.py Merge image_size extension response into image view builder 2018-10-18 01:59:34 +00:00
matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
policy_fixture.py Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
test_api_validation.py Add python 3.7 unit and functional tox jobs 2018-12-13 10:41:46 -05:00
test_availability_zones.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_baserpc.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_block_device.py Add method to generate device names universally 2019-01-15 18:55:11 +00:00
test_cache.py
test_cinder.py Make [cinder]/catalog_info no longer require a service_name 2018-11-28 18:33:30 -05:00
test_conf.py Configure placement DB context manager for nova-manage/status 2018-09-05 10:29:48 -04:00
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Remove NovaException logging from scatter_gather_cells 2018-11-21 12:43:35 -05:00
test_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
test_exception.py Convert exception messages to strings 2018-11-05 14:21:02 +02:00
test_fake_notifier.py Raise error on timeout in wait_for_versioned_notifications 2018-09-29 00:29:49 +01:00
test_fixtures.py Add context.target_cell() stub to DownCellFixture 2019-02-15 14:39:20 -05:00
test_flavors.py Remove flavor id and name validation code 2019-04-01 14:22:56 +08:00
test_hacking.py Hacking N362: Don't abbrev/alias privsep import 2019-04-04 20:42:43 +00:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Transform instance.exists notification 2018-06-05 12:51:30 +00:00
test_loadables.py
test_matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
test_metadata.py Allow run metadata api per cell 2019-01-14 10:20:50 -05:00
test_notifications.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_notifier.py
test_nova_manage.py Don't report 'exiting' when mapping cells 2019-04-05 23:22:59 +00:00
test_policy.py Correct lower-constraints.txt and the related tox job 2019-04-01 19:16:33 +00:00
test_profiler.py
test_quota.py Merge "quota: remove defaults kwarg in get_project_quotas" 2019-02-26 13:26:24 +00:00
test_rpc.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 12:50:10 -07:00
test_service_auth.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_test.py
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Switch to using os-resource-classes 2019-02-07 11:11:09 +00:00
test_versions.py
test_weights.py Per aggregate scheduling weight 2019-01-21 11:48:44 +08:00
test_wsgi.py Refactor WSGI apps and utils to limit imports 2018-03-06 22:05:12 +00:00
utils.py Transform missing delete notifications 2018-08-29 13:39:57 +02:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎