nova/nova/tests/unit
Gábor Antal 6c8d882e8c Fixed invalid UUIDs in unit tests
Many places in tests, wrong fake UUID is used, which
pollutes the test log with the deprecation warnings.
In this patchset, I fixed them in the unit tests.

Change-Id: Ifd6a8bfa05a84d1d540e4382e9561c590b731044
Partial-Bug: #1606647
2016-08-02 17:10:12 +00:00
..
api Merge "API: catch InstanceNotReady exception." 2016-07-27 14:30:25 +00:00
api_samples_test_base Fix invalid import order 2016-07-04 16:03:42 +05:30
cells Merge "Fix invalid import order" 2016-07-08 19:20:12 +00:00
cert
cmd Merge "Add test for nova-compute and nova-network main database blocks" 2016-07-26 13:19:27 +00:00
compute Fixed invalid UUIDs in unit tests 2016-08-02 17:10:12 +00:00
conductor Merge "raise exception ComputeHostNotFound if host is not found" 2016-07-26 13:17:37 +00:00
console Merge "Remove invalid test methods for config option port_range" 2016-07-09 03:58:23 +00:00
consoleauth Avoid unconditional warnings in nova-consoleauth 2016-04-26 23:52:49 +02:00
db Add VirtualInterface.destroy() 2016-07-12 14:53:48 -07:00
fake_loadables
image Merge "Fix invalid import order" 2016-07-08 19:20:12 +00:00
keymgr Config options: remove import_opts from completed section 2016-05-13 15:57:32 +07:00
monkey_patch_example
network Fixed invalid UUIDs in unit tests 2016-08-02 17:10:12 +00:00
notifications Transform instance.update notification 2016-06-30 16:54:57 +02:00
objects Merge "Make Aggregate host operations work against API db" 2016-07-25 21:36:43 +00:00
pci Fix invalid import order 2016-07-04 16:14:20 +05:30
scheduler Fixed invalid UUIDs in unit tests 2016-08-02 17:10:12 +00:00
servicegroup Remove deprecated "memcached_server" in Default section 2016-05-13 00:58:10 +00:00
ssl_cert
virt Fixed invalid UUIDs in unit tests 2016-08-02 17:10:12 +00:00
volume Don't check cinder volume states during attach 2016-07-22 16:31:49 -04:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Fix unit test after the replace of key manager 2016-05-25 14:57:43 +01:00
fake_block_device.py
fake_build_request.py Add block_device_mappings to BuildRequest 2016-07-12 13:35:09 -04:00
fake_console_auth_token.py Add console auth tokens db api methods 2016-06-23 11:24:38 +01:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py objects: Add devices_metadata to instance object 2016-06-24 04:30:51 -04:00
fake_ldap.py
fake_network.py Remove DictCompat from instance_info_cache 2016-06-13 18:31:45 +00:00
fake_network_cache_model.py
fake_notifier.py Stop using mox stubs in tests/unit/fake_notifier 2016-06-10 11:27:09 +02:00
fake_pci_device_pools.py
fake_policy.py policy: clean-up 2016-06-30 19:56:14 +00:00
fake_processutils.py Trivial-Fix: Fix typos 2016-06-13 06:41:08 +00:00
fake_request_spec.py Add requested_destination field to RequestSpec 2016-05-27 10:14:51 +02:00
fake_server_actions.py Stop using mox from unit/fake_server_actions.py 2016-06-21 09:09:59 +07:00
fake_utils.py
fake_volume.py config options: centralize cinder options 2016-03-15 21:17:38 -04:00
image_fixtures.py
matchers.py tests: make XMLMatches work with Python3 2016-06-07 15:23:53 +01:00
policy_fixture.py policy: Add defaults in code (part 1) 2016-06-23 19:53:29 +03:00
test_api_validation.py Fix api_validation for Python 3 2016-07-01 11:04:15 +02:00
test_availability_zones.py Config options: centralize options in availability_zones 2016-01-27 17:32:04 +00:00
test_baserpc.py Move config options from nova/compute/rpcapi.py file 2016-04-21 22:26:13 +00:00
test_block_device.py Merge "Fixes py3 unit tests for nova.tests.unit.test_block_device.*" 2016-06-10 15:04:39 +00:00
test_cache.py Remove deprecated "memcached_server" in Default section 2016-05-13 00:58:10 +00:00
test_cinder.py config options: centralize cinder options 2016-03-15 21:17:38 -04:00
test_conf.py Fix nova-compute start failed when reserved_huge_pages has value. 2016-06-07 07:51:46 -04:00
test_configdrive2.py
test_context.py Don't assert exact to_dict output 2016-07-22 09:28:06 +10:00
test_crypto.py Drop paramiko < 2 compat code 2016-05-10 12:01:22 -05:00
test_exception.py Transform wrap_exception notification to versioned format 2016-06-21 09:39:47 +02:00
test_fixtures.py Add AllServicesCurrent fixture 2016-04-12 11:11:15 -07:00
test_flavors.py Return 400 HTTP error for invalid flavor attributes 2016-05-26 09:49:39 +05:30
test_hacking.py Replace deprecated LOG.warn with LOG.warning 2016-07-20 14:39:15 +05:30
test_hooks.py Stop using mox stubs in nova/tests/unit 2016-06-10 06:55:57 +09:00
test_instance_types_extra_specs.py Objectify test_instance_type_extra_specs 2016-03-23 06:55:10 -07:00
test_iptables_network.py Merge "Remove mox from nova/tests/unit/test_iptables_network.py" 2016-06-09 10:23:05 +00:00
test_ipv6.py Fix test_ipv6 and simplify to_global() 2016-06-28 20:42:32 +02:00
test_loadables.py
test_matchers.py Fix invalid import order 2016-07-04 16:14:20 +05:30
test_metadata.py New style vendordata support. 2016-07-26 08:15:25 -04:00
test_notifications.py Make notifications module use flavor capacity attributes 2016-07-12 11:52:07 -07:00
test_notifier.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_nova_manage.py Merge "Add nova-manage quota_usage_refresh command" 2016-07-10 06:12:38 +00:00
test_pipelib.py Stop using mox stubs in test_pipelib.py 2016-05-23 03:50:08 +00:00
test_policy.py policy: clean-up 2016-06-30 19:56:14 +00:00
test_quota.py Quota changes for the nova-manage quota_usage_refresh command 2016-07-06 22:21:39 +00:00
test_rpc.py Add message queue switching through RequestContext 2016-05-16 15:34:35 +00:00
test_safeutils.py
test_service.py Fix use of invalid assert calls 2016-05-19 13:12:15 +01:00
test_signature_utils.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_test.py Remove mox from unit/compute/test_compute.py (8) 2016-06-28 02:49:25 +00:00
test_test_utils.py
test_utils.py Merge "Use oslo_log instead of logging" 2016-07-22 02:17:35 +00:00
test_uuid_sentinels.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_versions.py
test_weights.py
test_wsgi.py config options: Remove 'wsgi_' prefix from opts 2016-03-25 13:19:19 +00:00
utils.py Add a test utility for checking mock calls with objects 2016-06-29 07:22:22 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎