nova/nova/tests/unit
yunhong jiang 79a0755597 libvirt: fix overly strict CPU model comparison in live migration
The current libvirt driver migration code checks whether the
dest host can support the guest, by comparing the source host
CPU model. This is overly strict, as the guest may well be
running with a more restrictive CPU model that hides many
host features.  The correct approach is to compare against
the guest's configured CPU model.

To achieve the compatibility when migrate instance from old compute
node which does not provide vcpu_model in instance object, the source
host's compute info is still provided.

Co-authored: Daniel P. Berrange <berrange@redhat.com>
Co-authored: Yunhong Jiang <yunhong.jiang@intel.com>

Closes-Bug: 1082414

Change-Id: I65f505fec64c65d2641d2bfd940cde44bcd83a78
2015-02-13 09:23:07 -08:00
..
api Merge "Fix network tests response code checking" 2015-02-13 06:15:30 +00:00
cells Merge "Cells: Improve invalid hostname handling" 2015-02-10 23:41:58 +00:00
cert Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
cmd Added hacking rule for assertTrue/False(A in B) 2015-01-07 12:25:53 +03:00
compute Merge "Remove unused migration parameter from _cleanup_stored_instance_types" 2015-02-13 14:32:55 +00:00
conductor Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
console Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
consoleauth Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
db Add vcpu_model to instance object 2015-02-12 22:22:24 -08:00
fake_loadables
functional
image Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
keymgr Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
monkey_patch_example Enable check for H238 rule 2015-01-20 18:05:47 +03:00
network Merge "Fixes interfaces template identification issue" 2015-02-13 13:08:54 +00:00
objects Merge "Add vcpu_model to instance object" 2015-02-13 15:29:56 +00:00
pci Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
scheduler objects: remove default values for numa cell 2015-02-12 05:07:27 -05:00
servicegroup Merge "Fix conductor servicegroup joining when zk driver is used" 2015-02-06 18:37:37 +00:00
ssl_cert Update WSGI SSL IPv6 test and SSL certificates 2015-01-07 23:10:00 -06:00
virt libvirt: fix overly strict CPU model comparison in live migration 2015-02-13 09:23:07 -08:00
volume Add log message to is_luks function 2015-01-30 20:03:41 -05:00
README.rst
__init__.py move eventlet GREENDNS override to top level 2014-12-08 17:41:03 -05:00
cast_as_call.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
conf_fixture.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_block_device.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_crypto.py
fake_hosts.py
fake_instance.py Add vcpu_model to instance object 2015-02-12 22:22:24 -08:00
fake_ldap.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_network.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_network_cache_model.py Add ipv6 support to fake network models 2014-12-23 17:11:14 -08:00
fake_notifier.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
fake_pci_device_pools.py Add pci_device_pools to ComputeNode object 2014-12-17 14:34:44 +00:00
fake_policy.py Remove duplicated policy check at nova-network FlatManager 2015-01-06 16:50:28 +08:00
fake_processutils.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
fake_server_actions.py
fake_utils.py
fake_volume.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
image_fixtures.py
matchers.py Fix errors in string formatting operations 2015-01-21 22:41:28 -05:00
policy_fixture.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_api_validation.py Expand valid resource name character set 2014-12-18 06:51:14 -06:00
test_availability_zones.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_baserpc.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_bdm.py
test_block_device.py Merge "libvirt: fix failure when attaching volume to iso instance" 2015-02-02 22:27:24 +00:00
test_cinder.py Use session in cinderclient 2014-11-18 09:46:25 +10:00
test_configdrive2.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_context.py Prevent admin role leak in context.elevated 2014-11-24 22:58:05 +00:00
test_crypto.py rename oslo.concurrency to oslo_concurrency 2014-12-06 23:30:05 +08:00
test_exception.py
test_fixtures.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_flavors.py Expand valid resource name character set 2014-12-18 06:51:14 -06:00
test_hacking.py Merge "Treat LOG.warning and LOG.warn same" 2015-02-06 20:44:57 +00:00
test_hooks.py Fix improper use of Stevedore 2015-02-05 09:15:45 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py Added hacking rule for assertTrue/False(A in B) 2015-01-07 12:25:53 +03:00
test_ipv6.py
test_linuxscsi.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_loadables.py
test_matchers.py Expansion of matching XML strings logic 2015-01-15 17:04:10 +00:00
test_metadata.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_notifications.py Merge "Ensure publisher_id is set correctly in notifications" 2015-02-10 04:50:54 +00:00
test_nova_manage.py Add tests for nova-manage vm list 2015-02-11 12:08:09 -08:00
test_objectstore.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_pipelib.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_policy.py Performance: leverage dict comprehension in PEP-0274 2015-01-16 10:06:13 +08:00
test_quota.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_safeutils.py
test_service.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_test.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_test_utils.py
test_utils.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_versions.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
test_weights.py
test_wsgi.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
utils.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎