nova/nova/tests/unit
Matt Riedemann 82ecd93a20 libvirt: log vm and task state when vif plugging times out
This enhances the warning we log when we timeout waiting
for the network-vif-plugged event from Neutron. It includes
the vm_state and task_state for context on the instance operation
since this is done for more than just the initial create, it's
also for things like rebuild.

The explicit instance uuid is also removed from the message since
sending the instance kwarg to LOG.warning logs the instance uuid
automatically. And _LW is also dropped since we no longer translate
log messages.

Change-Id: I6daf1569cba2cfcb4e8da0b46c91d5251c9c6740
Related-Bug: #1694371
2017-06-06 15:52:50 -04:00
..
api Merge "Standardization of VM diagnostics info API." 2017-06-06 02:52:32 +00:00
api_samples_test_base
cells Merge "Remove mox from cells/test_cells_rpc_driver.py" 2017-06-06 14:54:53 +00:00
cmd Remove all discoverable policy rules 2017-04-26 15:31:37 +01:00
compute Merge "Remove usage of parameter enforce_type" 2017-06-06 16:54:43 +00:00
conductor Pass a list of instance UUIDs to scheduler 2017-06-01 14:54:16 +00:00
console Fix novncproxy for python3 2017-02-16 10:04:33 +01:00
consoleauth Remove mox from nova/tests/unit/consoleauth/test_consoleauth.py 2017-03-30 05:37:27 +00:00
db Merge "Fix a typo in code comment" 2017-05-26 19:05:47 +00:00
fake_loadables
image Send request_id on glance calls 2017-06-05 10:15:20 -04:00
keymgr
monkey_patch_example
network Handle conflict from neutron when addFloatingIP fails 2017-05-25 15:11:01 -04:00
notifications Merge "Don't lazy-load flavor.projects during destroy()" 2017-06-03 01:10:58 +00:00
objects Merge "Support tag instances when boot(2/4)" 2017-06-06 16:51:36 +00:00
pci Modify PciPassthroughFilter to accept lists 2017-04-11 19:49:07 +00:00
scheduler Merge "Pass a list of instance UUIDs to scheduler" 2017-06-06 16:55:22 +00:00
servicegroup Fix the display of updated_at time when using memcache driver. 2017-05-26 16:48:07 +08:00
ssl_cert
virt libvirt: log vm and task state when vif plugging times out 2017-06-06 15:52:50 -04:00
volume Merge "cinder: add attachment_update method" 2017-05-30 15:04:32 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Block starting compute unless placement conf is provided 2017-01-27 16:35:09 -08:00
fake_block_device.py objects: Add attachment_id to BlockDeviceMapping 2017-03-16 16:35:01 -04:00
fake_build_request.py Support tag instances when boot(2/4) 2017-06-06 06:16:41 +00:00
fake_console_auth_token.py
fake_crypto.py
fake_diagnostics.py Added nova objects for intance diagnostics 2017-05-30 00:39:44 +04:00
fake_flavor.py
fake_hosts.py
fake_instance.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:20 +05:30
fake_ldap.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
fake_network.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
fake_network_cache_model.py
fake_notifier.py Short circuit notifications when not enabled 2017-03-30 22:32:14 +00:00
fake_pci_device_pools.py
fake_policy.py Remove cloudpipe APIs 2017-05-04 16:13:45 +08:00
fake_processutils.py
fake_request_spec.py Image meta min_disk should be int in fake_request_spec 2017-04-06 23:12:46 -04:00
fake_server_actions.py
fake_volume.py Remove check_attach 2017-02-26 20:34:05 -05:00
fake_xvp_console_proxy.py tests: Replace use of CONF with monkey patching 2017-01-06 14:54:47 +00:00
image_fixtures.py
matchers.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
policy_fixture.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
test_api_validation.py Correct the error message for query parameter validation 2017-05-19 00:37:09 +08:00
test_availability_zones.py Avoid lazy-load error when getting instance AZ 2017-05-25 15:46:22 -04:00
test_baserpc.py conf: Remove deprecated service manager opts 2016-12-05 23:28:49 +08:00
test_block_device.py Remove unused validation code from block_device 2017-02-09 11:54:40 -08:00
test_cache.py Do not rely on dogpile internals for mocks 2017-05-30 11:57:54 +00:00
test_cinder.py Fix ksa mocking in test_cinderclient_unsupported_v1 2017-01-05 19:52:10 -05:00
test_conf.py conf: Remove 'virt' file 2016-12-21 16:45:08 +00:00
test_configdrive2.py Merge "Remove mox from nova/tests/unit/test_configdrive2.py" 2017-03-07 18:55:47 +00:00
test_context.py Have nova.context use super from_context 2017-05-25 10:37:26 -04:00
test_crypto.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:20 +05:30
test_exception.py Make NovaException format errors fatal for tests 2017-05-05 14:45:03 +00:00
test_fixtures.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_flavors.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_hacking.py remove hacking rule that enforces log translation 2017-03-16 09:56:21 -04:00
test_hooks.py
test_identity.py Be more tolerant of keystone catalog configuration 2017-06-05 14:56:44 +00:00
test_instance_types_extra_specs.py objects: Move 'arch' to 'fields.Architecture' 2016-11-25 16:19:41 +00:00
test_iptables_network.py
test_ipv6.py
test_loadables.py
test_matchers.py Port test_matchers.TestDictMatches.test__str__ to Python 3 2016-12-20 11:11:44 +08:00
test_metadata.py Get instance availability_zone without hitting the api db 2017-03-23 09:30:43 -07:00
test_notifications.py Move null_safe funcs to module level 2017-05-11 13:27:24 +02:00
test_notifier.py Make versioned notifications topics configurable 2017-03-14 22:18:15 +02:00
test_nova_manage.py Add strict option to discover_hosts 2017-05-24 13:48:54 +00:00
test_policy.py Merge "Ensure sample policy help text correctly wrapped" 2017-05-29 11:39:02 +00:00
test_profiler.py Remove nova-cert 2017-04-27 22:28:01 -04:00
test_quota.py Add check_deltas() and limit_check_project_and_user() to Quotas 2017-05-28 05:20:22 +00:00
test_rpc.py Clean up ClientRouter debt 2017-04-25 09:58:26 -07:00
test_safeutils.py
test_service.py service: use restart_method='mutate' for all services 2017-05-05 10:54:40 +03:00
test_service_auth.py Add service_token for nova-cinder interaction 2017-01-11 15:49:16 +00:00
test_test.py Make NovaException format errors fatal for tests 2017-05-05 14:45:03 +00:00
test_test_utils.py
test_utils.py trivial: Remove dead code 2017-05-22 17:01:45 +01:00
test_uuid_sentinels.py
test_versions.py
test_weights.py
test_wsgi.py Skip unit tests for SSL + py3 2017-03-02 14:30:16 +08:00
utils.py Fix missing instance.delete notification 2017-03-09 18:49:37 -05:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎