openstack
/
nova
Code Issues Proposed changes
nova/nova
History
Tristan Cacqueray 8e7d6a60ff Mask passwords in exceptions and error messages 
When a ProcessExecutionError is thrown by processutils.ssh_execute(),
the exception may contain information such as password. Upstream
applications that just log the message (as several appear to do)
could inadvertently expose these passwords to a user with read access to
the log files. It is therefore considered prudent to invoke
strutils.mask_password() on the command, stdout and stderr in the
exception. A test case has been added (to oslo-incubator) in order to 
ensure that all three are properly masked.

An earlier commit (853d8f9897) failed
to address ssh_execute(). This change set addresses ssh_execute.

OSSA is aware of this change request.

Change-Id: Ie0caf32469126dd9feb44867adf27acb6e383958
Closes-Bug: #1377981
 		2014-10-06 15:35:49 +00:00
..
CA
…
api Merge "Adds missing exception handling in resize and rebuild servers API" 2014-10-03 06:18:12 +00:00
cells Typo in exception name - CellsUpdateProhibited 2014-09-26 13:45:03 -04:00
cert Merge "Removed copyright from empty files" 2014-06-08 01:22:57 +00:00
cloudpipe Use oslo.i18n 2014-07-18 14:28:09 -04:00
cmd Remove the nova-manage flavor sub-command 2014-10-01 19:36:42 -07:00
compute Merge "Fix creating bdm for failed volume attachment" 2014-09-30 10:07:33 +00:00
conductor Specify correct operation type when NVH is raised 2014-09-09 09:23:51 -05:00
console Merge "Remove websocketproxy workaround" 2014-10-02 16:07:08 +00:00
consoleauth docs - Fix indentation for RPC API's 2014-08-01 15:43:09 +00:00
db Merge "Remove indexes that are prefix subsets of other indexes" 2014-10-03 05:01:37 +00:00
hacking mock.assert_called_once() is not a valid method 2014-09-16 16:38:49 -04:00
image Merge "Pass certificate, key and cacert to glanceclient" 2014-09-17 20:08:58 +00:00
ipv6 Use oslo.i18n 2014-07-18 14:28:09 -04:00
keymgr docs - Fix errors,warnings from document generation 2014-08-08 22:07:31 +00:00
locale Imported Translations from Transifex 2014-09-30 06:39:13 +00:00
network Merge "Neutron: Atomic update of instance info cache" 2014-09-25 06:08:45 +00:00
objects Merge "Undo changes to obj_make_compatible" 2014-09-26 17:24:02 +00:00
objectstore
…
openstack Mask passwords in exceptions and error messages 2014-10-06 15:35:49 +00:00
pci Mitigating performance impact with getting pci requests from DB 2014-09-18 12:41:24 -04:00
rdp
…
scheduler Merge "Scheduler: add log warning hints" 2014-09-22 22:50:24 +00:00
servicegroup Merge "Fix service groups with zookeeper" 2014-09-12 05:26:22 +00:00
spice
…
storage Fix live-migration failure in FC multipath case 2014-08-09 00:02:06 +08:00
tests Merge "VMware: Fix deletion of an instance with no files" 2014-10-03 16:36:14 +00:00
virt Merge "VMware: Fix deletion of an instance with no files" 2014-10-03 16:36:14 +00:00
vnc Use oslo.i18n 2014-07-18 14:28:09 -04:00
volume Retry on closing of luks encrypted volume in case device is busy 2014-09-26 07:31:49 -07:00
__init__.py
…
availability_zones.py object-ify availability_zones 2014-07-09 17:52:06 +00:00
baserpc.py
…
block_device.py Allow empty volumes to be created 2014-08-08 19:30:17 -04:00
config.py Move to oslo.db 2014-09-05 14:18:36 +02:00
context.py Remove local version of generate_request_id 2014-09-27 13:26:00 +02:00
crypto.py Ensure files are closed promptly when generating a key pair 2014-10-01 10:21:42 -07:00
debugger.py Use oslo.i18n 2014-07-18 14:28:09 -04:00
exception.py Merge "console: introduce a new exception InvalidToken" 2014-10-02 02:07:31 +00:00
filters.py Use oslo.i18n 2014-07-18 14:28:09 -04:00
hooks.py docs - Fix errors,warnings from document generation 2014-08-08 22:07:31 +00:00
i18n.py Use oslo.i18n 2014-07-18 14:28:09 -04:00
loadables.py
…
manager.py
…
netconf.py
…
notifications.py Be less confusing about notification states 2014-09-22 11:20:58 -04:00
paths.py
…
policy.py Rewrite nova policy to use the new changes of common policy 2014-05-29 11:44:05 +08:00
quota.py Merge "Fix NoopQuotasDriver.get_settable_quotas()" 2014-09-25 06:05:46 +00:00
rpc.py
…
safe_utils.py Fix and Gate on E265 2014-07-24 08:11:00 -04:00
service.py Use oslo.i18n 2014-07-18 14:28:09 -04:00
test.py add time to logging in unit tests 2014-09-24 09:51:36 -04:00
utils.py Remove use of str on exceptions 2014-08-27 13:55:34 +01:00
version.py Use oslo.i18n 2014-07-18 14:28:09 -04:00
weights.py
…
wsgi.py Remove usage of self.__dict__ for message var replacement 2014-09-25 07:40:27 -07:00