The _destroy_evacuated_instances method on compute
startup tries to cleanup guests from the hypervisor
and allocations held against that compute node resource
provider by evacuated instances, but doesn't take into
account that those evacuated instances could have been
deleted in the meantime which leads to a lazy-load
InstanceNotFound error that kills the startup of the
compute service.
This change adds a functional regression test to recreate
the bug. A subsequent change with the fix will update
the test to show the bug is fixed.
Note that assertFlavorMatchesAllocation and
_boot_and_check_allocations are redefined in the test
class because If6aa37d9b6b48791e070799ab026c816fda4441c
refactored those methods which will cause problems with
backports of this test. The redefined methods will be
removed in a follow up cleanup patch.
NOTE(mriedem): The restart_compute_service() method
needed to be added to the functional test class because
change I17f67a02b27a90658df48856963ea3fb327e81dc is not
in Pike.
Change-Id: I19b0d8baea5440f5d5bc49a6956d9a97bf031a05
Related-Bug: #1794996
(cherry picked from commit d252f81573)
(cherry picked from commit 83d74dbbb6)
(cherry picked from commit c3fd5e5061)
91455a5227