nova/nova/tests/unit
Matt Riedemann a371f11835 Fix circular import in nova.privsep.utils
Commit 26521718bd imported
nova.utils into nova.privsep.utils which can cause
an ImportError due to an ArgsAlreadyParseError because of
nova.utils importing nova.conf which registers config options.

For some obscure reason, this is only being noticed when using
[libvirt]/image_type=lvm, so something in the libvirt lvm image
backend using privsep is tickling this import error, but regardless
the nova.privsep code should avoid importing stuff from the
rest of nova, so this change simply adds a simple
"generate_random_string" utility to nova.privsep.utils to
avoid the import.

Change-Id: I3799869fd4217d12b92d79e27484043ef5b8dc13
Closes-Bug: #1808247
2019-01-03 17:21:10 -05:00
..
api Merge "Clean up header encoding handling in compute API" 2018-12-24 23:09:15 +00:00
cells Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
cmd Remove "API Service Version" upgrade check 2018-12-19 20:41:04 -05:00
compute Drop old service version check compat from _delete_while_booting 2018-12-19 20:41:20 -05:00
conductor Merge "Remove legacy RequestSpec compat from conductor rebuild_instance" 2018-12-20 17:43:45 +00:00
conf Assorted cleanups from numa-aware-vswitches series 2018-07-27 09:49:12 -07:00
console Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
consoleauth Fix stacktraces with redis caching backend 2018-09-27 13:15:11 -04:00
db Use oslo_db.sqlalchemy.test_fixtures 2018-12-25 02:39:48 +00:00
fake_loadables
image Transform compute_task notifications 2018-11-21 16:23:28 +09:00
keymgr
network Merge "Move bridge creation to privsep." 2018-12-28 03:04:40 +00:00
notifications Transform scheduler.select_destinations notification 2018-11-30 13:20:35 +01:00
objects Merge "Add ratio online data migration when load compute node" 2018-12-10 10:05:08 +00:00
pci Fix mock.patch usage in unit tests 2018-09-13 02:54:07 +00:00
privsep Fix circular import in nova.privsep.utils 2019-01-03 17:21:10 -05:00
scheduler Merge "Transform scheduler.select_destinations notification" 2018-12-10 06:05:47 +00:00
servicegroup Fix service list for disabled compute using MC driver 2018-08-14 14:11:22 +08:00
ssl_cert
virt Merge "Move bridge creation to privsep." 2018-12-28 03:04:40 +00:00
volume Add compute API validation for when a volume_type is requested 2018-10-11 16:04:53 -04:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py libvirt: Start populating NUMACell.network_metadata field 2018-07-24 15:33:49 +01:00
fake_block_device.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_build_request.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_console_auth_token.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add trusted_certs object 2018-03-29 23:00:48 -04:00
fake_ldap.py
fake_network.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_network_cache_model.py
fake_notifier.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
fake_pci_device_pools.py
fake_policy.py Allow ability for non admin users to use all filters on server list. 2018-09-14 19:04:08 -04:00
fake_processutils.py
fake_request_spec.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_requests.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_xvp_console_proxy.py
image_fixtures.py Merge image_size extension response into image view builder 2018-10-18 01:59:34 +00:00
matchers.py
policy_fixture.py Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
test_api_validation.py Add python 3.7 unit and functional tox jobs 2018-12-13 10:41:46 -05:00
test_availability_zones.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_baserpc.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_block_device.py Add microversion 2.67 to rest api version history 2018-10-15 13:25:31 +00:00
test_cache.py
test_cinder.py Make [cinder]/catalog_info no longer require a service_name 2018-11-28 18:33:30 -05:00
test_conf.py Configure placement DB context manager for nova-manage/status 2018-09-05 10:29:48 -04:00
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Remove NovaException logging from scatter_gather_cells 2018-11-21 12:43:35 -05:00
test_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
test_exception.py Convert exception messages to strings 2018-11-05 14:21:02 +02:00
test_fake_notifier.py Raise error on timeout in wait_for_versioned_notifications 2018-09-29 00:29:49 +01:00
test_fixtures.py Add DownCellFixture 2018-12-14 10:07:17 +01:00
test_flavors.py Add python 3.7 unit and functional tox jobs 2018-12-13 10:41:46 -05:00
test_hacking.py Skip double word hacking test 2018-11-19 21:54:57 +00:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Transform instance.exists notification 2018-06-05 12:51:30 +00:00
test_loadables.py
test_matchers.py
test_metadata.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_notifications.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
test_notifier.py
test_nova_manage.py Handle online_data_migrations exceptions 2018-10-16 15:49:51 +00:00
test_policy.py Merge "Simplify logic in get_enforcer" 2018-10-30 22:43:51 +00:00
test_profiler.py
test_quota.py Make _instances_cores_ram_count() be smart about cells 2018-11-13 03:35:33 -05:00
test_rpc.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 12:50:10 -07:00
test_service_auth.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_test.py
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Harden placement init under wsgi 2018-11-08 12:25:46 +00:00
test_versions.py
test_weights.py
test_wsgi.py Refactor WSGI apps and utils to limit imports 2018-03-06 22:05:12 +00:00
utils.py Transform missing delete notifications 2018-08-29 13:39:57 +02:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎