openstack
/
nova
Code Issues Proposed changes
nova/nova
History
Johannes Erdfelt a7afc3a04b Don't return from a finally block 
The code in the finally block always executes, even if an exception is
raised. If a return is done, that will cause exceptions to be silently
ignored.

Some unit tests have been failing because of API changes to the
nova.compute.manager:ComputeManager._delete_instance method but the
use of finally/return ended up silently ignoring that error and
caused the test to appear as if it was passing. Another unit test
fails because of a missing uuid attribute.

It could also potentially cause other exceptions to be ignored at
runtime (such as SystemExit) which is likely not the intended
behavior.

Change-Id: I083ee7215296e35a0027be5b3ddf8b764f44cc5b
Closes-bug: 1324277
 		2014-05-29 01:30:04 -07:00
..
CA
…
api Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
cells Cells: Pass instance objects to build_instances 2014-05-20 09:47:53 -04:00
cert Update version aliases for rpc version control 2014-04-18 14:34:33 +00:00
cloudpipe Don't translate debug level logs in cloudpipe, hacking, ipv6, keymgr 2014-04-30 18:00:14 +00:00
cmd Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
compute Don't return from a finally block 2014-05-29 01:30:04 -07:00
conductor Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
console Merge "Improve hacking rule to avoid author markers" 2014-05-06 03:04:03 +00:00
consoleauth Handle situation when key not memcached 2014-05-21 18:59:37 +10:00
db Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
hacking Merge "Don't translate debug level logs in nova.spice, storage, tests and vnc" 2014-05-06 18:37:59 +00:00
image Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
ipv6 Remove vi modelines 2014-02-03 14:19:44 +00:00
keymgr Rename NotAuthorized exception to Forbidden 2014-04-25 12:37:07 -07:00
locale Imported Translations from Transifex 2014-05-27 06:09:15 +00:00
network Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
objects Merge "Fix nova/compute direct use of instance module objects" 2014-05-22 00:43:40 +00:00
objectstore Add HEAD api response for test s3 server BucketHandler 2014-02-09 01:16:33 +08:00
openstack Merge "Sync oslo network utils" 2014-05-28 23:32:29 +00:00
pci Remove PciDeviceList usage in pci manager 2014-03-20 14:14:58 -07:00
rdp Adds RDP console support 2014-02-07 21:20:08 +02:00
scheduler Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
servicegroup Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
spice Remove vi modelines 2014-02-03 14:19:44 +00:00
storage Don't translate debug level logs in nova.spice, storage, tests and vnc 2014-05-01 03:57:19 -07:00
tests Don't return from a finally block 2014-05-29 01:30:04 -07:00
virt Merge "xenapi: refactor volumeops attach" 2014-05-28 21:10:45 +00:00
vnc Remove vi modelines 2014-02-03 14:19:44 +00:00
volume Raise HTTPInternalServerError when boot_from_volume with cinder down 2014-05-23 17:19:11 +09:00
__init__.py Remove vi modelines 2014-02-03 14:19:44 +00:00
availability_zones.py Merge "Fixing availability-zone not take effect error" 2014-02-02 08:08:40 +00:00
baserpc.py Port to oslo.messaging 2014-02-01 09:53:24 +00:00
block_device.py Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
config.py Re-work how debugger CLI opts are registered 2014-03-25 06:44:50 -04:00
context.py Remove quota-class logic from context and make unit tests pass 2014-05-01 16:09:28 -07:00
crypto.py Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
debugger.py Support multi-version pydevd 2014-04-23 15:43:37 -05:00
exception.py xenapi: move StorageError into global exception.py 2014-05-28 17:44:07 +00:00
filters.py
…
hooks.py Remove vi modelines 2014-02-03 14:19:44 +00:00
loadables.py
…
manager.py add support for host driver cleanup during shutdown 2014-03-14 12:01:34 -04:00
netconf.py Enable flake8 H404 checking 2014-02-27 11:15:55 +04:00
notifications.py Add VIF mac address to fixed_ips in notifications 2014-05-21 11:25:13 +10:00
paths.py Reverts change to default state_path 2014-03-12 17:49:42 +00:00
policy.py Adds unit test for etc/nova/policy.json data 2014-02-28 07:24:32 +01:00
quota.py Remove quota_class params from rest of nova.quota 2014-05-16 07:54:29 -07:00
rpc.py Serialize the notification payload in json 2014-02-20 11:42:40 +01:00
safe_utils.py Remove vi modelines 2014-02-03 14:19:44 +00:00
service.py Re-work how debugger CLI opts are registered 2014-03-25 06:44:50 -04:00
test.py Enable flake8 F841 checking 2014-05-28 14:55:08 +01:00
utils.py Merge "Nova utils: add in missing translation" 2014-05-22 12:01:14 +00:00
version.py Remove vi modelines 2014-02-03 14:19:44 +00:00
weights.py Using six.add_metaclass 2014-02-11 09:45:20 +08:00
wsgi.py Make webob.exc.HTTPForbidden return correct message 2014-02-24 19:22:35 +09:00