openstack
/
nova
Code Issues Proposed changes
nova/nova/compute
History
Matt Riedemann b00b2fe9be Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker 
For some reason, probably because build requests are meant to be short lived
and we don't get a lot of bugs about paging misbehavior, when paging instances
with a marker, we didn't raise MarkerNotFound if we didn't find the marker in
the list of build requests. Doing so would match what we do when paging over
cells and listing instances using a marker. Once we find the marker, be that
in build_requests, or one of the cells, we need to set the marker to None to
stop looking for it elsewhere if we have more space to fill our limit.

For example, see change I8a957bebfcecd6ac712103c346e028d80f1ecd7c.

This patch fixes the issue by raising MarkerNotFound from BuildRequestList
get_by_filters if there is a marker and we didn't find a build request for
it. The compute API get_all() method handles that as normal and continues
looking for the marker in one of the cells.

Conflicts:
      nova/tests/unit/compute/test_compute_api.py

NOTE(mriedem): The conflicts are due to not having
bb7c6ebb56 in Ocata.

Change-Id: I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab
Closes-Bug: #1737856
(cherry picked from commit 1706e39891)
(cherry picked from commit 344029b94a)
 		2018-01-03 12:48:04 -05:00
..
monitors Fix invalid import order 2016-07-04 11:23:52 +05:30
__init__.py Switch to using oslo_* instead of oslo.* 2015-02-06 06:03:10 -05:00
api.py Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker 2018-01-03 12:48:04 -05:00
build_results.py Compute Add build_instance hook in compute manager 2014-12-04 10:12:00 -05:00
cells_api.py Move instance creation to conductor 2017-01-26 12:02:54 -08:00
claims.py rt: use a single ResourceTracker object instance 2017-01-16 14:09:25 -05:00
flavors.py Merge "Replace flavors.get_all_flavors_sorted_list() with object call" 2016-10-18 12:13:09 +00:00
instance_actions.py Report instance-actions for live migration force complete API 2016-03-10 15:02:35 +00:00
manager.py Merge "Call terminate_connection when shelve_offloading" into stable/ocata 2017-12-16 17:49:38 +00:00
power_state.py Removed enum duplication from nova.compute 2016-09-02 07:30:44 +00:00
resource_tracker.py Fix regression preventing reporting negative resources for overcommit 2017-06-16 13:49:52 -04:00
rpcapi.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
stats.py Address nits in I83a5f06ad 2016-03-09 13:19:59 +00:00
task_states.py Removed enum duplication from nova.compute 2016-09-02 07:30:44 +00:00
utils.py Fix missing instance.delete notification 2017-03-13 15:02:06 -04:00
vm_states.py Removed enum duplication from nova.compute 2016-09-02 07:30:44 +00:00