be553fb155
In swap_volume method of nova/virt/libvirt/driver.py, before BDM was got by using the instance's UUID and 'serial' of new connection_info as the volume ID, and driver BDM was updated by using the BDM. ('serial' has the volume ID information.) But in _init_volume_connection method in ComputeManager class, 'serial' is passed from old connection_info to new connection_info. It works fine in the case that cinder initiates swapping volumes because the ID of the attached volume isn't changed after swapping volumes. But in the case that nova initiates swapping volumes, the ID of the attached volume is changed. So in the case that nova initiated swapping volumes, after swap volume function was performed once, BDM was got by wrong old volume id (serial) when swap volume function was performed for the second time. So if 'serial' of new connection_info is None, it is set to new volume ID. And if cinder 'migrate_volume_completion' API returns old volume ID (the case that cinder initiates swapping volumes), the 'serial' of new connection_info is set to old volume ID. If cinder 'migrate_volume_completion' API returns new volume ID (the case that nova initiated swapping volumes), the 'serial' is left as it is (new volume ID). Change-Id: I86b8fbb09b0f1ed4c667683de3827cd9b63bca7f Closes-Bug: #1490236 |
||
---|---|---|
.. | ||
api | ||
api_samples_test_base | ||
cells | ||
cert | ||
cmd | ||
compute | ||
conductor | ||
console | ||
consoleauth | ||
db | ||
fake_loadables | ||
image | ||
keymgr | ||
monkey_patch_example | ||
network | ||
notifications | ||
objects | ||
pci | ||
scheduler | ||
servicegroup | ||
ssl_cert | ||
virt | ||
volume | ||
README.rst | ||
__init__.py | ||
cast_as_call.py | ||
conf_fixture.py | ||
fake_block_device.py | ||
fake_build_request.py | ||
fake_console_auth_token.py | ||
fake_crypto.py | ||
fake_flavor.py | ||
fake_hosts.py | ||
fake_instance.py | ||
fake_ldap.py | ||
fake_network.py | ||
fake_network_cache_model.py | ||
fake_notifier.py | ||
fake_pci_device_pools.py | ||
fake_policy.py | ||
fake_processutils.py | ||
fake_request_spec.py | ||
fake_server_actions.py | ||
fake_utils.py | ||
fake_volume.py | ||
image_fixtures.py | ||
matchers.py | ||
policy_fixture.py | ||
test_api_validation.py | ||
test_availability_zones.py | ||
test_baserpc.py | ||
test_block_device.py | ||
test_cache.py | ||
test_cinder.py | ||
test_conf.py | ||
test_configdrive2.py | ||
test_context.py | ||
test_crypto.py | ||
test_exception.py | ||
test_fixtures.py | ||
test_flavors.py | ||
test_hacking.py | ||
test_hash_ring.py | ||
test_hooks.py | ||
test_instance_types_extra_specs.py | ||
test_iptables_network.py | ||
test_ipv6.py | ||
test_loadables.py | ||
test_matchers.py | ||
test_metadata.py | ||
test_notifications.py | ||
test_notifier.py | ||
test_nova_manage.py | ||
test_pipelib.py | ||
test_policy.py | ||
test_quota.py | ||
test_rpc.py | ||
test_safeutils.py | ||
test_service.py | ||
test_signature_utils.py | ||
test_test.py | ||
test_test_utils.py | ||
test_utils.py | ||
test_uuid_sentinels.py | ||
test_versions.py | ||
test_weights.py | ||
test_wsgi.py | ||
utils.py |
README.rst
OpenStack Nova Testing Infrastructure
This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.
Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure
Test Types: Unit vs. Functional vs. Integration
TBD
Writing Unit Tests
TBD
Using Fakes
TBD
test.TestCase
The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.
If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.
Writing Functional Tests
TBD
Writing Integration Tests
TBD
Tests and Exceptions
A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.
In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.
This applies to catching exceptions manually with a try/except block, or using assertRaises().
Example:
self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
elevated, instance_uuid)
If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.
Example:
def stubbed_method(self):
raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)
obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)
Stubbing and Mocking
Whenever possible, tests SHOULD NOT stub and mock out the same function.
If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.
If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.