nova/nova/tests/unit
Takashi NATSUME be553fb155 Set 'serial' to new volume ID in swap volumes
In swap_volume method of nova/virt/libvirt/driver.py,
before BDM was got by using the instance's UUID and
'serial' of new connection_info as the volume ID,
and driver BDM was updated by using the BDM.
('serial' has the volume ID information.)
But in _init_volume_connection method in ComputeManager class,
'serial' is passed from old connection_info to new connection_info.

It works fine in the case that cinder initiates swapping volumes
because the ID of the attached volume isn't changed after
swapping volumes.
But in the case that nova initiates swapping volumes,
the ID of the attached volume is changed.

So in the case that nova initiated swapping volumes,
after swap volume function was performed once,
BDM was got by wrong old volume id (serial)
when swap volume function was performed for the second time.

So if 'serial' of new connection_info is None,
it is set to new volume ID.
And if cinder 'migrate_volume_completion' API returns
old volume ID (the case that cinder initiates swapping volumes),
the 'serial' of new connection_info is set to old volume ID.
If cinder 'migrate_volume_completion' API returns new volume ID
(the case that nova initiated swapping volumes),
the 'serial' is left as it is (new volume ID).

Change-Id: I86b8fbb09b0f1ed4c667683de3827cd9b63bca7f
Closes-Bug: #1490236
2016-09-12 00:31:20 +00:00
..
api Merge "Move placement api request logging to middleware" 2016-09-06 13:41:02 +00:00
api_samples_test_base Fix invalid import order 2016-07-04 16:03:42 +05:30
cells Fix migration list + MigrationList operation 2016-08-15 10:05:23 -04:00
cert
cmd Merge "Adds nova-policy-check cmd" 2016-09-01 17:56:56 +00:00
compute Set 'serial' to new volume ID in swap volumes 2016-09-12 00:31:20 +00:00
conductor Fix service version lookups 2016-09-01 10:05:57 -04:00
console Merge "Remove invalid test methods for config option port_range" 2016-07-09 03:58:23 +00:00
consoleauth Avoid unconditional warnings in nova-consoleauth 2016-04-26 23:52:49 +02:00
db db: retry on deadlocks while adding an instance 2016-09-08 16:06:31 +00:00
fake_loadables
image Merge "Default image.size to 0 when extracting v1 image attributes" 2016-08-03 11:20:46 +00:00
keymgr Fix spelling mistake 2016-05-13 08:23:18 -07:00
monkey_patch_example
network Merge "Implement setup_networks_on_host for Neutron networks" 2016-09-08 11:53:58 +00:00
notifications Removed enum duplication from nova.compute 2016-09-02 07:30:44 +00:00
objects Add create_all and delete_all for AllocationList 2016-09-01 11:38:40 -07:00
pci Merge "Resolve PCI devices on the host during Guest boot-up." 2016-08-04 00:09:55 +00:00
scheduler Merge "ironic_host_manager: fix population of instances info on start" 2016-09-08 12:09:46 +00:00
servicegroup Remove deprecated "memcached_server" in Default section 2016-05-13 00:58:10 +00:00
ssl_cert
virt Set 'serial' to new volume ID in swap volumes 2016-09-12 00:31:20 +00:00
volume Replace mox with mock in test_cinder 2016-08-12 17:27:26 +02:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Fix unit test after the replace of key manager 2016-05-25 14:57:43 +01:00
fake_block_device.py
fake_build_request.py Create Instance from BuildRequest if not in a cell 2016-08-22 16:52:53 -04:00
fake_console_auth_token.py Add console auth tokens db api methods 2016-06-23 11:24:38 +01:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py objects: Add devices_metadata to instance object 2016-06-24 04:30:51 -04:00
fake_ldap.py
fake_network.py Remove DictCompat from instance_info_cache 2016-06-13 18:31:45 +00:00
fake_network_cache_model.py
fake_notifier.py Stop using mox stubs in tests/unit/fake_notifier 2016-06-10 11:27:09 +02:00
fake_pci_device_pools.py
fake_policy.py policy: clean-up 2016-06-30 19:56:14 +00:00
fake_processutils.py Trivial-Fix: Fix typos 2016-06-13 06:41:08 +00:00
fake_request_spec.py Add requested_destination field to RequestSpec 2016-05-27 10:14:51 +02:00
fake_server_actions.py Stop using mox from unit/fake_server_actions.py 2016-06-21 09:09:59 +07:00
fake_utils.py
fake_volume.py config options: centralize cinder options 2016-03-15 21:17:38 -04:00
image_fixtures.py
matchers.py tests: make XMLMatches work with Python3 2016-06-07 15:23:53 +01:00
policy_fixture.py policy: Add defaults in code (part 1) 2016-06-23 19:53:29 +03:00
test_api_validation.py Fix api_validation for Python 3 2016-07-01 11:04:15 +02:00
test_availability_zones.py
test_baserpc.py Move config options from nova/compute/rpcapi.py file 2016-04-21 22:26:13 +00:00
test_block_device.py Merge "Fixes py3 unit tests for nova.tests.unit.test_block_device.*" 2016-06-10 15:04:39 +00:00
test_cache.py Remove deprecated "memcached_server" in Default section 2016-05-13 00:58:10 +00:00
test_cinder.py config options: centralize cinder options 2016-03-15 21:17:38 -04:00
test_conf.py Add the ability to configure glanceclient debug logging 2016-08-04 00:32:37 +00:00
test_configdrive2.py
test_context.py Move cell message queue switching and add caching 2016-08-31 22:33:17 +00:00
test_crypto.py Drop paramiko < 2 compat code 2016-05-10 12:01:22 -05:00
test_exception.py Transform wrap_exception notification to versioned format 2016-06-21 09:39:47 +02:00
test_fixtures.py Use StableObjectJsonFixture from o.vo 2016-08-29 11:52:10 -04:00
test_flavors.py Return 400 HTTP error for invalid flavor attributes 2016-05-26 09:49:39 +05:30
test_hacking.py Remove hacking check [N347] for config options. 2016-08-11 14:23:21 +02:00
test_hash_ring.py Ironic: allow multiple compute services 2016-08-04 23:51:13 +00:00
test_hooks.py Stop using mox stubs in nova/tests/unit 2016-06-10 06:55:57 +09:00
test_instance_types_extra_specs.py Objectify test_instance_type_extra_specs 2016-03-23 06:55:10 -07:00
test_iptables_network.py Merge "Remove mox from nova/tests/unit/test_iptables_network.py" 2016-06-09 10:23:05 +00:00
test_ipv6.py Fix test_ipv6 and simplify to_global() 2016-06-28 20:42:32 +02:00
test_loadables.py
test_matchers.py Fix invalid import order 2016-07-04 16:14:20 +05:30
test_metadata.py Merge "Add more vd2 unit tests" 2016-08-30 21:14:30 +00:00
test_notifications.py Make notifications module use flavor capacity attributes 2016-07-12 11:52:07 -07:00
test_notifier.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_nova_manage.py Run cell0 db migrations during nova-manage simple_cell_setup 2016-08-31 23:38:09 +00:00
test_pipelib.py conf: Move cloudpipe options to a group 2016-08-22 09:31:03 +01:00
test_policy.py Emit warning when use 'user_id' in policy rule 2016-08-29 11:46:15 +00:00
test_quota.py Quota changes for the nova-manage quota_usage_refresh command 2016-07-06 22:21:39 +00:00
test_rpc.py Move cell message queue switching and add caching 2016-08-31 22:33:17 +00:00
test_safeutils.py
test_service.py Fix use of invalid assert calls 2016-05-19 13:12:15 +01:00
test_signature_utils.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_test.py Remove mox from unit/compute/test_compute.py (8) 2016-06-28 02:49:25 +00:00
test_test_utils.py
test_utils.py Merge "Properly quote IPv6 address in RsyncDriver" 2016-08-18 13:17:19 +00:00
test_uuid_sentinels.py Fix invalid import order 2016-07-04 16:24:10 +05:30
test_versions.py
test_weights.py
test_wsgi.py config options: Remove 'wsgi_' prefix from opts 2016-03-25 13:19:19 +00:00
utils.py Add a test utility for checking mock calls with objects 2016-06-29 07:22:22 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎