openstack
/
nova
Code Issues Proposed changes
nova/nova
History
Matt Riedemann c0820944ea libvirt: fix and break up _test_attach_detach_interface 
The detach_interface flow in this test was broken because
it wasn't mocking out domain.detachDeviceFlags so the xml
it was expecting to be passed to that method wasn't actually
being verified. The same thing is broken in test
test_detach_interface_device_with_same_mac_address because
it copies the other broken test code.

This change breaks apart the monster attach/detach test method
and converts the detach_interface portion to mock and fixes
the broken assertion.

test_detach_interface_device_with_same_mac_address is just
fixed, not converted to mock.

Change-Id: I6d9a975876c5652ef544c587f65b1bdd1543848b
Related-Bug: #1607714
(cherry picked from commit 1ecd71b08d)
 		2017-06-08 11:56:22 -04:00
..
CA
…
api Catch exception.OverQuota when create image for volume backed instance 2017-05-23 06:28:00 +00:00
cells Use six.text_type() when logging Instance object 2017-05-22 10:57:28 +00:00
cert Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
cloudpipe Rename security_group parameter in compute.API:create 2016-11-10 11:25:43 -05:00
cmd Handle special characters in database connection URL netloc 2017-05-22 11:20:55 -04:00
common cors: update default configuration in config 2016-11-05 20:17:42 -04:00
compute Fix MarkerNotFound when paging and marker was found in cell0 2017-05-30 14:25:22 -04:00
conductor Add populate_retry to schedule_and_build_instances 2017-03-17 10:15:10 -04:00
conf Parse algorithm from cipher for ephemeral disk encryption 2017-05-19 10:45:46 -04:00
console Merge "tests: Replace use of CONF with monkey patching" 2017-01-24 12:03:07 +00:00
consoleauth Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
db Exclude deleted service records when calling hypervisor statistics 2017-05-26 19:47:51 +00:00
hacking [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
image Merge "[2/3]Replace six.iteritems() with .items()" 2017-01-21 06:55:52 +00:00
ipv6 Fix test_ipv6 and simplify to_global() 2016-06-28 20:42:32 +02:00
keymgr Deprecate barbican options 2016-07-29 15:36:28 -05:00
locale Imported Translations from Zanata 2016-10-27 08:19:38 +00:00
network Fix port update exception when unshelving an instance with PCI devices 2017-04-25 19:20:38 +00:00
notifications Merge "[2/3]Replace six.iteritems() with .items()" 2017-01-21 06:55:52 +00:00
objects Fix live migrate with XenServer 2017-02-16 12:47:09 -05:00
pci [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
policies Separate CRUD policy for server_groups 2016-11-21 11:43:13 -05:00
scheduler Use the keystone session loader in the placement reporting 2017-02-22 16:45:13 -05:00
servicegroup Don't use 'updated_at' to check service's status 2016-12-08 09:51:03 +00:00
tests libvirt: fix and break up _test_attach_detach_interface 2017-06-08 11:56:22 -04:00
virt Merge "libvirt: Always disconnect_volume after rebase failures" into stable/ocata 2017-06-06 22:12:49 +00:00
vnc
…
volume Avoid lazy-loading instance.id when cross_az_attach=False 2017-05-27 13:40:13 +00:00
wsgi Clarify the language in the apache wsgi sample 2017-02-02 15:43:25 -08:00
__init__.py
…
availability_zones.py Avoid lazy-load error when getting instance AZ 2017-05-31 16:00:42 +00:00
baserpc.py
…
block_device.py Allow None for block_device_mapping_v2.boot_index 2017-02-09 15:20:06 +00:00
cache_utils.py
…
config.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
context.py Cache database and message queue connection objects 2017-05-19 21:54:25 +00:00
crypto.py
…
debugger.py
…
exception.py libvirt: Always disconnect_volume after rebase failures 2017-04-26 21:25:47 +01:00
exception_wrapper.py do not include context to exception notification 2017-03-17 13:00:21 -04:00
filters.py
…
hash_ring.py Ironic: allow multiple compute services 2016-08-04 23:51:13 +00:00
hooks.py
…
i18n.py
…
loadables.py
…
manager.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
policy.py [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
profiler.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
quota.py [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
rpc.py Added instance.reboot.error to the legacy notifications 2017-01-27 19:15:41 +00:00
safe_utils.py
…
service.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
service_auth.py Add service_token for nova-cinder interaction 2017-01-11 15:49:16 +00:00
signature_utils.py
…
test.py Cache database and message queue connection objects 2017-05-19 21:54:25 +00:00
utils.py Use six.text_type() when logging Instance object 2017-05-22 10:57:28 +00:00
version.py
…
weights.py
…
wsgi.py [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00