nova/nova/tests/unit
Brandon Irizarry d627ae8526 Changed an HTTP exception to return proper code
POSTing to /servers with a content-type of text/plain
and a text/plain body results in a response code of 400.
It should be 415. I found this line in the code that
appears to handle this singular case and modified
the HTTP exception used to the correct one. Tests were
also updated accordingly.

Change-Id: I5fa1fdba56803b2ef63b1efaaeeced6ceb7779d9
Closes-Bug: 1567977
(cherry picked from commit a7019a87ba)
2016-04-20 16:49:26 +00:00
..
api Changed an HTTP exception to return proper code 2016-04-20 16:49:26 +00:00
api_samples_test_base Drop the use of magic openstack project_id 2016-03-08 19:34:56 +00:00
cells Avoid lazy-loads of ec2_ids on Instance 2016-03-15 07:07:15 -07:00
cert Replaces contextlib.nested with test.nested 2015-10-08 23:13:30 +03:00
cmd Fix error handling in nova.cmd.baseproxy 2015-10-22 09:19:57 +08:00
compute Fix: unable to delete instance when cinder is down 2016-04-08 00:59:36 +00:00
conductor Stop providing force_hosts to the scheduler for move ops 2016-03-25 20:35:28 +00:00
console Fix misuse of assertTrue in console and virt tests 2016-02-22 16:09:21 +09:00
consoleauth Switch to oslo.cache lib 2016-02-02 08:20:13 -05:00
db Merge "Add include_disabled parameter to service_get_all_by_binary" 2016-03-10 14:01:39 +00:00
fake_loadables
image Fix retry mechanism for generator results 2016-03-21 14:37:22 +00:00
keymgr Migrate from keystoneclient to keystoneauth 2016-01-28 10:55:29 -06:00
monkey_patch_example
network stop setting mtu when plugging vhost-user ports 2016-03-22 11:54:12 -04:00
objects Stop providing force_hosts to the scheduler for move ops 2016-03-25 20:35:28 +00:00
pci objects: Rename PciDevice _migrate_parent_addr method 2016-02-15 10:47:24 +00:00
scheduler Make force_ and ignore_hosts comparisons case insensitive 2016-03-09 16:13:23 +00:00
servicegroup Add service binary/host to service is down log for context 2016-02-26 12:57:57 -05:00
ssl_cert
virt libvirt: Allow use of live snapshots with RBD snapshot/clone 2016-04-09 13:29:43 +00:00
volume Check if a exception has a code on it before read the code 2016-04-09 18:24:35 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Drop the use of magic openstack project_id 2016-03-08 19:34:56 +00:00
fake_block_device.py DriverBlockDevice must receive a BDM object, not a dict 2015-12-28 06:35:21 -08:00
fake_build_request.py Add BuildRequest object 2016-03-02 21:31:45 -05:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add object and database support for host_status API 2016-01-15 09:48:59 -08:00
fake_ldap.py
fake_network.py Replace stubs.Set with stub_out (fakes) 2016-01-13 22:19:38 -05:00
fake_network_cache_model.py
fake_notifier.py Make emitting versioned notifications configurable 2016-01-19 19:20:24 +01:00
fake_pci_device_pools.py
fake_policy.py Abort an ongoing live migration 2016-02-26 15:11:41 +00:00
fake_processutils.py
fake_request_spec.py Add persistence to the RequestSpec object 2015-11-28 00:10:26 +01:00
fake_server_actions.py
fake_utils.py
fake_volume.py Revert "Pass host when call attach to Cinder" 2016-01-27 16:21:08 +00:00
image_fixtures.py
matchers.py [Py34] Enable api.openstack.test_wsgi unit test 2015-12-10 21:53:01 +02:00
policy_fixture.py use graduated oslo.policy 2015-11-26 13:04:52 +08:00
test_api_validation.py Generate better validation error message when using name regexes 2016-03-07 10:11:49 +08:00
test_availability_zones.py Config options: centralize options in availability_zones 2016-01-27 17:32:04 +00:00
test_baserpc.py
test_block_device.py Adding guard on None value for some helpers method 2016-01-28 09:32:13 +00:00
test_cache.py Switch to oslo.cache lib 2016-02-02 08:20:13 -05:00
test_cinder.py Pass attachment_id to Cinder when detach a volume 2016-01-20 22:16:27 +01:00
test_configdrive2.py
test_context.py Fix string interpolations at logging calls 2016-03-07 12:05:58 +09:00
test_crypto.py Make test cases test_crypto.py from NoDBTestCase 2016-03-07 12:09:45 +00:00
test_exception.py Use of six.PY3 should be forward compatible 2016-01-17 03:32:34 +00:00
test_fixtures.py Change SpawnIsSynchronous fixture return 2016-03-10 13:48:41 -05:00
test_flavors.py Fixes dict keys and items references for Python 3 2015-12-07 12:19:59 +02:00
test_hacking.py Hacking: check for deprecated os.popen() 2016-02-19 21:55:20 -02:00
test_hooks.py
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_loadables.py
test_matchers.py
test_metadata.py Get instance security_groups from already fetched instance 2016-03-11 19:16:29 +01:00
test_notifications.py Remove unused CONF imports 2016-02-15 16:40:53 +11:00
test_notifier.py Use get_notification_transport() for notifications 2016-01-25 18:40:09 +00:00
test_nova_manage.py Merge "Add a cell and host mapping utility to nova-manage" 2016-03-15 22:42:31 +00:00
test_pipelib.py
test_policy.py Abort an ongoing live migration 2016-02-26 15:11:41 +00:00
test_quota.py config options: Centralise 'virt.driver' options 2016-02-11 09:40:25 +00:00
test_rpc.py Forbid new legacy notification event_type 2016-03-07 10:31:56 +01:00
test_safeutils.py Replace safe_utils.getcallargs with inspect.getcallargs 2015-12-11 10:15:37 -05:00
test_service.py Reset the compute_rpcapi in Compute manager on SIGHUP 2015-12-04 13:13:23 -08:00
test_signature_utils.py Extend FakeCryptoCertificate.cert_not_valid_after to 2 hours 2016-03-07 20:13:54 +00:00
test_test.py Make test cases in test_test.py use NoDBTest 2015-10-07 04:03:38 +08:00
test_test_utils.py Replaces __builtin__ with six.moves.builtins 2016-01-13 13:51:48 +08:00
test_utils.py update tests for use_neutron=True; fix exposed bugs 2016-03-04 11:01:18 -05:00
test_uuid_sentinels.py Add uuidsentinel test module 2015-12-14 11:28:55 +01:00
test_versions.py Use stub_out and mock to remove mox: part 2 2015-12-19 19:43:46 +08:00
test_weights.py Identify more py34 tests that already pass 2015-09-29 08:03:24 -04:00
test_wsgi.py Replace eventlet-based raw socket client with requests 2016-02-09 21:14:20 +00:00
utils.py compute: convert manager to use nova.objects.ImageMeta 2016-01-15 11:26:06 +00:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎