nova/nova/tests/unit
rsritesh e93bc57a73 libvirt: flatten rbd images when unshelving an instance
Previously attempts to remove the shelved snapshot of an unshelved
instance when using the rbd backends for both Nova and Glance would
fail. This was due to the instance disk being cloned from and still
referencing the shelved snapshot image in Glance, blocking any attempt
to remove this image later in the unshelve process.

After much debate this change attempts to fix this issue by flattening
the instance disk while the instance is being spawned as part of an
unshelve. For the rbd imagebackend this removes any reference to the
shelved snapshot in Glance allowing this image to be removed. For all
other imagebackends the call to flatten the image is currently a no-op.

Co-Authored-By: Lee Yarwood <lyarwood@redhat.com>
Co-Authored-By: Vladyslav Drok <vdrok@mirantis.com>

Closes-Bug: #1653953
Change-Id: If3c9d1de3ce0fe394405bd1e1f0fa08ce2baeda8
(cherry picked from commit d89e7d7857)
(cherry picked from commit e802ede4b3)
2019-06-28 10:07:59 +01:00
..
api Block swap volume on volumes with >1 rw attachment 2019-05-30 17:25:06 -04:00
api_samples_test_base Fix os-simple-tenant-usage result order 2018-10-29 08:15:47 +00:00
cells Use nova.db.api directly 2018-07-10 14:56:27 +00:00
cmd Add nova-status upgrade check for consoles 2018-10-30 17:34:55 +00:00
compute Merge "Allow driver to properly unplug VIFs on destination on confirm resize" into stable/rocky 2019-06-13 19:38:16 +00:00
conductor Merge "Fix incomplete instance data returned after build failure" into stable/rocky 2019-04-17 20:29:39 +00:00
conf Assorted cleanups from numa-aware-vswitches series 2018-07-27 09:49:12 -07:00
console Move create of ComputeAPI object in websocketproxy 2019-04-10 15:34:17 -07:00
consoleauth Fix stacktraces with redis caching backend 2018-10-01 07:50:53 +00:00
db Fix retry of instance_update_and_get_original 2019-05-20 11:57:01 +01:00
fake_loadables
image prevent common kwargs from glance client failure 2019-04-05 13:31:21 +09:00
keymgr
network Move get_pci_mapping_for_migration to MigrationContext 2019-06-05 17:43:15 +03:00
notifications Transform metrics.update notification 2018-07-18 09:13:27 +09:00
objects Move get_pci_mapping_for_migration to MigrationContext 2019-06-05 17:43:15 +03:00
pci PCI: do not force remove allocated devices 2019-02-05 23:29:36 +00:00
privsep Move image conversion to privsep. 2018-05-15 10:09:01 -04:00
scheduler Fix bug preventing forbidden traits from working 2019-04-03 11:44:16 -05:00
servicegroup Fix service list for disabled compute using MC driver 2018-09-14 02:25:10 +00:00
ssl_cert
virt libvirt: flatten rbd images when unshelving an instance 2019-06-28 10:07:59 +01:00
volume Remove unnecessary parameters from create volume API 2018-06-12 12:06:41 +05:30
README.rst
__init__.py
cast_as_call.py
conf_fixture.py libvirt: Start populating NUMACell.network_metadata field 2018-07-24 15:33:49 +01:00
fake_block_device.py Make BlockDeviceMapping object support uuid 2017-12-17 16:47:30 +00:00
fake_build_request.py
fake_console_auth_token.py Add access_url_base to console_auth_tokens table 2018-01-06 02:02:26 +00:00
fake_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add trusted_certs object 2018-03-29 23:00:48 -04:00
fake_ldap.py
fake_network.py Remove unused stubbing function from test 2018-08-02 12:53:36 +00:00
fake_network_cache_model.py
fake_notifier.py
fake_pci_device_pools.py
fake_policy.py Fix a missing policy in test policy data 2019-02-15 02:03:50 +00:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-03-15 15:52:18 +00:00
fake_requests.py Unit test framework: common FakeResponse 2018-03-26 10:28:52 -05:00
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py
fake_xvp_console_proxy.py
image_fixtures.py
matchers.py
policy_fixture.py Implement granular policy rules for placement 2018-05-17 11:12:16 -04:00
test_api_validation.py Fix PatternPropertiesTestCase for py 3.6 2018-02-19 11:06:45 +00:00
test_availability_zones.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_baserpc.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_block_device.py
test_cache.py
test_cinder.py Fix bug case by none token context 2018-01-24 20:53:50 -05:00
test_conf.py Configure placement DB context manager for nova-manage/status 2018-09-06 10:47:55 -04:00
test_configdrive2.py Merge "We don't need utils.trycmd any more." 2018-05-16 14:45:44 +00:00
test_context.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_crypto.py crypto: Remove unused functions 2018-03-08 10:24:40 +00:00
test_exception.py Add full traceback to ExceptionPayload in versioned notifications 2018-06-19 16:46:46 +08:00
test_fixtures.py Escalate UUID validation warning to error in test 2018-07-17 13:26:38 +02:00
test_flavors.py Remove unused flavor_delete_info() method 2018-08-03 12:44:52 -04:00
test_hacking.py Fix N332 api_version decorator hacking check 2018-03-29 10:27:30 -05:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py Transform instance.exists notification 2018-06-05 12:51:30 +00:00
test_loadables.py
test_matchers.py
test_metadata.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_notifications.py Improve NeutronFixture and remove unncessary stubbing 2018-08-02 15:15:03 +02:00
test_notifier.py
test_nova_manage.py Fix using template cell urls with nova-manage 2019-01-24 18:08:20 -05:00
test_policy.py Remove support for /os-floating-ip-dns REST API 2018-07-18 22:23:45 -04:00
test_profiler.py
test_quota.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_rpc.py Use oslo.messaging per-call monitoring 2018-06-11 14:44:10 -07:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 16:21:52 -04:00
test_service_auth.py remove unnecessary conf imports 2018-03-09 14:30:10 -05:00
test_test.py
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Harden placement init under wsgi 2018-11-12 11:30:32 +00:00
test_uuid_sentinels.py
test_versions.py
test_weights.py
test_wsgi.py Refactor WSGI apps and utils to limit imports 2018-03-06 22:05:12 +00:00
utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎