nova/nova/tests/unit
Ankit Agrawal ec9d5e375e libvirt: Race condition leads to instance in error
ImageCacheManager deletes base image while image backend is copying
image to the instance path leading instance to go in the error state.

Acquired lock before removing image from cache. If libvirt is copying
image to the instance path, image cache manager won't be able to remove
it until libvirt finishes copying image completely.

Closes-Bug: 1256838
Closes-Bug: 1470437
Co-Authored-By: Michael Still <mikal@stillhq.com>
Depends-On: I337ce28e2fc516c91bec61ca3639ebff0029ad49
Change-Id: I376cc951922c338669fdf3f83da83e0d3cea1532
2016-02-05 20:48:58 +00:00
..
api Replace stubs.Set with stub_out (db) 2016-01-30 17:49:03 -05:00
cells Replace stubs.Set with stub_out (db) 2016-01-30 17:49:03 -05:00
cert Replaces contextlib.nested with test.nested 2015-10-08 23:13:30 +03:00
cmd Fix error handling in nova.cmd.baseproxy 2015-10-22 09:19:57 +08:00
compute Merge "Replace stubs.Set with stub_out (db)" 2016-02-01 21:42:31 +00:00
conductor enginefacade: 'block_device_mapping' 2016-01-20 16:30:19 +03:00
console Stop using mox stubs in nova.tests.unit.console 2016-01-13 10:36:59 +08:00
consoleauth Add SIGHUP handlers for compute rpcapi to console and conductor 2015-12-10 08:48:05 -08:00
db Replace stubs.Set with stub_out (db) 2016-01-30 17:49:03 -05:00
fake_loadables
image Merge "Fix invalid import order" 2016-01-22 13:11:20 +00:00
keymgr Migrate from keystoneclient to keystoneauth 2016-01-28 10:55:29 -06:00
monkey_patch_example
network Merge "Replace stubs.Set with stub_out (db)" 2016-02-01 21:42:31 +00:00
objects Merge "Replace stubs.Set with stub_out (db)" 2016-02-01 21:42:31 +00:00
pci pci: changing the claiming and allocation logic for PF/VF assignment 2016-01-19 15:00:50 -05:00
scheduler Merge "Revert "Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter"" 2016-02-01 18:35:54 +00:00
servicegroup Use TimeFixture from oslo_utils to override time in tests 2015-12-18 12:15:00 -05:00
ssl_cert
virt libvirt: Race condition leads to instance in error 2016-02-05 20:48:58 +00:00
volume Revert "Pass host when call attach to Cinder" 2016-01-27 16:21:08 +00:00
README.rst
__init__.py Move objects registration in tests directory 2015-08-24 10:21:27 -04:00
cast_as_call.py
conf_fixture.py Make project_id optional in v2.1 urls 2016-01-24 06:38:15 -05:00
fake_block_device.py DriverBlockDevice must receive a BDM object, not a dict 2015-12-28 06:35:21 -08:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add object and database support for host_status API 2016-01-15 09:48:59 -08:00
fake_ldap.py
fake_network.py Replace stubs.Set with stub_out (fakes) 2016-01-13 22:19:38 -05:00
fake_network_cache_model.py
fake_notifier.py Make emitting versioned notifications configurable 2016-01-19 19:20:24 +01:00
fake_pci_device_pools.py
fake_policy.py Add a REST API to trigger crash dump in an instance. 2016-01-20 09:42:50 +08:00
fake_processutils.py
fake_request_spec.py Add persistence to the RequestSpec object 2015-11-28 00:10:26 +01:00
fake_server_actions.py
fake_utils.py
fake_volume.py Revert "Pass host when call attach to Cinder" 2016-01-27 16:21:08 +00:00
image_fixtures.py
matchers.py [Py34] Enable api.openstack.test_wsgi unit test 2015-12-10 21:53:01 +02:00
policy_fixture.py use graduated oslo.policy 2015-11-26 13:04:52 +08:00
test_api_validation.py Add microversions schema unit test for None 2015-11-17 05:20:52 +00:00
test_availability_zones.py Merge "Fix order of arguments in assertEqual" 2015-09-18 18:46:13 +00:00
test_baserpc.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_block_device.py Adding guard on None value for some helpers method 2016-01-28 09:32:13 +00:00
test_cinder.py Pass attachment_id to Cinder when detach a volume 2016-01-20 22:16:27 +01:00
test_configdrive2.py
test_context.py Use stub_out and mock to remove mox:part 3 2016-01-13 15:54:43 +08:00
test_crypto.py Replace stubs.Set with stub_out (db) 2016-01-30 17:49:03 -05:00
test_exception.py Use of six.PY3 should be forward compatible 2016-01-17 03:32:34 +00:00
test_fixtures.py Change assertEqual(True/False) to assertTrue/False 2016-01-11 17:02:11 +05:30
test_flavors.py Fixes dict keys and items references for Python 3 2015-12-07 12:19:59 +02:00
test_hacking.py Python3: Replace dict.iteritems with six.iteritems 2016-01-21 21:41:52 -08:00
test_hooks.py
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_loadables.py
test_matchers.py
test_metadata.py Replace stubs.Set with stub_out (db) 2016-01-30 17:49:03 -05:00
test_notifications.py Merge "Use stub_out and mock to remove mox:part 3" 2016-01-15 04:59:27 +00:00
test_notifier.py Use get_notification_transport() for notifications 2016-01-25 18:40:09 +00:00
test_nova_manage.py Replace stubs.Set with stub_out (db) 2016-01-30 17:49:03 -05:00
test_pipelib.py
test_policy.py Trivial: Fix a typo in test_policy.py 2016-02-01 03:09:20 +00:00
test_quota.py enginefacade: 'quota' and 'reservation' 2016-01-22 11:00:36 +03:00
test_rpc.py Use get_notification_transport() for notifications 2016-01-25 18:40:09 +00:00
test_safeutils.py Replace safe_utils.getcallargs with inspect.getcallargs 2015-12-11 10:15:37 -05:00
test_service.py Reset the compute_rpcapi in Compute manager on SIGHUP 2015-12-04 13:13:23 -08:00
test_signature_utils.py signature_utils: move to explicit image metadata 2016-01-04 09:38:21 -05:00
test_test.py Make test cases in test_test.py use NoDBTest 2015-10-07 04:03:38 +08:00
test_test_utils.py Replaces __builtin__ with six.moves.builtins 2016-01-13 13:51:48 +08:00
test_utils.py Use stub_out and mock to remove mox: part 2 2015-12-19 19:43:46 +08:00
test_uuid_sentinels.py Add uuidsentinel test module 2015-12-14 11:28:55 +01:00
test_versions.py Use stub_out and mock to remove mox: part 2 2015-12-19 19:43:46 +08:00
test_weights.py Identify more py34 tests that already pass 2015-09-29 08:03:24 -04:00
test_wsgi.py Use stub_out and mock to remove mox: part 2 2015-12-19 19:43:46 +08:00
utils.py compute: convert manager to use nova.objects.ImageMeta 2016-01-15 11:26:06 +00:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎