674 lines
27 KiB
Python
674 lines
27 KiB
Python
# Copyright 2016 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
Unit tests for the nova-status CLI interfaces.
|
|
"""
|
|
|
|
import fixtures
|
|
import mock
|
|
from six.moves import StringIO
|
|
|
|
from keystoneauth1 import exceptions as ks_exc
|
|
from keystoneauth1 import loading as keystone
|
|
from keystoneauth1 import session
|
|
from oslo_utils import uuidutils
|
|
|
|
from nova.cmd import status
|
|
import nova.conf
|
|
from nova import context
|
|
# NOTE(mriedem): We only use objects as a convenience to populate the database
|
|
# in the tests, we don't use them in the actual CLI.
|
|
from nova import objects
|
|
from nova.objects import fields
|
|
from nova import test
|
|
from nova.tests import fixtures as nova_fixtures
|
|
from nova.tests import uuidsentinel as uuids
|
|
|
|
CONF = nova.conf.CONF
|
|
|
|
|
|
class TestNovaStatusMain(test.NoDBTestCase):
|
|
"""Tests for the basic nova-status command infrastructure."""
|
|
|
|
def setUp(self):
|
|
super(TestNovaStatusMain, self).setUp()
|
|
self.output = StringIO()
|
|
self.useFixture(fixtures.MonkeyPatch('sys.stdout', self.output))
|
|
|
|
@mock.patch.object(status.config, 'parse_args')
|
|
@mock.patch.object(status, 'CONF')
|
|
def _check_main(self, mock_CONF, mock_parse_args,
|
|
category_name='check', expected_return_value=0):
|
|
mock_CONF.category.name = category_name
|
|
return_value = status.main()
|
|
|
|
self.assertEqual(expected_return_value, return_value)
|
|
mock_CONF.register_cli_opt.assert_called_once_with(
|
|
status.category_opt)
|
|
|
|
@mock.patch.object(status.version, 'version_string_with_package',
|
|
return_value="x.x.x")
|
|
def test_main_version(self, mock_version_string):
|
|
self._check_main(category_name='version')
|
|
self.assertEqual("x.x.x\n", self.output.getvalue())
|
|
|
|
@mock.patch.object(status.cmd_common, 'print_bash_completion')
|
|
def test_main_bash_completion(self, mock_print_bash):
|
|
self._check_main(category_name='bash-completion')
|
|
mock_print_bash.assert_called_once_with(status.CATEGORIES)
|
|
|
|
@mock.patch.object(status.cmd_common, 'get_action_fn')
|
|
def test_main(self, mock_get_action_fn):
|
|
mock_fn = mock.Mock()
|
|
mock_fn_args = [mock.sentinel.arg]
|
|
mock_fn_kwargs = {'key': mock.sentinel.value}
|
|
mock_get_action_fn.return_value = (mock_fn, mock_fn_args,
|
|
mock_fn_kwargs)
|
|
|
|
self._check_main(expected_return_value=mock_fn.return_value)
|
|
mock_fn.assert_called_once_with(mock.sentinel.arg,
|
|
key=mock.sentinel.value)
|
|
|
|
@mock.patch.object(status.cmd_common, 'get_action_fn')
|
|
def test_main_error(self, mock_get_action_fn):
|
|
mock_fn = mock.Mock(side_effect=Exception('wut'))
|
|
mock_get_action_fn.return_value = (mock_fn, [], {})
|
|
|
|
self._check_main(expected_return_value=255)
|
|
output = self.output.getvalue()
|
|
self.assertIn('Error:', output)
|
|
# assert the traceback is in the output
|
|
self.assertIn('wut', output)
|
|
|
|
|
|
class TestPlacementCheck(test.NoDBTestCase):
|
|
"""Tests the nova-status placement checks.
|
|
|
|
These are done with mock as the ability to replicate all failure
|
|
domains otherwise is quite complicated. Using a devstack
|
|
environment you can validate each of these tests are matching
|
|
reality.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(TestPlacementCheck, self).setUp()
|
|
self.output = StringIO()
|
|
self.useFixture(fixtures.MonkeyPatch('sys.stdout', self.output))
|
|
self.cmd = status.UpgradeCommands()
|
|
|
|
@mock.patch.object(keystone, "load_auth_from_conf_options")
|
|
def test_no_auth(self, auth):
|
|
"""Test failure when no credentials are specified.
|
|
|
|
Replicate in devstack: start devstack with or without
|
|
placement engine, remove the auth section from the [placement]
|
|
block in nova.conf.
|
|
"""
|
|
auth.side_effect = ks_exc.MissingAuthPlugin()
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, res.code)
|
|
self.assertIn('No credentials specified', res.details)
|
|
|
|
@mock.patch.object(keystone, "load_auth_from_conf_options")
|
|
@mock.patch.object(session.Session, 'get')
|
|
def _test_placement_get_interface(
|
|
self, expected_interface, mock_get, mock_auth):
|
|
|
|
def fake_get(path, *a, **kw):
|
|
self.assertEqual(mock.sentinel.path, path)
|
|
self.assertIn('endpoint_filter', kw)
|
|
self.assertEqual(expected_interface,
|
|
kw['endpoint_filter']['interface'])
|
|
return mock.Mock(autospec='requests.models.Response')
|
|
|
|
mock_get.side_effect = fake_get
|
|
self.cmd._placement_get(mock.sentinel.path)
|
|
mock_auth.assert_called_once_with(status.CONF, 'placement')
|
|
self.assertTrue(mock_get.called)
|
|
|
|
@mock.patch.object(keystone, "load_auth_from_conf_options")
|
|
@mock.patch.object(session.Session, 'get')
|
|
def test_placement_get_interface_default(self, mock_get, mock_auth):
|
|
"""Tests that None is specified for interface by default."""
|
|
self._test_placement_get_interface(None)
|
|
|
|
@mock.patch.object(keystone, "load_auth_from_conf_options")
|
|
@mock.patch.object(session.Session, 'get')
|
|
def test_placement_get_interface_internal(self, mock_get, mock_auth):
|
|
"""Tests that "internal" is specified for interface when configured."""
|
|
self.flags(os_interface='internal', group='placement')
|
|
self._test_placement_get_interface('internal')
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_invalid_auth(self, get):
|
|
"""Test failure when wrong credentials are specified or service user
|
|
doesn't exist.
|
|
|
|
Replicate in devstack: start devstack with or without
|
|
placement engine, specify random credentials in auth section
|
|
from the [placement] block in nova.conf.
|
|
|
|
"""
|
|
get.side_effect = ks_exc.Unauthorized()
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, res.code)
|
|
self.assertIn('Placement service credentials do not work', res.details)
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_invalid_endpoint(self, get):
|
|
"""Test failure when no endpoint exists.
|
|
|
|
Replicate in devstack: start devstack without placement
|
|
engine, but create valid placement service user and specify it
|
|
in auth section of [placement] in nova.conf.
|
|
"""
|
|
get.side_effect = ks_exc.EndpointNotFound()
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, res.code)
|
|
self.assertIn('Placement API endpoint not found', res.details)
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_discovery_failure(self, get):
|
|
"""Test failure when discovery for placement URL failed.
|
|
|
|
Replicate in devstack: start devstack with placement
|
|
engine, create valid placement service user and specify it
|
|
in auth section of [placement] in nova.conf. Stop keystone service.
|
|
"""
|
|
get.side_effect = ks_exc.DiscoveryFailure()
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, res.code)
|
|
self.assertIn('Discovery for placement API URI failed.', res.details)
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_down_endpoint(self, get):
|
|
"""Test failure when endpoint is down.
|
|
|
|
Replicate in devstack: start devstack with placement
|
|
engine, disable placement engine apache config.
|
|
"""
|
|
get.side_effect = ks_exc.NotFound()
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, res.code)
|
|
self.assertIn('Placement API does not seem to be running', res.details)
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_valid_version(self, get):
|
|
get.return_value = {
|
|
"versions": [
|
|
{
|
|
"min_version": "1.0",
|
|
"max_version": "1.10",
|
|
"id": "v1.0"
|
|
}
|
|
]
|
|
}
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, res.code)
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_version_comparison_does_not_use_floats(self, get):
|
|
# NOTE(rpodolyaka): previously _check_placement() coerced the version
|
|
# numbers to floats prior to comparison, that would lead to failures
|
|
# in cases like float('1.10') < float('1.4'). As we require 1.4+ now,
|
|
# the _check_placement() call below will assert that version comparison
|
|
# continues to work correctly when Placement API versions 1.10
|
|
# (or newer) is released
|
|
get.return_value = {
|
|
"versions": [
|
|
{
|
|
"min_version": "1.0",
|
|
"max_version": "1.10",
|
|
"id": "v1.0"
|
|
}
|
|
]
|
|
}
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, res.code)
|
|
|
|
@mock.patch.object(status.UpgradeCommands, "_placement_get")
|
|
def test_invalid_version(self, get):
|
|
get.return_value = {
|
|
"versions": [
|
|
{
|
|
"min_version": "0.9",
|
|
"max_version": "0.9",
|
|
"id": "v1.0"
|
|
}
|
|
]
|
|
}
|
|
res = self.cmd._check_placement()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, res.code)
|
|
self.assertIn('Placement API version 1.10 needed, you have 0.9',
|
|
res.details)
|
|
|
|
|
|
class TestUpgradeCheckBasic(test.NoDBTestCase):
|
|
"""Tests for the nova-status upgrade check command.
|
|
|
|
The tests in this class should just test basic logic and use mock. Real
|
|
checks which require more elaborate fixtures or the database should be done
|
|
in separate test classes as they are more or less specific to a particular
|
|
release and may be removed in a later release after they are no longer
|
|
needed.
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(TestUpgradeCheckBasic, self).setUp()
|
|
self.output = StringIO()
|
|
self.useFixture(fixtures.MonkeyPatch('sys.stdout', self.output))
|
|
self.cmd = status.UpgradeCommands()
|
|
|
|
def test_check_success(self):
|
|
fake_checks = (
|
|
('good', mock.Mock(return_value=status.UpgradeCheckResult(
|
|
status.UpgradeCheckCode.SUCCESS
|
|
))),
|
|
)
|
|
with mock.patch.object(self.cmd, '_upgrade_checks', fake_checks):
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, self.cmd.check())
|
|
expected = """\
|
|
+-----------------------+
|
|
| Upgrade Check Results |
|
|
+-----------------------+
|
|
| Check: good |
|
|
| Result: Success |
|
|
| Details: None |
|
|
+-----------------------+
|
|
"""
|
|
self.assertEqual(expected, self.output.getvalue())
|
|
|
|
def test_check_warning(self):
|
|
fake_checks = (
|
|
('good', mock.Mock(return_value=status.UpgradeCheckResult(
|
|
status.UpgradeCheckCode.SUCCESS
|
|
))),
|
|
('warn', mock.Mock(return_value=status.UpgradeCheckResult(
|
|
status.UpgradeCheckCode.WARNING, 'there might be a problem'
|
|
))),
|
|
)
|
|
with mock.patch.object(self.cmd, '_upgrade_checks', fake_checks):
|
|
self.assertEqual(status.UpgradeCheckCode.WARNING, self.cmd.check())
|
|
expected = """\
|
|
+-----------------------------------+
|
|
| Upgrade Check Results |
|
|
+-----------------------------------+
|
|
| Check: good |
|
|
| Result: Success |
|
|
| Details: None |
|
|
+-----------------------------------+
|
|
| Check: warn |
|
|
| Result: Warning |
|
|
| Details: there might be a problem |
|
|
+-----------------------------------+
|
|
"""
|
|
self.assertEqual(expected, self.output.getvalue())
|
|
|
|
def test_check_failure(self):
|
|
# make the error details over 60 characters so we test the wrapping
|
|
error_details = 'go back to bed' + '!' * 60
|
|
fake_checks = (
|
|
('good', mock.Mock(return_value=status.UpgradeCheckResult(
|
|
status.UpgradeCheckCode.SUCCESS
|
|
))),
|
|
('warn', mock.Mock(return_value=status.UpgradeCheckResult(
|
|
status.UpgradeCheckCode.WARNING, 'there might be a problem'
|
|
))),
|
|
('fail', mock.Mock(return_value=status.UpgradeCheckResult(
|
|
status.UpgradeCheckCode.FAILURE, error_details
|
|
))),
|
|
)
|
|
with mock.patch.object(self.cmd, '_upgrade_checks', fake_checks):
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, self.cmd.check())
|
|
expected = """\
|
|
+-----------------------------------------------------------------------+
|
|
| Upgrade Check Results |
|
|
+-----------------------------------------------------------------------+
|
|
| Check: good |
|
|
| Result: Success |
|
|
| Details: None |
|
|
+-----------------------------------------------------------------------+
|
|
| Check: warn |
|
|
| Result: Warning |
|
|
| Details: there might be a problem |
|
|
+-----------------------------------------------------------------------+
|
|
| Check: fail |
|
|
| Result: Failure |
|
|
| Details: go back to bed!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
|
|
| !!!!!!!!!!!!!! |
|
|
+-----------------------------------------------------------------------+
|
|
"""
|
|
self.assertEqual(expected, self.output.getvalue())
|
|
|
|
|
|
class TestUpgradeCheckCellsV2(test.NoDBTestCase):
|
|
"""Tests for the nova-status upgrade cells v2 specific check."""
|
|
|
|
# We'll setup the API DB fixture ourselves and slowly build up the
|
|
# contents until the check passes.
|
|
USES_DB_SELF = True
|
|
|
|
def setUp(self):
|
|
super(TestUpgradeCheckCellsV2, self).setUp()
|
|
self.output = StringIO()
|
|
self.useFixture(fixtures.MonkeyPatch('sys.stdout', self.output))
|
|
self.useFixture(nova_fixtures.Database(database='api'))
|
|
self.cmd = status.UpgradeCommands()
|
|
|
|
def test_check_no_cell_mappings(self):
|
|
"""The cells v2 check should fail because there are no cell mappings.
|
|
"""
|
|
result = self.cmd._check_cellsv2()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, result.code)
|
|
self.assertIn('There needs to be at least two cell mappings',
|
|
result.details)
|
|
|
|
def _create_cell_mapping(self, uuid):
|
|
cm = objects.CellMapping(
|
|
context=context.get_admin_context(),
|
|
uuid=uuid,
|
|
name=uuid,
|
|
transport_url='fake://%s/' % uuid,
|
|
database_connection=uuid)
|
|
cm.create()
|
|
return cm
|
|
|
|
def test_check_no_cell0_mapping(self):
|
|
"""We'll create two cell mappings but not have cell0 mapped yet."""
|
|
for i in range(2):
|
|
uuid = getattr(uuids, str(i))
|
|
self._create_cell_mapping(uuid)
|
|
|
|
result = self.cmd._check_cellsv2()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, result.code)
|
|
self.assertIn('No cell0 mapping found', result.details)
|
|
|
|
def test_check_no_host_mappings_with_computes(self):
|
|
"""Creates a cell0 and cell1 mapping but no host mappings and there are
|
|
compute nodes in the cell database.
|
|
"""
|
|
self._setup_cells()
|
|
cn = objects.ComputeNode(
|
|
context=context.get_admin_context(),
|
|
host='fake-host',
|
|
vcpus=4,
|
|
memory_mb=8 * 1024,
|
|
local_gb=40,
|
|
vcpus_used=2,
|
|
memory_mb_used=2 * 1024,
|
|
local_gb_used=10,
|
|
hypervisor_type='fake',
|
|
hypervisor_version=1,
|
|
cpu_info='{"arch": "x86_64"}')
|
|
cn.create()
|
|
|
|
result = self.cmd._check_cellsv2()
|
|
self.assertEqual(status.UpgradeCheckCode.FAILURE, result.code)
|
|
self.assertIn('No host mappings found but there are compute nodes',
|
|
result.details)
|
|
|
|
def test_check_no_host_mappings_no_computes(self):
|
|
"""Creates the cell0 and cell1 mappings but no host mappings and no
|
|
compute nodes so it's assumed to be an initial install.
|
|
"""
|
|
self._setup_cells()
|
|
|
|
result = self.cmd._check_cellsv2()
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, result.code)
|
|
self.assertIn('No host mappings or compute nodes were found',
|
|
result.details)
|
|
|
|
def test_check_success(self):
|
|
"""Tests a successful cells v2 upgrade check."""
|
|
# create the cell0 and first cell mappings
|
|
self._setup_cells()
|
|
# Start a compute service and create a hostmapping for it
|
|
svc = self.start_service('compute')
|
|
cell = self.cell_mappings[test.CELL1_NAME]
|
|
hm = objects.HostMapping(context=context.get_admin_context(),
|
|
host=svc.host,
|
|
cell_mapping=cell)
|
|
hm.create()
|
|
|
|
result = self.cmd._check_cellsv2()
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, result.code)
|
|
self.assertIsNone(result.details)
|
|
|
|
|
|
# This is what the ResourceTracker sets up in the nova-compute service.
|
|
FAKE_VCPU_INVENTORY = {
|
|
'resource_class': fields.ResourceClass.VCPU,
|
|
'total': 32,
|
|
'reserved': 4,
|
|
'min_unit': 1,
|
|
'max_unit': 1,
|
|
'step_size': 1,
|
|
'allocation_ratio': 1.0,
|
|
}
|
|
|
|
# This is the kind of thing that Neutron will setup externally for routed
|
|
# networks.
|
|
FAKE_IP_POOL_INVENTORY = {
|
|
'resource_class': fields.ResourceClass.IPV4_ADDRESS,
|
|
'total': 256,
|
|
'reserved': 10,
|
|
'min_unit': 1,
|
|
'max_unit': 1,
|
|
'step_size': 1,
|
|
'allocation_ratio': 1.0,
|
|
}
|
|
|
|
|
|
class TestUpgradeCheckResourceProviders(test.NoDBTestCase):
|
|
"""Tests for the nova-status upgrade check on resource providers."""
|
|
|
|
# We'll setup the database ourselves because we need to use cells fixtures
|
|
# for multiple cell mappings.
|
|
USES_DB_SELF = True
|
|
|
|
def setUp(self):
|
|
super(TestUpgradeCheckResourceProviders, self).setUp()
|
|
self.output = StringIO()
|
|
self.useFixture(fixtures.MonkeyPatch('sys.stdout', self.output))
|
|
# We always need the API DB to be setup.
|
|
self.useFixture(nova_fixtures.Database(database='api'))
|
|
self.cmd = status.UpgradeCommands()
|
|
|
|
def test_check_resource_providers_fresh_install_no_mappings(self):
|
|
"""Tests the scenario where we don't have any cell mappings (no cells
|
|
v2 setup yet) and no compute nodes in the single main database.
|
|
"""
|
|
# We don't have a cell mapping, just the regular old main database
|
|
# because let's assume they haven't run simple_cell_setup yet.
|
|
self.useFixture(nova_fixtures.Database())
|
|
result = self.cmd._check_resource_providers()
|
|
# this is assumed to be base install so it's OK but with details
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, result.code)
|
|
self.assertIn('There are no compute resource providers in the '
|
|
'Placement service nor are there compute nodes in the '
|
|
'database',
|
|
result.details)
|
|
|
|
def test_check_resource_providers_no_rps_no_computes_in_cell1(self):
|
|
"""Tests the scenario where we have a cell mapping with no computes in
|
|
it and no resource providers (because of no computes).
|
|
"""
|
|
# this will setup two cell mappings, one for cell0 and a single cell1
|
|
self._setup_cells()
|
|
# there are no compute nodes in the cell1 database so we have 0
|
|
# resource providers and 0 compute nodes, so it's assumed to be a fresh
|
|
# install and not a failure.
|
|
result = self.cmd._check_resource_providers()
|
|
# this is assumed to be base install so it's OK but with details
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, result.code)
|
|
self.assertIn('There are no compute resource providers in the '
|
|
'Placement service nor are there compute nodes in the '
|
|
'database',
|
|
result.details)
|
|
|
|
def test_check_resource_providers_no_rps_one_compute(self):
|
|
"""Tests the scenario where we have compute nodes in the cell but no
|
|
resource providers yet - VCPU or otherwise. This is a warning because
|
|
the compute isn't reporting into placement.
|
|
"""
|
|
self._setup_cells()
|
|
# create a compute node which will be in cell1 by default
|
|
cn = objects.ComputeNode(
|
|
context=context.get_admin_context(),
|
|
host='fake-host',
|
|
vcpus=4,
|
|
memory_mb=8 * 1024,
|
|
local_gb=40,
|
|
vcpus_used=2,
|
|
memory_mb_used=2 * 1024,
|
|
local_gb_used=10,
|
|
hypervisor_type='fake',
|
|
hypervisor_version=1,
|
|
cpu_info='{"arch": "x86_64"}')
|
|
cn.create()
|
|
result = self.cmd._check_resource_providers()
|
|
self.assertEqual(status.UpgradeCheckCode.WARNING, result.code)
|
|
self.assertIn('There are no compute resource providers in the '
|
|
'Placement service but there are 1 compute nodes in the '
|
|
'deployment.', result.details)
|
|
|
|
def _create_resource_provider(self, inventory):
|
|
"""Helper method to create a resource provider with inventory"""
|
|
ctxt = context.get_admin_context()
|
|
rp_uuid = uuidutils.generate_uuid()
|
|
rp = objects.ResourceProvider(
|
|
context=ctxt,
|
|
name=rp_uuid,
|
|
uuid=rp_uuid)
|
|
rp.create()
|
|
inventory = objects.Inventory(
|
|
context=ctxt,
|
|
resource_provider=rp,
|
|
**inventory)
|
|
inventory.create()
|
|
return rp
|
|
|
|
def test_check_resource_providers_no_compute_rps_one_compute(self):
|
|
"""Tests the scenario where we have compute nodes in the cell but no
|
|
compute (VCPU) resource providers yet. This is a failure warning the
|
|
compute isn't reporting into placement.
|
|
"""
|
|
self._setup_cells()
|
|
# create a compute node which will be in cell1 by default
|
|
cn = objects.ComputeNode(
|
|
context=context.get_admin_context(),
|
|
host='fake-host',
|
|
vcpus=4,
|
|
memory_mb=8 * 1024,
|
|
local_gb=40,
|
|
vcpus_used=2,
|
|
memory_mb_used=2 * 1024,
|
|
local_gb_used=10,
|
|
hypervisor_type='fake',
|
|
hypervisor_version=1,
|
|
cpu_info='{"arch": "x86_64"}')
|
|
cn.create()
|
|
|
|
# create a single resource provider that represents an external shared
|
|
# IP allocation pool - this tests our filtering when counting resource
|
|
# providers
|
|
self._create_resource_provider(FAKE_IP_POOL_INVENTORY)
|
|
|
|
result = self.cmd._check_resource_providers()
|
|
self.assertEqual(status.UpgradeCheckCode.WARNING, result.code)
|
|
self.assertIn('There are no compute resource providers in the '
|
|
'Placement service but there are 1 compute nodes in the '
|
|
'deployment.', result.details)
|
|
|
|
def test_check_resource_providers_fewer_rps_than_computes(self):
|
|
"""Tests the scenario that we have fewer resource providers than
|
|
compute nodes which is a warning because we're underutilized.
|
|
"""
|
|
# setup the cell0 and cell1 mappings
|
|
self._setup_cells()
|
|
|
|
# create two compute nodes (by default in cell1)
|
|
ctxt = context.get_admin_context()
|
|
for x in range(2):
|
|
cn = objects.ComputeNode(
|
|
context=ctxt,
|
|
host=getattr(uuids, str(x)),
|
|
vcpus=4,
|
|
memory_mb=8 * 1024,
|
|
local_gb=40,
|
|
vcpus_used=2,
|
|
memory_mb_used=2 * 1024,
|
|
local_gb_used=10,
|
|
hypervisor_type='fake',
|
|
hypervisor_version=1,
|
|
cpu_info='{"arch": "x86_64"}')
|
|
cn.create()
|
|
|
|
# create a single resource provider with some VCPU inventory
|
|
self._create_resource_provider(FAKE_VCPU_INVENTORY)
|
|
|
|
result = self.cmd._check_resource_providers()
|
|
self.assertEqual(status.UpgradeCheckCode.WARNING, result.code)
|
|
self.assertIn('There are 1 compute resource providers and 2 compute '
|
|
'nodes in the deployment.', result.details)
|
|
|
|
def test_check_resource_providers_equal_rps_to_computes(self):
|
|
"""This tests the happy path scenario where we have an equal number
|
|
of compute resource providers to compute nodes.
|
|
"""
|
|
# setup the cell0 and cell1 mappings
|
|
self._setup_cells()
|
|
|
|
# create a single compute node
|
|
ctxt = context.get_admin_context()
|
|
cn = objects.ComputeNode(
|
|
context=ctxt,
|
|
host=uuids.host,
|
|
vcpus=4,
|
|
memory_mb=8 * 1024,
|
|
local_gb=40,
|
|
vcpus_used=2,
|
|
memory_mb_used=2 * 1024,
|
|
local_gb_used=10,
|
|
hypervisor_type='fake',
|
|
hypervisor_version=1,
|
|
cpu_info='{"arch": "x86_64"}')
|
|
cn.create()
|
|
|
|
# create a deleted compute node record (shouldn't count)
|
|
cn2 = objects.ComputeNode(
|
|
context=ctxt,
|
|
deleted=1,
|
|
host='fakehost',
|
|
vcpus=4,
|
|
memory_mb=8 * 1024,
|
|
local_gb=40,
|
|
vcpus_used=2,
|
|
memory_mb_used=2 * 1024,
|
|
local_gb_used=10,
|
|
hypervisor_type='fake',
|
|
hypervisor_version=1,
|
|
cpu_info='{"arch": "x86_64"}')
|
|
cn2.create()
|
|
|
|
# create a single resource provider with some VCPU inventory
|
|
self._create_resource_provider(FAKE_VCPU_INVENTORY)
|
|
# create an externally shared IP allocation pool resource provider
|
|
self._create_resource_provider(FAKE_IP_POOL_INVENTORY)
|
|
|
|
result = self.cmd._check_resource_providers()
|
|
self.assertEqual(status.UpgradeCheckCode.SUCCESS, result.code)
|
|
self.assertIsNone(result.details)
|