nova/nova/tests/unit
Hiroyuki Eguchi fb0de106f2 Fix connecting unnecessary iSCSI sessions issue
In Icehouse with "iscsi_use_multipath=true", attaching a multipath
iSCSI volume may create unnecessary iSCSI sessions.

The iscsiadm discovery command in connect_volume() returns all of the
targets in the Cinder node, not just the ones related to the multipath
volume which is specified by iqn.  If the storage has many targets,
connecting to all these volumes will also result in many unnecessary
connections.

There are two types of iSCSI multipath devices.  One which shares
the same iqn between multiple portals, and the other which use
different iqns on different portals. connect_volume() needs to
identify the type by checking iscsiadm the output if the iqn is
used by multiple portals.

This patch changes the behavior of attaching volume:

   1. Identify the type by checking the iscsiadm output.
   2. Connect to the correct targets by connect_to_iscsi_portal().

Closes-Bug: #1382440

Change-Id: I488ad0c09bf26a609e27d67b9ef60b65bb45e0ad
2014-11-20 10:42:00 +09:00
..
CA move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
api Merge "Catch NotImplemented nova exceptions in API extension" 2014-11-19 11:00:05 +00:00
bundle move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
cells move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
cert move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
cmd move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
compute Merge "Compute: improve test_compute_utils time" 2014-11-19 23:42:14 +00:00
conductor Refactor more compute tests to use Instance objects 2014-11-17 08:17:48 -08:00
console move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
consoleauth Remove havana compat from nova.consoleauth.rpcapi 2014-11-13 06:32:12 +00:00
db Merge "Remove unused db.api.floating_ip_set_auto_assigned" 2014-11-19 11:00:33 +00:00
fake_loadables move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
functional move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
image move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
integrated Merge "Remove duplicated code in services api integrated test case" 2014-11-17 12:58:49 +00:00
keymgr move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
monkey_patch_example move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
network move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
objects Support instance_extra fields in expected_attrs on Instance object 2014-11-17 07:58:02 -08:00
pci move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
scheduler object-ify flavors api and compute/api side of RPC 2014-11-13 22:18:12 +00:00
servicegroup move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
ssl_cert move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
virt Fix connecting unnecessary iSCSI sessions issue 2014-11-20 10:42:00 +09:00
volume move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
README.rst move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
__init__.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
cast_as_call.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
conf_fixture.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_block_device.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_crypto.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_hosts.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_instance.py Support instance_extra fields in expected_attrs on Instance object 2014-11-17 07:58:02 -08:00
fake_ldap.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_network.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_network_cache_model.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_notifier.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_policy.py Add 'instance-usage-audit-log' plugin for V2.1 2014-11-13 14:38:25 +09:00
fake_processutils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_server_actions.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
fake_volume.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
image_fixtures.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
matchers.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
policy_fixture.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_api_validation.py Add API json schema to volumes api(v2.1) 2014-11-18 14:01:08 +08:00
test_availability_zones.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_baserpc.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_bdm.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_block_device.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_cinder.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_configdrive2.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_context.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_crypto.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_exception.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_flavors.py object-ify flavors api and compute/api side of RPC 2014-11-13 22:18:12 +00:00
test_hacking.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_hooks.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_instance_types_extra_specs.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_iptables_network.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_ipv6.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_linuxscsi.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_loadables.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_matchers.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_metadata.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_notifications.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_nova_manage.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_objectstore.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_pipelib.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_policy.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_quota.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_safeutils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_service.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_test.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_test_utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_versions.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_weights.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
test_wsgi.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00
utils.py move all tests to nova/tests/unit 2014-11-12 15:31:08 -05:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎