OpenStack Compute (Nova)
Go to file
Matt Riedemann fb61e864b9 Fix InstanceNotFound during _destroy_evacuated_instances
The _destroy_evacuated_instances method on compute
startup tries to cleanup guests on the hypervisor and
allocations held against that compute node resource
provider by evacuated instances, but doesn't take into
account that those evacuated instances could have been
deleted in the meantime which leads to a lazy-load
InstanceNotFound error that kills the startup of the
compute service.

This change does two things in the _destroy_evacuated_instances
method:

1. Loads the evacuated instances with a read_deleted='yes'
   context when calling _get_instances_on_driver(). This
   should be fine since _get_instances_on_driver() is already
   returning deleted instances anyway (InstanceList.get_by_filters
   defaults to read deleted instances unless the filters tell
   it otherwise - which we don't in this case). This is needed
   so that things like driver.destroy() don't raise
   InstanceNotFound while lazy-loading fields on the instance.

2. Skips the call to remove_allocation_from_compute() if the
   evacuated instance is already deleted. If the instance is
   already deleted, its allocations should have been cleaned
   up by its hosting compute service (or the API).

The functional regression test is updated to show the bug is
now fixed.

Conflicts:
      nova/compute/manager.py

NOTE(mriedem): The conflict is due to not having change
I1073faca6760bff3da0aaf3e8357bd8e64854be3 in Pike.

Change-Id: I1f4b3540dd453650f94333b36d7504ba164192f7
Closes-Bug: #1794996
(cherry picked from commit 05cd8d1282)
(cherry picked from commit 0208d64397)
(cherry picked from commit 6c7e53e210)
2018-12-06 19:39:34 -05:00
api-guide/source api-ref: Add X-Openstack-Request-Id description 2017-07-10 14:03:14 +00:00
api-ref/source Block deleting compute services which are hosting instances 2018-07-05 16:24:32 -04:00
contrib Merge "changed quantum to neutron in vif-openstack" 2014-03-05 10:45:05 +00:00
devstack Skip test_rebuild_server_in_error_state for cells v1 2017-08-22 18:42:17 +00:00
doc Fix bad links for admin-guide 2018-08-09 02:16:36 +00:00
etc/nova rootwrap.d cleanup mislabeled files 2017-08-01 16:09:18 +10:00
gate move gate hooks to gate/ 2017-01-04 11:05:16 +00:00
nova Fix InstanceNotFound during _destroy_evacuated_instances 2018-12-06 19:39:34 -05:00
placement-api-ref/source [placement] Add api-ref for usages 2017-08-09 15:54:48 +00:00
playbooks/legacy/nova-live-migration Migrate tempest-dsvm-multinode-live-migration job in-tree 2018-05-10 11:14:03 -04:00
plugins/xenserver XenAPI Remove useless files when use os-xenapi lib 2017-01-10 18:06:17 -08:00
releasenotes Revert "libvirt: slow live-migration to ensure network is ready" 2018-08-14 08:31:41 -07:00
tools tools/xenserver: Remove 'cleanup_sm_locks' 2017-08-07 12:26:53 +00:00
.coveragerc Remove nova/openstack/* from .coveragerc 2016-10-12 16:20:49 -04:00
.gitignore Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
.gitreview Update .gitreview for stable/pike 2017-08-11 12:29:20 +00:00
.mailmap Add mailmap entry 2014-05-07 12:14:26 -07:00
.stestr.conf Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
.zuul.yaml Merge "Follow devstack-plugin-ceph job rename" into stable/pike 2018-10-03 01:14:47 +00:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:37 +00:00
HACKING.rst Enable global hacking checks and removed local checks 2017-02-10 15:09:37 +01:00
LICENSE initial commit 2010-05-27 23:05:26 -07:00
MAINTAINERS Add a maintainers file 2015-05-23 03:22:07 +10:00
README.rst doc: Rework README to reflect new doc URLs 2017-08-03 16:06:08 -04:00
babel.cfg Get rid of distutils.extra. 2012-02-08 19:30:39 -08:00
bindep.txt Update bindep.txt for doc builds 2017-11-21 20:09:12 +00:00
requirements.txt Updated from global requirements 2017-08-07 00:49:24 +00:00
setup.cfg Using plain routes for the microversions test 2017-07-23 22:43:53 +08:00
setup.py Updated from global requirements 2017-03-02 11:50:48 +00:00
test-requirements.txt Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00
tests-functional-py3.txt Remove invalid URL in gabbi tests 2017-01-17 21:10:45 +00:00
tests-py3.txt Skip unit tests for SSL + py3 2017-03-02 14:30:16 +08:00
tox.ini Backport tox.ini to switch to stestr 2018-07-05 16:28:04 -04:00

README.rst

Team and repository tags

image

OpenStack Nova

OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), Hyper-V, VMware, XenServer, OpenStack Ironic and PowerVM.

Use the following resources to learn more.

API

To learn how to use Nova's API, consult the documentation available online at:

For more information on OpenStack APIs, SDKs and CLIs in general, refer to:

Operators

To learn how to deploy and configure OpenStack Nova, consult the documentation available online at:

In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at:

Developers

For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst.

Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests.

Further developer focused documentation is available at:

Other Information

During each Summit and Project Team Gathering, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: