Update patch set 1
Patch Set 1: (10 comments) Patch-set: 1
This commit is contained in:
Gerrit User 29244
Gerrit Code Review
parent
3dc82164fd
commit
06403594e1
|
|
@ -34,6 +34,24 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4afef788_442d4fed",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Good point, I think it will be the next step after this feature, and it will have its own specification",
|
||||
"parentUuid": "74b62431_70863f10",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -57,6 +75,30 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1d20c6cd_076b9c92",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 31,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "542c5a2f_4a0f6deb",
|
||||
"range": {
|
||||
"startLine": 31,
|
||||
"startChar": 31,
|
||||
"endLine": 31,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -80,6 +122,30 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "fcb2d2ae_ff042fef",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 38,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Amphora ports are always called VRRP ports regardless of the topology (see https://opendev.org/openstack/octavia/src/commit/5898d54b137f5fb7a1d45bf8d620ef8ab8133259/octavia/db/models.py#L684).\nI can change it to \"Amphora ports\"",
|
||||
"parentUuid": "ab3861cc_a1e61faa",
|
||||
"range": {
|
||||
"startLine": 38,
|
||||
"startChar": 0,
|
||||
"endLine": 38,
|
||||
"endChar": 10
|
||||
},
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -127,6 +193,30 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "da5b838b_7dcbc5fa",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 40,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "9188b956_9f9e7b50",
|
||||
"range": {
|
||||
"startLine": 40,
|
||||
"startChar": 20,
|
||||
"endLine": 40,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -150,6 +240,30 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "9cc62e76_a4a30122",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 44,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "56e223f6_c23c3204",
|
||||
"range": {
|
||||
"startLine": 44,
|
||||
"startChar": 0,
|
||||
"endLine": 44,
|
||||
"endChar": 5
|
||||
},
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -167,6 +281,24 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "030e4343_f9dcd006",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 67,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "54166af8_fcf535ca",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -184,6 +316,24 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "c3194226_0256229e",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 77,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a703d746_c99ecd63",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -201,6 +351,24 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "a8120a63_76ddd137",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "aaf2c79c_d6121fb6",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -218,6 +386,24 @@
|
|||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "701852ef_c67070a1",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 88,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "864331ea_09a96c8d",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -234,6 +420,24 @@
|
|||
"message": "TODO: add support in python-octaviaclient and openstacksdk",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "b7305c8f_7629750c",
|
||||
"filename": "specs/version14.0/custom-security-groups-for-VIP-ports.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 150,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2024-05-15T11:16:08Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "98d03a36_5bfa38df",
|
||||
"revId": "fd8ae2581cb55bdd47889b0d08c77fc68d62876b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue