From ec2caff080c2e10db37fb99000898e895e989512 Mon Sep 17 00:00:00 2001 From: Dmitriy Rabotyagov Date: Mon, 10 Apr 2023 15:29:52 +0200 Subject: [PATCH] Ensure service is restarted on unit file changes At the moment we don't restart services if systemd unit file is changed. We knowingly prevent systemd_service role handlers to execute by providing `state: started` as otherwise service will be restarted twice. With that now we ensure that role handlers will also listen for systemd unit changes. Change-Id: Ic56d5d1bd1ead8fd6bb642913370fa206799256f --- handlers/main.yml | 2 ++ vars/main.yml | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/handlers/main.yml b/handlers/main.yml index 93e6b22..54096d9 100644 --- a/handlers/main.yml +++ b/handlers/main.yml @@ -27,6 +27,7 @@ listen: - "Restart aodh services" - "venv changed" + - "systemd service changed" - name: Start services service: @@ -42,3 +43,4 @@ listen: - "Restart aodh services" - "venv changed" + - "systemd service changed" diff --git a/vars/main.yml b/vars/main.yml index f98f260..04380a5 100644 --- a/vars/main.yml +++ b/vars/main.yml @@ -23,8 +23,8 @@ filtered_aodh_services: |- {% set _ = value.update( { 'service_key': key, - 'enabled': 'yes', - 'state': 'started', + 'enabled': value['enabled'] | default(True), + 'state': value['state'] | default('started'), 'config_overrides': value.init_config_overrides } )