Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: Id39bc800eae6e45ce0d515ed47ab60e26728ff96

defaults/main.yml

@@ -16,9 +16,10 @@
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 aodh_package_state: "latest"
+aodh_pip_package_state: "latest"
 
 ## Toggle developer mode
 aodh_developer_mode: false

handlers/main.yml

@@ -19,8 +19,8 @@
     - Restart aodh services
 
 - name: Reload upstart init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
+  changed_when: false
   notify:
     - Restart aodh services
 

tasks/aodh_db_setup.yml

@@ -17,3 +17,4 @@
   command: "{{ aodh_bin }}/aodh-dbsync"
   become: yes
   become_user: "{{ aodh_system_user_name }}"
+  changed_when: false

tasks/aodh_install.yml

@@ -53,7 +53,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ aodh_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ aodh_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -126,7 +126,7 @@
 - name: Install pip packages
   pip:
     name: "{{ aodh_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ aodh_pip_package_state }}"
     virtualenv: "{{ aodh_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/main.yml

@@ -23,6 +23,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always