From 21e73f7ceef4dd5e58ab7d3359de1d3051adc267 Mon Sep 17 00:00:00 2001 From: Jesse Pretorius Date: Tue, 2 Aug 2016 13:20:47 +0100 Subject: [PATCH] Add ability to change apt/yum package state The current method of installing the distribution packages required is set in the tasks and cannot be changed by a deployer. Currently the apt task always installs the latest package. This results in unexpected binary changes when a deployer may simply be trying to execute a configuration change. This patch adds the ability for a deployer to change the desired state so that the results are predictable. Change-Id: I9cd74e8267e3dc13be143586699b7f88ed099d49 --- defaults/main.yml | 4 ++++ .../notes/package-state-1497c9e2beedaf21.yaml | 13 +++++++++++++ tasks/barbican_install_apt.yml | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/package-state-1497c9e2beedaf21.yaml diff --git a/defaults/main.yml b/defaults/main.yml index 2233f05..2d304cd 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -13,6 +13,10 @@ # See the License for the specific language governing permissions and # limitations under the License. +# Set the package install state for distribution packages +# Options are 'present' and 'latest' +barbican_package_state: "latest" + barbican_system_group_name: barbican barbican_system_user_name: barbican barbican_system_user_comment: Barbican System User diff --git a/releasenotes/notes/package-state-1497c9e2beedaf21.yaml b/releasenotes/notes/package-state-1497c9e2beedaf21.yaml new file mode 100644 index 0000000..c9afc27 --- /dev/null +++ b/releasenotes/notes/package-state-1497c9e2beedaf21.yaml @@ -0,0 +1,13 @@ +--- +features: + - The os_barbican role now supports the ability to configure whether + apt/yum tasks install the latest available package, or just ensure + that the package is present. The default action is to ensure that + the latest package is present. The action taken may be changed to + only ensure that the package is present by setting + ``barbican_package_state`` to ``present``. +upgrade: + - The os_barbican role always checks whether the latest package is + installed when executed. If a deployer wishes to change the check to + only validate the presence of the package, the option + ``barbican_package_state`` should be set to ``present``. diff --git a/tasks/barbican_install_apt.yml b/tasks/barbican_install_apt.yml index 7ece817..e030915 100644 --- a/tasks/barbican_install_apt.yml +++ b/tasks/barbican_install_apt.yml @@ -24,7 +24,7 @@ - name: Install apt packages for Barbican apt: pkg: "{{ item }}" - state: "latest" + state: "{{ barbican_package_state }}" register: install_barbican_apt_packages until: install_barbican_apt_packages |success retries: 5