Test using integrated build

In order to do a more complete verification of any patches,
we add a full uncontainerised OpenStack deployment to do the
functional testing using the integrated repo. This replaces
the previous functional test mechanism.

Any additional role tests are left as-is. They will require
some extra implementation in the integrated build before they
can be transferred.

In addition, policy-in-code is a thing in Ironic now so there
is no need to use a template-ized file.

Depends-On: https://review.openstack.org/647840
Depends-On: https://review.openstack.org/648502
Depends-On: https://review.openstack.org/648551
Depends-On: https://review.openstack.org/648575
Change-Id: I31747ea9273c435a3856c4fc277a2a25814c5b02

tasks/ironic_post_install.yml

@@ -103,12 +103,15 @@
       group: "root"
       config_overrides: "{{ ironic_rootwrap_conf_overrides }}"
       config_type: "ini"
-    - src: "policy.json.j2"
-      dest: "/etc/ironic/policy.json"
-      config_overrides: "{{ ironic_policy_overrides }}"
-      config_type: "json"
   notify: Restart ironic services
 
+- name: Implement policy.json
+  copy:
+    content: "{{ ironic_policy_overrides | to_nice_json }}"
+    dest: "/etc/ironic/policy.json"
+  when:
+    - ironic_policy_overrides != {}
+
 - name: Copy rootwrap filters
   copy:
     src: "{{ item }}"

templates/policy.json.j2

@@ -1,5 +0,0 @@
-# Beginning with the Newton release, you may leave this file empty
-# to use default policy defined in code.
-{
-
-}

zuul.d/jobs.yaml

@@ -0,0 +1,37 @@
+---
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- job:
+    name: openstack-ansible-deploy-aio_metal_ironic-centos-7
+    parent: openstack-ansible-deploy-aio
+    nodeset: centos-7
+    vars:
+      action: deploy
+      scenario: aio_metal_ironic
+
+- job:
+    name: openstack-ansible-deploy-aio_metal_ironic-opensuse-150
+    parent: openstack-ansible-deploy-aio
+    nodeset: opensuse-150
+    vars:
+      action: deploy
+      scenario: aio_metal_ironic
+
+- job:
+    name: openstack-ansible-deploy-aio_metal_ironic-ubuntu-bionic
+    parent: openstack-ansible-deploy-aio
+    nodeset: ubuntu-bionic
+    vars:
+      action: deploy
+      scenario: aio_metal_ironic

zuul.d/project.yaml

@@ -15,18 +15,16 @@
 - project:
     templates:
       - check-requirements
+      - openstack-ansible-linters
       - publish-openstack-docs-pti
       - release-notes-jobs-python3
     check:
       jobs:
-        - openstack-ansible-linters
-        - openstack-ansible-functional-ubuntu-xenial
-        - openstack-ansible-functional-ubuntu-bionic
-    experimental:
-      jobs:
-        - openstack-ansible-integrated-deploy-aio
+        - openstack-ansible-deploy-aio_metal_ironic-ubuntu-bionic
     gate:
       jobs:
-        - openstack-ansible-linters
-        - openstack-ansible-functional-ubuntu-xenial
-        - openstack-ansible-functional-ubuntu-bionic
+        - openstack-ansible-deploy-aio_metal_ironic-ubuntu-bionic
+    experimental:
+      jobs:
+        - openstack-ansible-deploy-aio_metal_ironic-centos-7
+        - openstack-ansible-deploy-aio_metal_ironic-opensuse-150