openstack
/
openstack-ansible-os_keystone
Code Issues Proposed changes

removed duplicate key 

In review of this role it was discovered that we had a duplicate
key within a task. While this is acceptable in Ansible as it will
just use the last key found in a given task it is wrong and should
be removed. In later version of Ansible (2.1.0) a warning is printed
stating something similar to the following:

   [WARNING]: While constructing a mapping from xxx.yml, line xx,
     column xx, found a duplicate dict key (changed_when).  Using
     last defined value only. [WARNING]: While constructing a mapping
     from xxx.yml, line xx, column xx, found a duplicate dict key
     (changed_when).  Using last defined value only.

This chage cleans up the role by removing the duplication.

Change-Id: I0afe46a767683350ec5f737ae273b2b2aa060d65
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-03-31 01:08:00 -05:00
parent 99b13a14e5
commit 42998dfa4c
No known key found for this signature in database
GPG Key ID: 69FEFFC5E2D9273F
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/main.yml
View File

@ -67,7 +67,6 @@
- keystone-ldap
- include: keystone_federation_sp_idp_setup.yml
when:
when:
- keystone_service_setup | bool
- keystone_sp is defined