From 7000bc3f3f401c1f3557d074bae197513c977464 Mon Sep 17 00:00:00 2001 From: Damian Dabrowski Date: Tue, 11 Jul 2023 21:35:41 +0200 Subject: [PATCH] Deprecate nova_ram_weight_multiplier Long time ago a variable `nova_ram_weight_multiplier` was implemented and its default value was set to 5.0. There are 2 issues with this: 1. Default value in nova is 1.0 [1] so our value is much bigger than nova's default without having a strong reason for that. 2. OSA does not provide similar variables for other multipliers like `cpu_weight_multiplier`. Because there are a couple of different multipliers and more of them can be implemented in the future(for ex. `hypervisor_version_weight_multiplier` was implemented in 2023.2) it would be hard for the OSA project to maintain variables for all of them. It is better to deprecate `nova_ram_weight_multiplier` and let users define multipliers with `nova_nova_conf_overrides` if necessary. [1] https://docs.openstack.org/nova/2023.1/configuration/config.html#filter_scheduler.ram_weight_multiplier Change-Id: I4f82840e94312d38696e3ddd05ef494821233f4d --- defaults/main.yml | 1 - ...am_weight_multiplier_deprecation-1b152707b4737b3c.yaml | 8 ++++++++ templates/nova.conf.j2 | 1 - 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/nova_ram_weight_multiplier_deprecation-1b152707b4737b3c.yaml diff --git a/defaults/main.yml b/defaults/main.yml index f7596a30..ef71393a 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -317,7 +317,6 @@ nova_cpu_allocation_ratio: 2.0 nova_disk_allocation_ratio: 1.0 nova_max_io_ops_per_host: 10 nova_ram_allocation_ratio: 1.0 -nova_ram_weight_multiplier: 5.0 nova_reserved_host_disk_mb: 2048 nova_scheduler_host_subset_size: "{{ ((((groups['compute_hosts'] | default([]) | length) * 0.3) | round | int, 10) | min, 1) | max }}" diff --git a/releasenotes/notes/nova_ram_weight_multiplier_deprecation-1b152707b4737b3c.yaml b/releasenotes/notes/nova_ram_weight_multiplier_deprecation-1b152707b4737b3c.yaml new file mode 100644 index 00000000..7326fddd --- /dev/null +++ b/releasenotes/notes/nova_ram_weight_multiplier_deprecation-1b152707b4737b3c.yaml @@ -0,0 +1,8 @@ +--- +deprecations: + - | + ``nova_ram_weight_multiplier`` was deprecated. Multipliers should be + defined using ``nova_nova_conf_overrides``. + Please note that default value for ``nova_ram_weight_multiplier`` was + previously set to 5, while nova default is 1. This deprecation will + slightly change weighing behavior in OSA. diff --git a/templates/nova.conf.j2 b/templates/nova.conf.j2 index b37b982d..b38a113a 100644 --- a/templates/nova.conf.j2 +++ b/templates/nova.conf.j2 @@ -325,7 +325,6 @@ discover_hosts_in_cells_interval = {{ nova_discover_hosts_in_cells_interval }} [filter_scheduler] max_io_ops_per_host = {{ nova_max_io_ops_per_host }} -ram_weight_multiplier = {{ nova_ram_weight_multiplier }} enabled_filters = {{ _nova_scheduler_filters | join(',') }} host_subset_size = {{ nova_scheduler_host_subset_size }} track_instance_changes = {{ nova_scheduler_tracks_instance_changes }}