Never fail for result generation tasks

The results generation should never fail the
execution of the role as the tasks are a value
add, rather than a necessary requirement.

Also, generate the results files in the log
folder instead of creating them and then
copying them.

Change-Id: I0bcda58c93680a48a618f5448a613272803c50cf

tasks/tempest_run.yml

@@ -31,29 +31,25 @@
   - name: Generate raw subunit results
     shell: |
       . {{ tempest_venv_bin }}/activate
-      testr last --subunit > tempest_results.subunit
+      testr last --subunit > {{ tempest_log_dir }}/testrepository.subunit
     args:
       chdir: "{{ tempest_venv_bin | dirname }}/workspace"
       executable: /bin/bash
     changed_when: false
+    failed_when: false
     tags:
       # don't trigger ANSIBLE0013
       - skip_ansible_lint
 
-  - name: Copy raw subunit to log folder
-    copy:
-      src: "{{ tempest_venv_bin | dirname }}/workspace/tempest_results.subunit"
-      dest: "{{ tempest_log_dir }}/testrepository.subunit"
-      remote_src: True
-
   - name: Generate xml subunit results
     shell: |
       . {{ tempest_venv_bin }}/activate
-      subunit2junitxml tempest_results.subunit > tempest_results.xml
+      subunit2junitxml {{ tempest_log_dir }}/testrepository.subunit > {{ tempest_log_dir }}/tempest_results.xml
     args:
       chdir: "{{ tempest_venv_bin | dirname }}/workspace"
       executable: /bin/bash
     changed_when: false
+    failed_when: false
     tags:
       # don't trigger ANSIBLE0013
       - skip_ansible_lint
@@ -61,24 +57,16 @@
   - name: Generate html subunit results
     shell: |
       . {{ tempest_venv_bin }}/activate
-      subunit2html tempest_results.subunit tempest_results.html
+      subunit2html {{ tempest_log_dir }}/testrepository.subunit {{ tempest_log_dir }}/tempest_results.html
     args:
       chdir: "{{ tempest_venv_bin | dirname }}/workspace"
       executable: /bin/bash
     changed_when: false
+    failed_when: false
     tags:
       # don't trigger ANSIBLE0013
       - skip_ansible_lint
 
-  - name: Copy other results to log folder
-    copy:
-      src: "{{ tempest_venv_bin | dirname }}/workspace/{{ item }}"
-      dest: "{{ tempest_log_dir }}/"
-      remote_src: True
-    with_items:
-      - "tempest_results.xml"
-      - "tempest_results.html"
-
 - name: Fail if tempest tests did not succeed
   assert:
     that:

tests/test-tempest-functional.yml

@@ -30,17 +30,17 @@
       with_items: "{{ tempest_plugins }}"
 
     - name: List the contents of the tempest_result_path folder
-      command: "ls -1 {{ tempest_venv_bin | dirname }}/workspace/"
+      command: "ls -1 {{ tempest_log_dir }}/"
       register: _results_list
 
     - name: Check whether the expected subunit result files are present
       assert:
         that: "item in _results_list.stdout_lines"
-        msg: "{{ item }} must be present in {{ tempest_venv_bin | dirname }}/workspace/"
+        msg: "{{ item }} must be present in {{ tempest_log_dir }}"
       with_items:
         - "tempest_results.html"
-        - "tempest_results.subunit"
         - "tempest_results.xml"
+        - "testrepository.subunit"
 
   vars_files:
     - common/test-vars.yml