Install rabbitmq from external_repo for all distros

This unifies the way of rabbitmq installation across all distros.
Also includes reno for deprecation of file installation method.

Change-Id: Idcf2d298e2808ef7b1a2160fc94cd6c1b5929182

defaults/main.yml

@@ -45,11 +45,10 @@ rabbitmq_upgrade: false
 #  upgrade/version state can be ignored by setting `rabbitmq_ignore_version_state=true`
 rabbitmq_ignore_version_state: false
 
-rabbitmq_package_url: "{{ _rabbitmq_package_url }}"
+rabbitmq_package_url: ""
 rabbitmq_package_version: "{{ _rabbitmq_package_version }}"
-rabbitmq_release_version: "{{ _rabbitmq_release_version }}"
-rabbitmq_package_sha256: "{{ _rabbitmq_package_sha256 }}"
-rabbitmq_package_path: "{{ _rabbitmq_package_path }}"
+rabbitmq_package_sha256: ""
+rabbitmq_package_path: ""
 
 # Set the gpg keys needed to be imported
 # This should be a list of dicts, with each dict

releasenotes/notes/rabbit_install_method-b1defcd376f3bf87.yaml

@@ -0,0 +1,13 @@
+---
+deprecations:
+  - |
+    `rabbitmq_install_method: file` is deprecated now and will be removed in
+    the Wallaby release. As for now supported options are only `external_repo`
+    and `distro`. Among with that the following variables are deprecated and
+    prepared for the removal:
+
+    * rabbitmq_package_url
+    * rabbitmq_package_sha256
+    * rabbitmq_package_path
+
+    Variable `rabbitmq_release_version` has been removed as not used anymore.

tasks/install_apt.yml

@@ -25,6 +25,9 @@
       - package: "erlang*"
         version: "{{ rabbitmq_erlang_version_spec }}"
         priority: 1000
+      - package: "rabbitmq-server"
+        version: "{{ rabbitmq_package_version }}"
+        priority: 1000
 
 - name: Install GPG keys
   apt_key:

vars/debian.yml

@@ -13,12 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-_rabbitmq_install_method: file
-_rabbitmq_package_url: "https://packagecloud.io/rabbitmq/rabbitmq-server/packages/{{ ansible_distribution | lower }}/{{ ansible_distribution_release | lower }}/rabbitmq-server_3.8.3-1_all.deb/download.deb"
-_rabbitmq_package_version: "{{ rabbitmq_package_url.split('/')[-2].split('_')[1] }}"
-_rabbitmq_release_version: "{{ rabbitmq_package_version.split('-')[0] }}"
-_rabbitmq_package_sha256: "3958385f00fef320cce899793e692ccaa86736494d765e3feb6be8c246fa60bd"
-_rabbitmq_package_path: "/opt/rabbitmq-server.deb"
+_rabbitmq_install_method: external_repo
+_rabbitmq_package_version: "3.8.3-1"
 
 _rabbitmq_gpg_keys:
   - file: gpg/4D206F89
@@ -36,14 +32,19 @@ _rabbitmq_erlang_repo:
   state: "present"
   filename: els_erlang
 
-_rabbitmq_erlang_version_spec: "1:22.*"
+_rabbitmq_erlang_version_spec: "{{ (rabbitmq_install_method == 'external_repo') | ternary('22.3-1', '1:22.*') }}"
 
-rabbitmq_dependencies:
+_rabbitmq_distro_dependencies:
   - "{{ (ansible_architecture == 'aarch64') | ternary('erlang-base', 'erlang-base-hipe') }}"
   - erlang-diameter
   - erlang-eldap
   - erlang-nox
   - socat
 
+_rabbitmq_external_dependencies:
+  - erlang
+
+rabbitmq_dependencies: "{{ (rabbitmq_install_method == 'external_repo') | ternary(_rabbitmq_external_dependencies, _rabbitmq_distro_dependencies) }}"
+
 rabbitmq_distro_packages:
   - rabbitmq-server

vars/redhat.yml

@@ -14,10 +14,7 @@
 # limitations under the License.
 
 _rabbitmq_install_method: external_repo
-
 _rabbitmq_package_version: 3.8.3-1
-_rabbitmq_release_version: "{{ rabbitmq_package_version.split('-')[0] }}"
-
 
 _rabbitmq_repo_url: "https://packagecloud.io/rabbitmq/rabbitmq-server/el/{{ ansible_distribution_major_version }}/$basearch"
 _rabbitmq_repo:

vars/suse.yml

@@ -32,7 +32,6 @@ _rabbitmq_erlang_repo:
 # https://packagecloud.io/rabbitmq/rabbitmq-server/packages/opensuse/15.1/rabbitmq-server-3.8.3-1.suse.noarch.rpm
 # https://download.opensuse.org/repositories/network:/messaging:/amqp/openSUSE_Leap_15.1/x86_64/
 _rabbitmq_package_version: 3.8.2-1
-_rabbitmq_release_version: "{{ rabbitmq_package_version }}"
 
 rabbitmq_distro_packages:
   - erlang