From 8b4b21b231d8b35b7ea0cc721b1aca7ad76adbd3 Mon Sep 17 00:00:00 2001 From: Erik Berg Date: Thu, 12 Mar 2020 20:27:21 +0100 Subject: [PATCH] repo_build: Do not sync links directory between repo_containers The links directory is only used by repo_build when creating requirement wheels. The repo_build process builds wheels for it's own distro/arch combo in serial. So in a mixed environment, where you might have ubuntu-16.04-x86_64 and ubuntu-18.04-x86_64 repo_containers, heck even centos-7-x86_64 for that matter, copying the links pointing to pools/distro-arch over to another repo_container creating wheels for a different distro/arch leads to bad builds getting deployed later. We also need to prevent the later lsync config from spreading these out https://review.opendev.org/#/c/705390/ We can prevent this mix-up from happening even further by setting repo_build_global_links_path: "{{ repo_build_base_path }}/links/{{ repo_build_os_distro_version }}" as suggested in https://review.opendev.org/#/c/708115/ This is probably only relevant for stable/rocky. Depends-On: Ieca6ec9bf898432c76c019a1d2d97c280cd85dce Change-Id: I3bd6d3d987e32ee11c5f1fcb5c1b4b0fc797e7f9 (cherry picked from commit 4bd52916e724046ca3b138e55b443d730547c0b6) --- tasks/repo_package_sync.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/tasks/repo_package_sync.yml b/tasks/repo_package_sync.yml index 1b9b6fc..84ff1ce 100644 --- a/tasks/repo_package_sync.yml +++ b/tasks/repo_package_sync.yml @@ -25,8 +25,6 @@ {{ item.src }} {{ repo_build_service_user_name }}@{{ hostvars[groups['repo_all'][0]]['ansible_host'] }}:{{ item.dest }} with_items: - - src: "{{ repo_build_global_links_path }}" - dest: "{{ repo_build_base_path }}" - src: "{{ repo_build_release_path }}" dest: "{{ repo_build_base_path }}/{{ repo_build_release_version_path }}" - src: "{{ repo_build_pool_dir }}"