Drop tests that rely on the presence of a pidfile

The use of pidfiles seems to be one which causes much debate [1] and
debain buster no longer creates a pidfile for rsyslog so the tests
in this role which rely on it are broken.

Given that systemd now knows the process pid and more distros are
likley to drop the use of the pidfile, and also that the rsyslog
functionality in OSA is largely replaced with systemd journal
remote forwarding, we can remove these tests that break without a
pidfile.

[1] https://github.com/rsyslog/rsyslog-pkg-ubuntu/issues/79

Change-Id: Ia2be525c75fb8bbc549cbc3aa53b3c0db05002fa

tests/test.yml

@@ -36,25 +36,3 @@
         that:
           - "'template(name=\"DDF' in (rsyslog_conf.content | b64decode)"
           - "os_aggregate_storage.stat.exists"
-    - name: Stat rsyslog pid file
-      stat:
-        path: /var/run/{{rsyslog_pid_name}}
-      register: stat_rsyslog_pid
-    - name: Stat /etc/rsyslog.d/50-default.conf
-      stat:
-        path: /etc/rsyslog.d/50-default.conf
-      register: stat_50_default_conf
-    - name: Stat /etc/rsyslog.conf
-      stat:
-        path: /etc/rsyslog.conf
-      register: stat_rsyslog_conf
-    - name: Ensure configuration changed have been applied (rsyslog conf test)
-      assert:
-        that:
-          - "stat_rsyslog_pid.stat.mtime > stat_rsyslog_conf.stat.mtime"
-        msg: "/etc/rsyslog.conf was updated without restarting rsyslogd. Configuration changes have not been applied."
-    - name: Ensuring configuration changes have been applied (default conf test)
-      assert:
-        that:
-          - "stat_rsyslog_pid.stat.mtime > stat_50_default_conf.stat.mtime"
-        msg: "/etc/rsyslog.d/50-default.conf was updated without restarting rsyslogd. Configuration changes have not been applied."