openstack
/
openstack-ansible-rsyslog_server
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(5 comments)

Patch-set: 2
This commit is contained in:
Gerrit User 20038 2016-02-01 19:02:01 +00:00 committed by Gerrit Code Review
parent ff64e05531
commit 798328840d
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
086785d96aead148fffb7ecd6af5778a10097de6
View File

@ -70,6 +70,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_b68a7462",
"filename": "tasks/rsyslog_server_install.yml",
"patchSetId": 2
},
"lineNbr": 19,
"author": {
"id": 20038
},
"writtenOn": "2016-02-01T19:02:01Z",
"side": 1,
"message": "With your other suggestions, we may be able to do away with this check.",
"parentUuid": "7a5de9d1_48bd9fd6",
"revId": "086785d96aead148fffb7ecd6af5778a10097de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_88acf78c",
@ -87,6 +105,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_b614b4e8",
"filename": "tasks/rsyslog_server_install.yml",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 20038
},
"writtenOn": "2016-02-01T19:02:01Z",
"side": 1,
"message": "I like your suggestion here, but there is some debate around having lots of different files to maintain, and that it might be harder to maintain several files instead of just maintaining one larger one.",
"parentUuid": "7a5de9d1_88acf78c",
"revId": "086785d96aead148fffb7ecd6af5778a10097de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_88571725",
@ -104,6 +140,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_0b980169",
"filename": "tasks/rsyslog_server_install.yml",
"patchSetId": 2
},
"lineNbr": 69,
"author": {
"id": 20038
},
"writtenOn": "2016-02-01T19:02:01Z",
"side": 1,
"message": "This does not enable to you set custom repos, and the yumrepo module isn\u0027t available until 2.0 (or 2.1, not sure which).",
"parentUuid": "7a5de9d1_88571725",
"revId": "086785d96aead148fffb7ecd6af5778a10097de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_88a95726",
@ -121,6 +175,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_0bafa17d",
"filename": "tasks/rsyslog_server_install.yml",
"patchSetId": 2
},
"lineNbr": 70,
"author": {
"id": 20038
},
"writtenOn": "2016-02-01T19:02:01Z",
"side": 1,
"message": "It is indeed missing! WIP, I intend to add it in the next commit, didn\u0027t want to spend too much time on this yet.",
"parentUuid": "7a5de9d1_88a95726",
"revId": "086785d96aead148fffb7ecd6af5778a10097de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_4734b348",
@ -155,6 +227,24 @@
"revId": "086785d96aead148fffb7ecd6af5778a10097de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a5de9d1_96f17897",
"filename": "tasks/rsyslog_server_pre_install.yml",
"patchSetId": 2
},
"lineNbr": 26,
"author": {
"id": 20038
},
"writtenOn": "2016-02-01T19:02:01Z",
"side": 1,
"message": "This particular step assumes a syslog user exists. This user is not created in RPM distros. It is not intended to fail the role, just only be included in the relevant distros.",
"parentUuid": "7a5de9d1_08e7a7ac",
"revId": "086785d96aead148fffb7ecd6af5778a10097de6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}