Update patch set 3

Patch Set 3: Code-Review-2

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-2, 86d17b4237aee31728c1a759ed1f79562f82211d
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
Gerrit User 13252 2024-02-20 07:27:05 +00:00 committed by Gerrit Code Review
parent 3535c337cb
commit 354c913155
2 changed files with 59 additions and 0 deletions

View File

@ -34,6 +34,24 @@
"parentUuid": "eff653c0_f9e5db4b",
"revId": "93968896a8aec3c0b21e59c2e19236fb1d9d0a58",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "669ea88b_9b5fbe35",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2024-02-20T07:27:05Z",
"side": 1,
"message": "if you add another commit, no matter what it touches, it moves HEAD and thus previous HEAD^1 will now be HEAD^2\n\nalso we don\u0027t update READMEs for other old retired repos, so I don\u0027t think that it will be needed here, either",
"parentUuid": "938adf6f_7417a076",
"revId": "93968896a8aec3c0b21e59c2e19236fb1d9d0a58",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "0bf601fc_aefc7fa0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2024-02-20T07:27:05Z",
"side": 1,
"message": "I still think that this should not be done",
"revId": "9a033e1451b56be5848c2696980d72300fe9c513",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -22,6 +39,30 @@
},
"revId": "9a033e1451b56be5848c2696980d72300fe9c513",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "797cc0c7_16471880",
"filename": "README.rst",
"patchSetId": 3
},
"lineNbr": 6,
"author": {
"id": 13252
},
"writtenOn": "2024-02-20T07:27:05Z",
"side": 1,
"message": "yes, it still would have to and then the wording also doesn\u0027t match and things get complicated",
"parentUuid": "801dcb6d_d17ec33a",
"range": {
"startLine": 6,
"startChar": 40,
"endLine": 6,
"endChar": 41
},
"revId": "9a033e1451b56be5848c2696980d72300fe9c513",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}