From 8625096bce3fbc62baf4f60b358210672d79d9c7 Mon Sep 17 00:00:00 2001 From: Nguyen Hung Phuong Date: Wed, 21 Feb 2018 13:37:26 +0700 Subject: [PATCH] Clean imports in code In some part in the code we import objects. In the Openstack style guidelines they recommend to import only modules. [1]: "Do not import objects, only modules". [1] https://docs.openstack.org/hacking/0.10.3/ Change-Id: I49452e41f9674e6ebfcc1577d59d21750e957677 --- sitemap/generator/spiders/sitemap_file.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sitemap/generator/spiders/sitemap_file.py b/sitemap/generator/spiders/sitemap_file.py index 6da95640..fa21266f 100644 --- a/sitemap/generator/spiders/sitemap_file.py +++ b/sitemap/generator/spiders/sitemap_file.py @@ -18,7 +18,7 @@ except ImportError: import urllib.parse as urlparse from scrapy import item -from scrapy.linkextractors import LinkExtractor +from scrapy import linkextractors from scrapy import spiders @@ -43,7 +43,7 @@ class SitemapSpider(spiders.CrawlSpider): rules = [ spiders.Rule( - LinkExtractor( + linkextractors.LinkExtractor( allow=[ r'.*\.html', r'.*\.pdf',