openstack
/
openstack-health
Code Issues Proposed changes

Update angular-ui-bootstrap 

This updates angular-ui-bootstrap to the latest version. Among other
fixes, this corrects some odd display behavior when showing the period
selection popover, and allows us to enable dismiss-on-outside-click
functionality.

Note that as of 1.0.0, directives from angular-ui-bootstrap are
prefixed with 'uib-'. The dropdowns in the crumb menu have been
updated to account for this.

Change-Id: I04ff7d057ca881295c23b50eb277a60add384fbd
This commit is contained in:
Tim Buckley 2016-03-14 14:12:41 -06:00
parent b67003a8fe
commit 1b68b36ccf
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/views/crumb-menu.html
View File

@ -1,12 +1,12 @@
<nav class="navbar-breadcrumb navbar navbar-default">
<ul class="nav navbar-nav navbar-left nav-breadcrumb">
<li><a ui-sref="home"><fa name="home"></fa></a></li>
<li dropdown>
<li uib-dropdown>
<span ng-switch on="'tests' | isState">
<a ng-switch-when="true" dropdown-toggle href>
<a ng-switch-when="true" uib-dropdown-toggle href>
Tests <fa name="caret-down"></fa>
</a>
<a ng-switch-default dropdown-toggle href>
<a ng-switch-default uib-dropdown-toggle href>
Overview <fa name="caret-down"></fa>
</a>
</span>
@ -23,18 +23,19 @@
</ul>
<div class="container-fluid">
<ul class="nav navbar-nav navbar-right">
<li dropdown ng-if="showPeriod == 'true'">
<a popover-template="'crumb-period-popover.html'"
<li uib-popover ng-if="showPeriod == 'true'">
<a uib-popover-template="'crumb-period-popover.html'"
popover-placement="bottom"
popover-animation="false"
popover-trigger="outsideClick"
href>
<fa name="calendar"></fa>
&nbsp;Period: {{duration.humanize()}}&nbsp;
<fa name="caret-down"></fa>
</a>
</li>
<li dropdown ng-if="showGroupKey == 'true'">
<a dropdown-toggle href title="Group By Key">
<li uib-dropdown ng-if="showGroupKey == 'true'">
<a uib-dropdown-toggle href title="Group By Key">
<fa name="key"></fa>
&nbsp;Grouping: {{selectedGroupKey}}&nbsp;
<fa name="caret-down"></fa>
@ -50,8 +51,8 @@
</li>
</ul>
</li>
<li dropdown ng-if="showResolution == 'true'">
<a dropdown-toggle href title="Resolution">
<li uib-dropdown ng-if="showResolution == 'true'">
<a uib-dropdown-toggle href title="Resolution">
<fa name="expand"></fa>
&nbsp;Resolution: {{selectedResolution.key}}&nbsp;
<fa name="caret-down"></fa>

2
package.json
View File

@ -9,7 +9,7 @@
"angular": "^1.5.0",
"angular-fontawesome": "^0.4.0",
"angular-mocks": "^1.5.0",
"angular-ui-bootstrap": "^0.13.3",
"angular-ui-bootstrap": "^1.2.3",
"angular-ui-router": ">=0.2.16 <0.3.0",
"babelify": "^5.0.4",
"bootstrap": "^3.3.5",