From 21eca6c9bb9225f27ad20c20017d8bb61b53c432 Mon Sep 17 00:00:00 2001 From: Masayuki Igawa Date: Tue, 19 Jan 2016 12:14:51 +0900 Subject: [PATCH] Fix sorting order on home page This commit fixes the sorting order on the home page. We should have a floating point value rounded to 4 digits after the decimal point at least. For example, 0.3333 would be 33% with the original rounding. However, this is not enough resolution for the home page. This should be 33.33% at least. Closes-Bug: #1522200 Change-Id: I2e57fce318256fcd6e9aee892706d21d5269b81c --- app/js/services/metrics.js | 2 +- test/unit/services/metrics_spec.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/js/services/metrics.js b/app/js/services/metrics.js index 8c798887..5156481b 100644 --- a/app/js/services/metrics.js +++ b/app/js/services/metrics.js @@ -15,7 +15,7 @@ var metricsService = function() { service.getFailRate = function(metrics) { var failRate = metrics.failures / (metrics.passes + metrics.failures) || 0; - return Math.round(failRate * 100) / 100; + return Math.round(failRate * 10000) / 10000; }; service.addMetrics = function(metrics1, metrics2) { diff --git a/test/unit/services/metrics_spec.js b/test/unit/services/metrics_spec.js index 8f8d50e9..e6b14a30 100644 --- a/test/unit/services/metrics_spec.js +++ b/test/unit/services/metrics_spec.js @@ -22,8 +22,8 @@ describe('MetricService', function() { var objects = [ { metrics: { passes: 0, failures: 0 }, expectedFailRate: 0 }, { metrics: { passes: 0, failures: 1 }, expectedFailRate: 1 }, - { metrics: { passes: 2, failures: 1 }, expectedFailRate: 0.33 }, - { metrics: { passes: 1, failures: 2 }, expectedFailRate: 0.67 }, + { metrics: { passes: 2, failures: 1 }, expectedFailRate: 0.3333 }, + { metrics: { passes: 1, failures: 2 }, expectedFailRate: 0.6667 }, { metrics: { passes: 1, failures: 3 }, expectedFailRate: 0.75 } ];