From 01d82d7544fe690ee698302c19fabf20385c5929 Mon Sep 17 00:00:00 2001
From: Steve Baker <sbaker@redhat.com>
Date: Tue, 22 Mar 2022 14:14:52 +1300
Subject: [PATCH] Explicitly support only centos-7 on the bmc host

This change removes the pre-built image support and explicitly
installs for centos-7 base images. There are likely no pre-built image
deployments in the wild, they all appear to use a base centos-7 image
(this includes the bmc-template image used in RDO CI).

This change is the first in a series to upgrade the BMC host to CentOS
versions 8 and 9-stream.

Change-Id: I136b16528b722a6d38235ffcd571f3591d29e679
---
 bin/install_openstackbmc.sh | 36 ++++++++----------------------------
 1 file changed, 8 insertions(+), 28 deletions(-)

diff --git a/bin/install_openstackbmc.sh b/bin/install_openstackbmc.sh
index b3cb2e0..49b979a 100644
--- a/bin/install_openstackbmc.sh
+++ b/bin/install_openstackbmc.sh
@@ -1,40 +1,20 @@
 #!/bin/bash
 set -x
 
-# Also python-crypto, but that requires special handling because we used to
-# install python2-crypto from EPEL
-# python-[nova|neutron]client are in a similar situation.  They were renamed
-# in RDO to python2-*
-required_packages="python-pip os-net-config git jq python2-os-client-config python2-openstackclient"
+centos_ver=$(rpm --eval %{centos_ver})
 
-function have_packages() {
-    for i in $required_packages; do
-        if ! rpm -qa | grep -q $i; then
-            return 1
-        fi
-    done
-    if ! (rpm -qa | egrep -q "python-crypto|python2-crypto"); then
-        return 1
-    fi
-    if ! (rpm -qa | egrep -q "python-novaclient|python2-novaclient"); then
-        return 1
-    fi
-    if ! (rpm -qa | egrep -q "python-neutronclient|python2-neutronclient"); then
-        return 1
-    fi
-    if ! pip freeze | grep -q pyghmi; then
-        return 1
-    fi
-    return 0
-}
-
-if ! have_packages; then
+if [ "$centos_ver" == "7" ] ; then
     yum install -y wget
     wget -r --no-parent -nd -e robots=off -l 1 -A 'python2-tripleo-repos-*' https://trunk.rdoproject.org/centos7/current/
     yum install -y python2-tripleo-repos-*
     tripleo-repos current-tripleo
-    yum install -y $required_packages python-crypto python2-novaclient python2-neutronclient
+    yum install -y python-crypto python2-novaclient python2-neutronclient python-pip os-net-config git jq python2-os-client-config python2-openstackclient
     pip install pyghmi
+else
+    set +x
+    $signal_command --data-binary '{"status": "FAILURE"}'
+    echo "Unsupported CentOS version $centos_ver"
+    exit 1
 fi
 
 cat <<EOF >/usr/local/bin/openstackbmc