openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update ironic-python-agent from branch 'master'
  to cb61a8d6c052f4401d482ca45b43bc53935a6b28
  - Retry on checksum failures
    
    HTTP is a fun protocol.
    
    Size is basically optional. And clients implicitly trust the server
    and socket has transferred all the bytes. Which *really* means you
    should always checksum.
    
    But... previously we didn't checksum as part of retrying.
    
    So if anything happened with python-requests, or lower level
    library code or the system itself causing bytes to be lost off the
    buffer, creating an incomplete transfer situation, then we wouldn't
    know until the checksum.
    
    So now, we checksum and re-trigger the download if there is a
    failure of the checksum.
    
    This involved a minor shift in the download logic, and resulted in
    a needful minor fix to an image checksum test as it would loop for
    90 seconds as well.
    
    Closes-Bug: 2038934
    Change-Id: I543a60555a2621b49dd7b6564bd0654a46db2e9a
This commit is contained in:
Julia Kreger 2023-10-10 20:22:37 -07:00 committed by Gerrit Code Review
parent 792b2292ba
commit 104aed08d5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic-python-agent

@ -1 +1 @@
Subproject commit 89be7bd420da907cff97fad30c6b232ecb1ba76c
Subproject commit cb61a8d6c052f4401d482ca45b43bc53935a6b28