openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update cinder from branch 'master'
  to 1c3cda154f85dd09041a8d93f4d29d9ebc57a47b
  - Fix sporadic cleanup unit test failure
    
    From time to time we see unit test
    test_do_cleanup_not_cleaning_already_claimed_by_us failing at the gate
    with error:
    
        testtools.matchers._impl.MismatchError: 1 != 0
    
    This happens because the test was assuming that the machine running the
    code would get different times in consecutive utcnow() calls, which
    sometimes is not the case if the machine is fast.
    
    The places where the call is expected to have different values are:
    
    - When the test assigns original_time
    - When the test assigns other_thread_claimed_time
    - When cinder.manager.CleanableManager.do_cleanup assigns until
    
    This patch fixes this issue by simulating that:
    
    - worker1 entry was created in the past (original_time is T-1)
    
    - db's worker_get_all is mocked to simulate that worker2 entry was
      created in the past (T-1)
    
    - simulate that another thread has picked up the worker2 entry by
      writing a newer time in the DB (other_thread_claimed_time)
    
    - making sure that the do_cleanup method uses a time between these two
      (T)
    
    This way we will no longer rely on the values returned by utcnow().
    
    Change-Id: I45f1a057151e749e8c44f266ec8b41a80761ebec
This commit is contained in:
Gorka Eguileor 2021-04-15 05:58:42 +02:00 committed by Gerrit Code Review
parent 3b7015ac46
commit 13ff9444f0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder

@ -1 +1 @@
Subproject commit c12375fec6c005ba8d7e14d6f94612e7f5e66dd2
Subproject commit 1c3cda154f85dd09041a8d93f4d29d9ebc57a47b