openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update python-openstackclient from branch 'master'
  - Merge "Fix reverted osc-lib interface change"
  - Fix reverted osc-lib interface change
    
    The patch https://review.opendev.org/#/c/673389/ introduced a regression
    by changing the osc-lib interface.
    
    Two conflicting attempts to fix the regression were launched:
    
    1) Reverting the patch.
    
    2) The patch https://review.opendev.org/683119 changes the exception
       from the generic CommandError back to a specific Forbidden exception.
    
       The patch https://review.opendev.org/683118 catches this exception
       and passes on, i.e. re-implements the same behavior as before.
    
    The first idea was implemented, the initial patch reverted. The second
    idea was partially implemented. The change in python-openstackclient
    (683118) was merged. The change in osc-lib was approved but failed to
    merge because the initial change had been reverted.
    
    Now we have again a situation where the exception produced in osc-lib
    does not match the exception expected by the caller.
    
    It is unclear if the osc-lib interface will ever get a rebased version
    of https://review.opendev.org/683119 merged, so the safest way to
    address the issue is to also catch the exception that used to be
    thrown before the inital change and is again thrown after the inital
    change has been reverted.
    
    Change-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c
This commit is contained in:
Zuul 2020-08-03 14:52:17 +00:00 committed by Gerrit Code Review
parent 3f4c36ae4c
commit 20c8b32f1c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python-openstackclient

@ -1 +1 @@
Subproject commit 4e2aefb5fa2ce236473187650149cf421c5f8c53
Subproject commit af28a2f664a90a99b370de7ce854e464126d48de