From 55662b6d0873d6b3de5ac9ca0d59eada5dc356b6 Mon Sep 17 00:00:00 2001 From: Zuul Date: Tue, 19 Mar 2019 03:03:52 +0000 Subject: [PATCH] Update git submodules * Update openstack-ansible-haproxy_server from branch 'master' - Merge "Variable to set HTTP keepalive mode" - Variable to set HTTP keepalive mode The HTTP keepalive mode is currently hardcoded to "http-server-close" for all HTTP services. This disables keepalive for HAProxy to backend connections, but leaves it enabled for client connections to HAProxy. This is problematic especially for service to service calls (e.g. nova-api to neutron). If a request is made at the same time the HAProxy keepalive timeout expires, the result of the request is undefined. This leads to code 500 error responses from the nova-api because the request from nova-api to neutron failed. "Connection aborted" error messages in the logs are an indication of this issue. There is also a bug report[1] about the same issue in devstack which was solved by disabling keepalive and a script[2] to reproduce the issue in devstack. This adds a default and per service variables to set the HTTP keepalive mode used by HAProxy. The default value is changed to "forceclose" to disable HTTP keepalive on the server and client side. With HTTP keepalive disabled the issue can no longer be reproduced. [1] https://bugs.launchpad.net/devstack/+bug/1630664 [2] https://github.com/JordanP/openstack-snippets/blob/master/keepalive-race/keep-alive-race.py Change-Id: If819912873270f0568974925490023310f9cbd66 --- openstack-ansible-haproxy_server | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openstack-ansible-haproxy_server b/openstack-ansible-haproxy_server index 87925b67ba..ca51879876 160000 --- a/openstack-ansible-haproxy_server +++ b/openstack-ansible-haproxy_server @@ -1 +1 @@ -Subproject commit 87925b67baf58077e00bea1d5e75dfe64a27f88c +Subproject commit ca518798762d1c558ae13a19aeabc8f69035951c