openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update charm-ceph-radosgw from branch 'master'
  to c97fced7947e55870240557ae41dad7872a3c9d2
  - Close previously opened ports on port config change
    
    When the charm config option `port` is changed,
    the previously opened port is not closed.
    
    This leads to leaks of open ports (potential security
    issue), and long ports field on status after tests:
    
    Test:
    
        $ juju config ceph-radosgw port=1111
        $ juju config ceph-radosgw port=2222
        $ juju config ceph-radosgw port=3333
    
        $ juju status ceph-radosgw
        ...
        Unit Workload Agent Machine Public address Ports Message
        ceph-radosgw/1* blocked idle 3 10.5.2.210
        80/tcp,1111/tcp,2222/tcp,3333/tcp Missing relations: mon
        ...
    
        $ juju run --unit ceph-radosgw/1 'opened-ports'
        80/tcp
        1111/tcp
        2222/tcp
        3333/tcp
    
    Patched:
    
        $ juju run --unit ceph-radosgw/1 'opened-ports'
        80/tcp
        1111/tcp
        1234/tcp
        2222/tcp
        3333/tcp
        33331/tcp
        33332/tcp
        33334/tcp
    
        $ juju config ceph-radosgw port=33335
    
        $ juju run --unit ceph-radosgw/1 'opened-ports'
        33335/tcp
    
        $ juju status ceph-radosgw
        ...
        Unit             Workload  Agent  Machine  Public address  Ports
        Message
        ceph-radosgw/1*  blocked   idle   3        10.5.2.210      33335/tcp
        Missing relations: mon
    
        @ unit log
        2021-03-24 13:20:51 INFO juju-log Closed port 80 in favor of port 33335
        2021-03-24 13:20:51 INFO juju-log Closed port 1111 in favor of port 33335
        2021-03-24 13:20:51 INFO juju-log Closed port 1234 in favor of port 33335
        2021-03-24 13:20:51 INFO juju-log Closed port 2222 in favor of port 33335
        2021-03-24 13:20:52 INFO juju-log Closed port 3333 in favor of port 33335
        2021-03-24 13:20:52 INFO juju-log Closed port 33331 in favor of port 33335
        2021-03-24 13:20:52 INFO juju-log Closed port 33332 in favor of port 33335
        2021-03-24 13:20:52 INFO juju-log Closed port 33334 in favor of port 33335
    
    Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
    Closes-bug: #1921131
    Change-Id: I5ac4b66137faffee82ae0f1e13718f21274f1f56
This commit is contained in:
Mauricio Faria de Oliveira 2021-03-26 18:56:21 -03:00 committed by Gerrit Code Review
parent 892060edea
commit 76ab4f58d1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
charm-ceph-radosgw

@ -1 +1 @@
Subproject commit 5ab45ee5d5856031e90071e20aa20958fcd8e1d5
Subproject commit c97fced7947e55870240557ae41dad7872a3c9d2