openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update nova from branch 'master'
  to e44b1a940fdc45cc9dbb08e193a8c25052cf64e7
  - Merge "libvirt: Add a workaround to skip compareCPU() on destination"
  - libvirt: Add a workaround to skip compareCPU() on destination
    
    Nova's use of libvirt's compareCPU() API served its purpose
    over the years, but its design limitations break live migration in
    subtle ways.  For example, the compareCPU() API compares against the
    host physical CPUID.  Some of the features from this CPUID aren not
    exposed by KVM, and then there are some features that KVM emulates that
    are not in the host CPUID.  The latter can cause bogus live migration
    failures.
    
    With QEMU >=2.9 and libvirt >= 4.4.0, libvirt will do the right thing in
    terms of CPU compatibility checks on the destination host during live
    migration.  Nova satisfies these minimum version requirements by a good
    margin.  So, provide a workaround to skip the CPU comparison check on
    the destination host before migrating a guest, and let libvirt handle it
    correctly.  This workaround will be removed once Nova replaces the older
    libvirt APIs with their newer and improved counterparts[1][2].
    
                    - - -
    
    Note that Nova's libvirt driver calls compareCPU() in another method,
    _check_cpu_compatibility(); I did not remove its usage yet.  As it needs
    more careful combing of the code, and then:
    
      - where possible, remove the usage of compareCPU() altogether, and
        rely on libvirt doing the right thing under the hood; or
    
      - where Nova _must_ do the CPU comparison checks, switch to the better
        libvirt CPU APIs -- baselineHypervisorCPU() and
        compareHypervisorCPU() -- that are described here[1].  This is work
        in progress[2].
    
    [1] https://opendev.org/openstack/nova-specs/commit/70811da221035044e27
    [2] https://review.opendev.org/q/topic:bp%252Fcpu-selection-with-hypervisor-consideration
    
    Change-Id: I444991584118a969e9ea04d352821b07ec0ba88d
    Closes-Bug: #1913716
    Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
    Signed-off-by: Balazs Gibizer <bgibizer@redhat.com>
This commit is contained in:
Zuul 2022-05-25 04:55:18 +00:00 committed by Gerrit Code Review
parent f0335837b6
commit 91c61d433a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova

@ -1 +1 @@
Subproject commit 61b161eeaaed9e228b735f7c6793e7fc5bf1a830
Subproject commit e44b1a940fdc45cc9dbb08e193a8c25052cf64e7