openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update charms.openstack from branch 'master'
  - test_utils: handle non-idempotent handlers on reload
    
    A pattern across our charms is to run
    ``charms_openstack.charm.use_defaults()`` at the global level
    on top of the module encapsulating the reactive handlers
    (i.e. ``src/reactive/charm_handlers.py``).
    
    An example of an non-idempotent handler is the
    ``charm.default-select-release`` default handler, it keeps
    global state and throws a RuntimeError on subsequent calls.
    
    The way TestRegisteredHooks reloads the module makes it
    impossible to mock this out, and I think the only solution
    would be to mock this out in the test helper library itself.
    
    Closes-Bug: #1864088
    Change-Id: I9ebbda895a7a748d8efa4e23eb0c3bdf660fa759
This commit is contained in:
Frode Nordahl 2020-02-20 18:46:06 +01:00 committed by Gerrit Code Review
parent 2357cf92c9
commit 9377c47e80
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
charms.openstack

@ -1 +1 @@
Subproject commit d0f6150d4d9c9a5a95142038c1a11fba774c323e
Subproject commit 000b59c96f0e203789d876f55c436d40b5077adf